Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Stig Bjørlykke
On Mon, Apr 4, 2011 at 7:12 PM,  ger...@wireshark.org wrote:
 Log:
  On Windows, try to use an existing console for our messages. Create one if
  it doesn't exist.

This does not build with MSVC2005, because AttachConsole needs
_WIN32_WINNT 0x0500.
Did we abandon MSVC2005 and older?


-- 
Stig Bjørlykke
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Graham Bloice
On 20/06/2011 09:58, Stig Bjørlykke wrote:
 On Mon, Apr 4, 2011 at 7:12 PM,  ger...@wireshark.org wrote:
 Log:
  On Windows, try to use an existing console for our messages. Create one if
  it doesn't exist.
 This does not build with MSVC2005, because AttachConsole needs
 _WIN32_WINNT 0x0500.
 Did we abandon MSVC2005 and older?


This is a bit of an annoyance to me.  IMHO the windows builds should be
targeting an SDK, not the compiler version.  Even VC6 can use newer SDK's
which not only include all the headers and libraries for later OS's, but
update all the tools such as the compiler and linker.

I haven't tested it for this specific issue (though I have built Wireshark for
many years in this way), but I'm pretty positive that if you install a newer
SDK (use the latest 7.1) and then from your command prompt use the
SetEnv.cmd from the SDK to setup paths etc then the build will be OK.

The define you quoted is for selecting the minimum API spec of the target
system, 0x0500 is Win2K, but the function you quote is only for XP or later.

-- 
Regards,

Graham Bloice

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Stig Bjørlykke
On Mon, Jun 20, 2011 at 2:07 PM, Graham Bloice
graham.blo...@trihedral.com wrote:
 I haven't tested it for this specific issue (though I have built Wireshark
 for many years in this way), but I'm pretty positive that if you install a
 newer SDK (use the latest 7.1) and then from your command prompt use the
 SetEnv.cmd from the SDK to setup paths etc then the build will be OK.

I'm no Windows user/developer, all I have is this compiler (MSVC2005)
and I'm not able to update the SDK.
The building machine is not online.  I successfully compiled 1.4.x,
and my goal was to update to 1.6.x.

My environment is probably wrong in the first place? :)


-- 
Stig Bjørlykke
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Graham Bloice
On 20/06/2011 13:22, Stig Bjørlykke wrote:
 On Mon, Jun 20, 2011 at 2:07 PM, Graham Bloice
 graham.blo...@trihedral.com wrote:
 I haven't tested it for this specific issue (though I have built Wireshark
 for many years in this way), but I'm pretty positive that if you install a
 newer SDK (use the latest 7.1) and then from your command prompt use the
 SetEnv.cmd from the SDK to setup paths etc then the build will be OK.
 I'm no Windows user/developer, all I have is this compiler (MSVC2005)
 and I'm not able to update the SDK.
 The building machine is not online.  I successfully compiled 1.4.x,
 and my goal was to update to 1.6.x.

 My environment is probably wrong in the first place? :)


I'm not sure that your build environment was wrong, just that it's very
static and stuck with the SDK that shipped with VC2005.

In what way can't you update your build machine?  You obviously update the
sources on it.  The (free, as in beer) SDK can be installed either by using
the web installer, or by downloading the ISO and burning\mounting that as
required. See
http://www.microsoft.com/downloads/en/details.aspx?FamilyID=35aeda01-421d-4ba5-b44b-543dc8c33a20

-- 
Regards,

Graham Bloice

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Stig Bjørlykke
On Mon, Jun 20, 2011 at 2:35 PM, Graham Bloice
graham.blo...@trihedral.com wrote:
 In what way can't you update your build machine?

It's a production machine, and it's not my table at all.
The build is a Scheduled Task, all I get is the output.
My main build is for Solaris and OSX, which I control.

 You obviously update the sources on it.

I have my own internal subversion with the source.

I'm happy with any solution, I just want our source to build without
hazzle for everybody else regardless of compiler/SDK installed.


-- 
Stig Bjørlykke
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Graham Bloice
On 20/06/2011 14:00, Stig Bjørlykke wrote:
 On Mon, Jun 20, 2011 at 2:35 PM, Graham Bloice
 graham.blo...@trihedral.com wrote:
 In what way can't you update your build machine?
 It's a production machine, and it's not my table at all.
 The build is a Scheduled Task, all I get is the output.
 My main build is for Solaris and OSX, which I control.

  You obviously update the sources on it.
 I have my own internal subversion with the source.

 I'm happy with any solution, I just want our source to build without
 hazzle for everybody else regardless of compiler/SDK installed.


Whilst that would be perfect, it isn't really practical without reams of fugly
conditional compilation.  Windows Service Packs add functions to their base
OS, and unless you upgrade the SDK you won't be able to use them, so VS2005
stock can't use any stuff added in XP SP3 for instance.  The current
standard used for Wireshark releases is VS2008, can you get the build
machine moved to that?

As the earliest version supported is XP I think more functions from SP3 might
be used forcing VS2005 folks to upgrade their SDK.  Maybe we also need to
tighten the supported platforms info to explicitly state the SP of XP, as I'm
not certain that Wireshark will run on plain old XP.  MS only provides
Extended support for XP SP3 until 2014.  Extended means security patches only.

-- 
Regards,

Graham Bloice

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Stig Bjørlykke
On Mon, Jun 20, 2011 at 3:20 PM, Graham Bloice
graham.blo...@trihedral.com wrote:
 The current standard used for Wireshark releases is VS2008, can you get the 
 build
 machine moved to that?

I may have to install a VM.
The problem is that I did not intend to use any more time on the
windows build issues.
With the fix the build is ok, and Wireshark 1.6.0 run on XP SP2
which is the test platform.


-- 
Stig Bjørlykke
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe