Re: [Wireshark-dev] buildbot failure in Wireshark (development) on OSX
On 14/01/2011 12:24, buildbot-no-re...@wireshark.org wrote:
The Buildbot has detected a new failure of OSX-10.6-x64 on Wireshark
(development).
Full details are available at:
http://buildbot.wireshark.org/trunk/builders/OSX-10.6-x64/builds/1636
Buildbot URL: http://buildbot.wireshark.org/trunk/
Buildslave for this Build: osx-10.6-x64
Build Reason:
Build Source Stamp: 35533
Blamelist: grahamb
BUILD FAILED: failed compile
Any idea why the OSX compilers are complaining about this code in packet-dnp.c:
if (!header_only || al_objq_index 0) {
start_offset = offset;
for (item_num = 0; item_num num_items; item_num++)
{
/* Create Point item and Process Index */
if (AL_OBJQL_IDX_NI = al_objq_index al_objq_index =
AL_OBJQL_IDX_4O) -- Error here
point_item = proto_tree_add_text(object_tree, tvb, offset, -1, Point
Number);
else
point_item = proto_tree_add_text(object_tree, tvb, offset, -1,
Object: Size);
point_tree = proto_item_add_subtree(point_item, ett_dnp3_al_obj_point);
data_pos = offset;
indexbytes = dnp3_al_obj_procindex(tvb, offset, al_objq_index,
al_ptaddr, point_tree);
proto_item_append_text(point_item, %u, al_ptaddr);
proto_item_set_len(point_item, indexbytes);
data_pos += indexbytes;
if (!header_only || (AL_OBJQL_IDX_1OS = al_objq_index al_objq_index
= AL_OBJQL_IDX_4OS)) {
The reported error is:
packet-dnp.c: In function 'dnp3_al_process_object':
packet-dnp.c:1566: warning: comparison is always true due to limited range of
data type
The variable (al_objq_index) is three bits so has a value between 0 and 7 and
the constants are enumerations of the values. AL_OBJQL_IDX_NI is 0 and
AL_OBJQL_IDX_4O is 3. I suspect that the following if() might also error out
as it just checks for a different range of values (4-6).
--
Regards,
Graham Bloice
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] buildbot failure in Wireshark (development) on OSX
Graham Bloice wrote:
Any idea why the OSX compilers are complaining about this code in
packet-dnp.c:
if (!header_only || al_objq_index 0) {
start_offset = offset;
for (item_num = 0; item_num num_items; item_num++)
{
/* Create Point item and Process Index */
if (AL_OBJQL_IDX_NI = al_objq_index al_objq_index =
AL_OBJQL_IDX_4O) -- Error here
[...]
The reported error is:
packet-dnp.c: In function 'dnp3_al_process_object':
packet-dnp.c:1566: warning: comparison is always true due to limited range of
data type
The variable (al_objq_index) is three bits so has a value between 0 and
7 and the constants are enumerations of the values. AL_OBJQL_IDX_NI is
0 and AL_OBJQL_IDX_4O is 3. I suspect that the following if() might
also error out as it just checks for a different range of values (4-6).
The problem is that al_objq_index is a guint8 and AL_OBJQL_IDX_NI is
0x0. Since an unsigned variable can't go negative, al_objq_index is
ALWAYS greater than AL_OBJQL_IDX_NI (0).
From quickly looking at the code, I'd guess that this comparison can
simply be removed.
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] buildbot failure in Wireshark (development) on OSX
On 14/01/2011 14:26, Jeff Morriss wrote:
Graham Bloice wrote:
Any idea why the OSX compilers are complaining about this code in
packet-dnp.c:
if (!header_only || al_objq_index 0) {
start_offset = offset;
for (item_num = 0; item_num num_items; item_num++)
{
/* Create Point item and Process Index */
if (AL_OBJQL_IDX_NI = al_objq_index al_objq_index =
AL_OBJQL_IDX_4O) -- Error here
[...]
The reported error is:
packet-dnp.c: In function 'dnp3_al_process_object':
packet-dnp.c:1566: warning: comparison is always true due to limited range
of data type
The variable (al_objq_index) is three bits so has a value between 0 and 7
and the constants are enumerations of the values. AL_OBJQL_IDX_NI is 0 and
AL_OBJQL_IDX_4O is 3. I suspect that the following if() might also error
out as it just checks for a different range of values (4-6).
The problem is that al_objq_index is a guint8 and AL_OBJQL_IDX_NI is 0x0.
Since an unsigned variable can't go negative, al_objq_index is ALWAYS
greater than AL_OBJQL_IDX_NI (0).
From quickly looking at the code, I'd guess that this comparison can simply
be removed.
Thanks. I'll fix it up.
--
Regards,
Graham Bloice
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-PowerPC
buildbot-no-re...@wireshark.org wrote: The Buildbot has detected a new failure of OSX-10.5-PowerPC on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-PowerPC/builds/1331 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-ppc Build Reason: Build Source Stamp: 3 Blamelist: guy,wmeier BUILD FAILED: failed compile I'm looking at this Bill ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-ppc
On Nov 18, 2009, at 10:42 PM, Stig Bjørlykke wrote: On 18. nov. 2009, at 20.54, buildbot-no-re...@wireshark.org wrote: The Buildbot has detected a new failure of OSX-10.5-ppc on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-ppc/builds/583 Does anyone know why this happends? It looks like a timeout creating libwireshark. The system is a slow, old G4 MacMini which runs headless. I think some bluetooth system is not performing well when there is not keyboard/mouse via USB or Bluetooth. I tried to improve the configuration (switch off bluetooth) and rebooted the system. Let's see if it helps. Best regards Michael -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-ppc
... due to a reboot. Best regards Michael On Nov 19, 2009, at 12:15 PM, buildbot-no-re...@wireshark.org wrote: The Buildbot has detected a new failure of OSX-10.5-ppc on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-ppc/builds/588 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-ppc Build Reason: Build Source Stamp: 31015 Blamelist: etxrab BUILD FAILED: failed failed slave lost sincerely, -The Buildbot ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-ppc
On 18. nov. 2009, at 20.54, buildbot-no-re...@wireshark.org wrote: The Buildbot has detected a new failure of OSX-10.5-ppc on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-ppc/builds/583 Does anyone know why this happends? It looks like a timeout creating libwireshark. -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-ppc
On Nov 18, 2009, at 10:42 PM, Stig Bjørlykke wrote: On 18. nov. 2009, at 20.54, buildbot-no-re...@wireshark.org wrote: The Buildbot has detected a new failure of OSX-10.5-ppc on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-ppc/builds/583 Does anyone know why this happends? It looks like a timeout creating libwireshark. Let me have a look... Best regards Michael -- Stig Bjørlykke ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
Re: [Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-ppc
On Apr 21, 2009, at 10:35 AM, buildbot-no-re...@wireshark.org wrote: The Buildbot has detected a new failure of OSX-10.5-ppc on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-ppc/builds/957 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-ppc Build Reason: Build Source Stamp: HEAD Blamelist: etxrab,guy BUILD FAILED: failed compile The warnings are: ranap.cnf:1490: warning: 'dissect_ranap_ForwardingIndication' defined but not used ranap.cnf:764: warning: 'dissect_ranap_LastVisitedUTRANCell_Item' defined but not used ranap.cnf:293: warning: 'dissect_ranap_Source_ToTarget_TransparentContainer' defined but not used ranap.cnf:303: warning: 'dissect_ranap_SourceeNodeB_ToTargeteNodeB_TransparentContainer' defined but not used ranap.cnf:483: warning: 'dissect_ranap_SRVCC_Operation_Possible' defined but not used ranap.cnf:493: warning: 'dissect_ranap_Target_ToSource_TransparentContainer' defined but not used ranap.cnf:503: warning: 'dissect_ranap_TargeteNodeB_ToSourceeNodeB_TransparentContainer' defined but not used What causes unused dissector routines to be generated by asn2wrs? I have the impression that there's stuff you can put into the .cnf file to suppress them, but is there a way for asn2wrs to recognize that something won't be used? ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
