Re: wmaker: default icon size ?
Quoting message written on Wednesday 2014-06-04 14:01:47 by David Maciejak: > Hi, > > Enclosed my current info panel, with an updated logo size from 45x45 to > 64x64, I believe 128x128 could be even better with some auto resize > when necessary. > > Any thoughts ? I think 64x64 is better than before. I don't think that 128x128 with added autoresize support is necessary. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.5-440-gc7a91d77
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.
The branch, next has been updated
discards 43544fcb4e08c25b73ac00686e06317a1cc5b052 (commit)
discards 3c7646f87cb7cebde5bbea49b2a7b8a3c0cd4e80 (commit)
via c7a91d7750c2b1acc160f7b5d22fcf0b7936516e (commit)
via c994b65f14ad2ab872f5c1b91119d78885743cfc (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (43544fcb4e08c25b73ac00686e06317a1cc5b052)
N -- N -- N (c7a91d7750c2b1acc160f7b5d22fcf0b7936516e)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://repo.or.cz/w/wmaker-crm.git/commit/c7a91d7750c2b1acc160f7b5d22fcf0b7936516e
commit c7a91d7750c2b1acc160f7b5d22fcf0b7936516e
Author: Doug Torrance
Date: Tue Jun 3 07:52:29 2014 -0600
Add checkpatch.pl to distribution tarball.
This patch includes checkpatch.pl in the EXTRA_DIST variable in Makefile.am
so
that it is included when a tarball is built using "make dist".
diff --git a/Makefile.am b/Makefile.am
index 3309718d..b92e0dde 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -36,7 +36,7 @@ EXTRA_DIST = TODO BUGS BUGFORM FAQ FAQ.I18N INSTALL
INSTALL-WMAKER README.definable-cursor
The-perfect-Window-Maker-patch.txt README COPYING.WTFPL autogen.sh -
email-clients.txt
+ email-clients.txt checkpatch.pl
if USE_LCOV
coverage-reset:
http://repo.or.cz/w/wmaker-crm.git/commit/c994b65f14ad2ab872f5c1b91119d78885743cfc
commit c994b65f14ad2ab872f5c1b91119d78885743cfc
Author: David Maciejak
Date: Tue Jun 3 22:09:39 2014 +0800
WPrefs: add expert option to disable switch panel
This patch is adding a checkbox option in the expert panel
to be able to disable the Alt-Tab window switching panel from the pref GUI.
diff --git a/WPrefs.app/Expert.c b/WPrefs.app/Expert.c
index e939df03..042636ac 100644
--- a/WPrefs.app/Expert.c
+++ b/WPrefs.app/Expert.c
@@ -31,6 +31,7 @@ static const struct {
enum {
OPTION_WMAKER,
+ OPTION_WMAKER_ARRAY,
OPTION_USERDEF
} class;
@@ -50,6 +51,9 @@ static const struct {
{ N_("Use SaveUnder in window frames, icons, menus and other objects."),
/* default: */ False, OPTION_WMAKER, "UseSaveUnders" },
+ { N_("Do not display Alt-Tab window switching panel."),
+ /* default: */ False, OPTION_WMAKER_ARRAY, "SwitchPanelImages" },
+
{ N_("Disable confirmation panel for the Kill command."),
/* default: */ False, OPTION_WMAKER, "DontConfirmKill" },
@@ -96,7 +100,7 @@ typedef struct _Panel {
#define ICON_FILE "expert"
-static void createPanel(Panel * p)
+static void createPanel(Panel *p)
{
_Panel *panel = (_Panel *) p;
WMScrollView *sv;
@@ -134,6 +138,15 @@ static void createPanel(Panel * p)
state = expert_options[i].def_state;
break;
+ case OPTION_WMAKER_ARRAY: {
+ char *str =
GetStringForKey(expert_options[i].op_name);
+ if (str && strcasecmp(str, "None") == 0)
+ state = True;
+ else
+ state = expert_options[i].def_state;
+ }
+ break;
+
case OPTION_USERDEF:
state = WMGetUDBoolForKey(udb,
expert_options[i].op_name);
break;
@@ -141,7 +154,7 @@ static void createPanel(Panel * p)
default:
#ifdef DEBUG
wwarning("export_options[%d].class = %d, this should
not happenn",
-i, expert_options[i].class);
+ i, expert_options[i].class);
#endif
state = expert_options[i].def_state;
break;
@@ -154,7 +167,7 @@ static void createPanel(Panel * p)
WMRealizeWidget(panel->box);
}
-static void storeDefaults(_Panel * panel)
+static void storeDefaults(_Panel *panel)
{
WMUserDefaults *udb = WMGetStandardUserDefaults();
int i;
@@ -165,6 +178,17 @@ static void storeDefaults(_Panel * panel)
SetBoolForKey(WMGetButtonSelected(p
Re: [PATCH] WPrefs: add expert option to disable switch panel
On Tue, 3 Jun 2014 at 17:04:14 +0200, Josip Deanovic wrote: > or "Do not display Alt-Tab window switching panel" If nobody complains, I will use this suggestion. > BTW, thank you for adding that option to WPrefs. Indeed. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoting message written on Tuesday 2014-06-03 22:57:15 by David Maciejak: > On Tuesday, June 3, 2014, Josip Deanovic wrote: > > That's true but I agree with Carlos that the current description might > > be misleading to users, especially to those that lack the knowledge of > > Windowmaker's internal functions and their naming. > > I see no problem to change the description, please everybody share your > ideas ! Maybe something like: "Do not show Alt-Tab window switching panel" or "Do not display Alt-Tab window switching panel" BTW, thank you for adding that option to WPrefs. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
On Tue, 3 Jun 2014 at 22:43:22 +0800, David Maciejak wrote:
> On Tuesday, June 3, 2014, Carlos R. Mafra wrote:
>
> > On Tue, 3 Jun 2014 at 22:13:43 +0800, David Maciejak wrote:
> > > This patch is adding a checkbox option in the expert panel
> > > to be able to disable the Alt-Tab window switching panel from the pref
> > GUI.
> > >
> > > Please test, i experienced some weird things with the inotify stuff,
> > > sometime a wmaker hot restart is needed to force reload the conf.
> >
> > >
> > > + { N_("Disable Alt-Tab window switching panel."),
> > > + /* default: */ False, OPTION_WMAKER_ARRAY, "SwitchPanelImages" },
> >
> > Perhaps "Do not display Alt-Tab panel icons" would be better?
> >
> > Otherwise I have the impression that people could misunderstand what
> > this option does by thinking that we are disabling the switch panel
> > altogether.
> >
> >
> >
> That option is effectively disabling *all* the switch panel, not only the
> icons.
> In fact it can be used either to disable the panel or to set panel bg image.
Yes, but the point is that we should try to emphasize that the option
disables just the display (no icons, no background image), and that
the Alt-Tab shortcut will still have the effect of switching windows.
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
On Tuesday, June 3, 2014, Josip Deanovic wrote: > Quoting message written on Tuesday 2014-06-03 22:43:22 by David Maciejak: > > That option is effectively disabling *all* the switch panel, not only > > the icons. > > In fact it can be used either to disable the panel or to set panel bg > > image. > > That's true but I agree with Carlos that the current description might > be misleading to users, especially to those that lack the knowledge of > Windowmaker's internal functions and their naming. > > I see no problem to change the description, please everybody share your ideas !
Re: [PATCH] WPrefs: add expert option to disable switch panel
Quoting message written on Tuesday 2014-06-03 22:43:22 by David Maciejak: > That option is effectively disabling *all* the switch panel, not only > the icons. > In fact it can be used either to disable the panel or to set panel bg > image. That's true but I agree with Carlos that the current description might be misleading to users, especially to those that lack the knowledge of Windowmaker's internal functions and their naming. -- Josip Deanovic -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
On 06/03/2014 05:33 PM, Carlos R. Mafra wrote: Perhaps "Do not display Alt-Tab panel icons" would be better? Otherwise I have the impression that people could misunderstand what this option does by thinking that we are disabling the switch panel altogether. Why not "Switch windows without (showing) switch panel" then? Yury -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
Re: [PATCH] WPrefs: add expert option to disable switch panel
On Tuesday, June 3, 2014, Carlos R. Mafra wrote:
> On Tue, 3 Jun 2014 at 22:13:43 +0800, David Maciejak wrote:
> > This patch is adding a checkbox option in the expert panel
> > to be able to disable the Alt-Tab window switching panel from the pref
> GUI.
> >
> > Please test, i experienced some weird things with the inotify stuff,
> > sometime a wmaker hot restart is needed to force reload the conf.
>
> >
> > + { N_("Disable Alt-Tab window switching panel."),
> > + /* default: */ False, OPTION_WMAKER_ARRAY, "SwitchPanelImages" },
>
> Perhaps "Do not display Alt-Tab panel icons" would be better?
>
> Otherwise I have the impression that people could misunderstand what
> this option does by thinking that we are disabling the switch panel
> altogether.
>
>
>
That option is effectively disabling *all* the switch panel, not only the
icons.
In fact it can be used either to disable the panel or to set panel bg image.
[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.5-440-g43544fcb
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project wmaker-crm.git.
The branch, next has been updated
via 43544fcb4e08c25b73ac00686e06317a1cc5b052 (commit)
via 3c7646f87cb7cebde5bbea49b2a7b8a3c0cd4e80 (commit)
from 137a571fece4b21bfca24b97e76d6b1a8151a477 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -
http://repo.or.cz/w/wmaker-crm.git/commit/43544fcb4e08c25b73ac00686e06317a1cc5b052
commit 43544fcb4e08c25b73ac00686e06317a1cc5b052
Author: Doug Torrance
Date: Tue Jun 3 07:52:29 2014 -0600
Add checkpatch.pl to distribution tarball.
This patch includes checkpatch.pl in the EXTRA_DIST variable in Makefile.am
so
that it is included when a tarball is built using "make dist".
diff --git a/Makefile.am b/Makefile.am
index 3309718d..b92e0dde 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -36,7 +36,7 @@ EXTRA_DIST = TODO BUGS BUGFORM FAQ FAQ.I18N INSTALL
INSTALL-WMAKER README.definable-cursor
The-perfect-Window-Maker-patch.txt README COPYING.WTFPL autogen.sh -
email-clients.txt
+ email-clients.txt checkpatch.pl
if USE_LCOV
coverage-reset:
http://repo.or.cz/w/wmaker-crm.git/commit/3c7646f87cb7cebde5bbea49b2a7b8a3c0cd4e80
commit 3c7646f87cb7cebde5bbea49b2a7b8a3c0cd4e80
Author: David Maciejak
Date: Tue Jun 3 22:09:39 2014 +0800
WPrefs: add expert option to disable switch panel
This patch is adding a checkbox option in the expert panel
to be able to disable the Alt-Tab window switching panel from the pref GUI.
diff --git a/WPrefs.app/Expert.c b/WPrefs.app/Expert.c
index e939df03..0ed0e149 100644
--- a/WPrefs.app/Expert.c
+++ b/WPrefs.app/Expert.c
@@ -31,6 +31,7 @@ static const struct {
enum {
OPTION_WMAKER,
+ OPTION_WMAKER_ARRAY,
OPTION_USERDEF
} class;
@@ -50,6 +51,9 @@ static const struct {
{ N_("Use SaveUnder in window frames, icons, menus and other objects."),
/* default: */ False, OPTION_WMAKER, "UseSaveUnders" },
+ { N_("Disable Alt-Tab window switching panel."),
+ /* default: */ False, OPTION_WMAKER_ARRAY, "SwitchPanelImages" },
+
{ N_("Disable confirmation panel for the Kill command."),
/* default: */ False, OPTION_WMAKER, "DontConfirmKill" },
@@ -96,7 +100,7 @@ typedef struct _Panel {
#define ICON_FILE "expert"
-static void createPanel(Panel * p)
+static void createPanel(Panel *p)
{
_Panel *panel = (_Panel *) p;
WMScrollView *sv;
@@ -134,6 +138,15 @@ static void createPanel(Panel * p)
state = expert_options[i].def_state;
break;
+ case OPTION_WMAKER_ARRAY: {
+ char *str =
GetStringForKey(expert_options[i].op_name);
+ if (str && strcasecmp(str, "None") == 0)
+ state = True;
+ else
+ state = expert_options[i].def_state;
+ }
+ break;
+
case OPTION_USERDEF:
state = WMGetUDBoolForKey(udb,
expert_options[i].op_name);
break;
@@ -141,7 +154,7 @@ static void createPanel(Panel * p)
default:
#ifdef DEBUG
wwarning("export_options[%d].class = %d, this should
not happenn",
-i, expert_options[i].class);
+ i, expert_options[i].class);
#endif
state = expert_options[i].def_state;
break;
@@ -154,7 +167,7 @@ static void createPanel(Panel * p)
WMRealizeWidget(panel->box);
}
-static void storeDefaults(_Panel * panel)
+static void storeDefaults(_Panel *panel)
{
WMUserDefaults *udb = WMGetStandardUserDefaults();
int i;
@@ -165,6 +178,17 @@ static void storeDefaults(_Panel * panel)
SetBoolForKey(WMGetButtonSelected(panel->swi[i]),
expert_options[i].op_name);
break;
+ case OPTION_WMAKER_ARRAY:
+ if (WMGetButtonSelected(panel->swi[i]))
+ SetStringForKey("None",
expert_options[i].op_name);
+ else {
+ /* check if the array was not manually modified
*/
+ char *str =
GetStringForKey(expert_options[i].op_name);
+ if (str && strcasecmp(str, "None") == 0)
+
RemoveObjectForKey(expert_options[i].op_name);
+
Re: [PATCH] WPrefs: add expert option to disable switch panel
On Tue, 3 Jun 2014 at 22:13:43 +0800, David Maciejak wrote:
> This patch is adding a checkbox option in the expert panel
> to be able to disable the Alt-Tab window switching panel from the pref GUI.
>
> Please test, i experienced some weird things with the inotify stuff,
> sometime a wmaker hot restart is needed to force reload the conf.
>
> + { N_("Disable Alt-Tab window switching panel."),
> + /* default: */ False, OPTION_WMAKER_ARRAY, "SwitchPanelImages" },
Perhaps "Do not display Alt-Tab panel icons" would be better?
Otherwise I have the impression that people could misunderstand what
this option does by thinking that we are disabling the switch panel
altogether.
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH] Add checkpatch.pl to distribution tarball.
This patch includes checkpatch.pl in the EXTRA_DIST variable in Makefile.am so that it is included when a tarball is built using "make dist". --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 3309718..b92e0dd 100644 --- a/Makefile.am +++ b/Makefile.am @@ -36,7 +36,7 @@ EXTRA_DIST = TODO BUGS BUGFORM FAQ FAQ.I18N INSTALL \ INSTALL-WMAKER README.definable-cursor \ The-perfect-Window-Maker-patch.txt \ README COPYING.WTFPL autogen.sh \ - email-clients.txt + email-clients.txt checkpatch.pl if USE_LCOV coverage-reset: -- 1.9.1 -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
[PATCH] WPrefs: add expert option to disable switch panel
This patch is adding a checkbox option in the expert panel
to be able to disable the Alt-Tab window switching panel from the pref GUI.
Please test, i experienced some weird things with the inotify stuff,
sometime a wmaker hot restart is needed to force reload the conf.
thanks,
david
---
WPrefs.app/Expert.c | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
diff --git a/WPrefs.app/Expert.c b/WPrefs.app/Expert.c
index e939df0..0ed0e14 100644
--- a/WPrefs.app/Expert.c
+++ b/WPrefs.app/Expert.c
@@ -31,6 +31,7 @@ static const struct {
enum {
OPTION_WMAKER,
+ OPTION_WMAKER_ARRAY,
OPTION_USERDEF
} class;
@@ -50,6 +51,9 @@ static const struct {
{ N_("Use SaveUnder in window frames, icons, menus and other objects."),
/* default: */ False, OPTION_WMAKER, "UseSaveUnders" },
+ { N_("Disable Alt-Tab window switching panel."),
+ /* default: */ False, OPTION_WMAKER_ARRAY, "SwitchPanelImages" },
+
{ N_("Disable confirmation panel for the Kill command."),
/* default: */ False, OPTION_WMAKER, "DontConfirmKill" },
@@ -96,7 +100,7 @@ typedef struct _Panel {
#define ICON_FILE "expert"
-static void createPanel(Panel * p)
+static void createPanel(Panel *p)
{
_Panel *panel = (_Panel *) p;
WMScrollView *sv;
@@ -134,6 +138,15 @@ static void createPanel(Panel * p)
state = expert_options[i].def_state;
break;
+ case OPTION_WMAKER_ARRAY: {
+ char *str = GetStringForKey(expert_options[i].op_name);
+ if (str && strcasecmp(str, "None") == 0)
+ state = True;
+ else
+ state = expert_options[i].def_state;
+ }
+ break;
+
case OPTION_USERDEF:
state = WMGetUDBoolForKey(udb, expert_options[i].op_name);
break;
@@ -141,7 +154,7 @@ static void createPanel(Panel * p)
default:
#ifdef DEBUG
wwarning("export_options[%d].class = %d, this should not happen\n",
- i, expert_options[i].class);
+ i, expert_options[i].class);
#endif
state = expert_options[i].def_state;
break;
@@ -154,7 +167,7 @@ static void createPanel(Panel * p)
WMRealizeWidget(panel->box);
}
-static void storeDefaults(_Panel * panel)
+static void storeDefaults(_Panel *panel)
{
WMUserDefaults *udb = WMGetStandardUserDefaults();
int i;
@@ -165,6 +178,17 @@ static void storeDefaults(_Panel * panel)
SetBoolForKey(WMGetButtonSelected(panel->swi[i]), expert_options[i].op_name);
break;
+ case OPTION_WMAKER_ARRAY:
+ if (WMGetButtonSelected(panel->swi[i]))
+ SetStringForKey("None", expert_options[i].op_name);
+ else {
+ /* check if the array was not manually modified */
+ char *str = GetStringForKey(expert_options[i].op_name);
+ if (str && strcasecmp(str, "None") == 0)
+ RemoveObjectForKey(expert_options[i].op_name);
+ }
+ break;
+
case OPTION_USERDEF:
WMSetUDBoolForKey(udb, WMGetButtonSelected(panel->swi[i]),
expert_options[i].op_name);
break;
--
1.8.3.2
0001-WPrefs-add-expert-option-to-disable-switch-panel.patch
Description: Binary data
