[PATCH] WPrefs: remove unfinished background tab from appearances panel code

[Doug Torrance]

WPrefs.app/Appearances.c contained code for an unfinished feature
in the appearances panel of WPrefs, a tab for setting the background.

Since this feature has now been implemented as part of the texture
tab (see commit c2aca1a), there is no reason to keep this code.
---
 WPrefs.app/Appearance.c | 32 
 1 file changed, 32 deletions(-)

diff --git a/WPrefs.app/Appearance.c b/WPrefs.app/Appearance.c
index 90690ac..0c0c724 100644
--- a/WPrefs.app/Appearance.c
+++ b/WPrefs.app/Appearance.c
@@ -75,14 +75,6 @@ typedef struct _Panel {
WMFrame *taliF;
WMButton *taliB[3];
 
-   /* root bg */
-   WMFrame *bgF;
-
-   WMLabel *bgprevL;
-   WMButton *selbgB;
-
-   WMPopUpButton *modeB[3];
-
/* */
 
int textureIndex[8];
@@ -1804,30 +1796,6 @@ static void createPanel(Panel * p)
 
WMMapSubwidgets(panel-colF);
 
-#ifdef unfinished
-/*** root bg ***/
-
-   panel-bgF = WMCreateFrame(panel-box);
-   WMSetFrameRelief(panel-bgF, WRFlat);
-
-   item = WMCreateTabViewItemWithIdentifier(2);
-   WMSetTabViewItemView(item, WMWidgetView(panel-bgF));
-   WMSetTabViewItemLabel(item, _(Background));
-
-   WMAddItemInTabView(panel-tabv, item);
-
-   panel-bgprevL = WMCreateLabel(panel-bgF);
-   WMResizeWidget(panel-bgprevL, 230, 155);
-   WMMoveWidget(panel-bgprevL, 5, 5);
-   WMSetLabelRelief(panel-bgprevL, WRSunken);
-
-   panel-selbgB = WMCreateCommandButton(panel-bgF);
-   WMMoveWidget(panel-selbgB, 5, 165);
-   WMResizeWidget(panel-selbgB, 100, 24);
-   WMSetButtonText(panel-selbgB, _(Browse...));
-
-   WMMapSubwidgets(panel-bgF);
-#endif /* unfinished */
 /*** options ***/
panel-optF = WMCreateFrame(panel-box);
WMSetFrameRelief(panel-optF, WRFlat);
-- 
1.9.1


-- 
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.

Re: [PATCH] WPrefs: remove unfinished background tab from appearances panel code

[Carlos R. Mafra]

On Fri, 16 May 2014 at  9:39:57 -0500, Doug Torrance wrote:
 
 Since this feature has now been implemented as part of the texture
 tab (see commit c2aca1a), there is no reason to keep this code.

Just a minor comment. Unless the patch is already in the master branch
(which is not the case here) the commit sha1 is not a perennial reference.

So I'd like to suggest that everybody referring to some commit to also
write its description line. In this case it would be:
see commit c2aca1a (WPrefs: Set workspace background).

That not only makes the reference more robust, but also helps in
creating the appropriate context in the patch description.

In any case, don't need to resend this one. I'll edit it myself.


-- 
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.

Re: [PATCH] WPrefs: remove unfinished background tab from appearances panel code

[Torrance, Douglas]

On 05/16/2014 12:19 PM, Carlos R. Mafra wrote:
 Just a minor comment. Unless the patch is already in the master branch
 (which is not the case here) the commit sha1 is not a perennial reference.

 So I'd like to suggest that everybody referring to some commit to also
 write its description line. In this case it would be:
 see commit c2aca1a (WPrefs: Set workspace background).

 That not only makes the reference more robust, but also helps in
 creating the appropriate context in the patch description.

 In any case, don't need to resend this one. I'll edit it myself.

Good to know.  Thanks, Carlos!

--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.