Patches for wmmon

[Rodolfo García Peñas (kix)]

Hi,

I have a question about include some patches in wmmon.

Pedro sent some patches to Debian BTS (see [1]). Patches are nice, but
they have some things that I am not sure if they are ok for us. My
comment is about the change from CC to GCC compiler and use gcc
specific definitions:

1. Change the CC compiler to gcc (wmmon-1.1%2B20120402.patch [2])
2. Usage the llong, perhaps gcc specific [2]
3. Include a new file in the library wmgeneral. I think wmgeneral is a
common library. Perhaps we should create a new library libwmgeneral in
the dockapps repo and link/include the dockapps to them (see wmSMPmon,
wmbiff, wmckgmail,wmitime, wmmon,...).

kix


[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=670151
[2]
https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=20;filename=wmmon-1.1%2B20120402.patch;att=1;bug=670151

Rodolfo García Peñas (kix)
http://www.kix.es/


--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.

Re: Patches for wmmon

[Torrance, Douglas]

On 08/11/2014 06:02 AM, Rodolfo García Peñas (kix) wrote:
 1. Change the CC compiler to gcc (wmmon-1.1%2B20120402.patch [2])
 2. Usage the llong, perhaps gcc specific [2]
 3. Include a new file in the library wmgeneral. I think wmgeneral is a 
 common library. Perhaps we should create a new library libwmgeneral in 
 the dockapps repo and link/include the dockapps to them (see wmSMPmon, 
 wmbiff, wmckgmail,wmitime, wmmon,...).

I've had the same thought.  It would make fixing bugs in wmgeneral much 
easier.  For example, if you run a dockapp that uses wmgeneral with the 
-display option but don't specify which display, you get a segfault.

There would be some work up front of linking each dockapp with the new 
library, but then we could just fix bugs in libwmgeneral.

It looks like there's 11 dockapps in the repo now which use it:

dtorrance@zella:~/src/dockapps/dockapps$ ls -d1 */wmgeneral
wmbiff/wmgeneral
wmckgmail/wmgeneral
wmitime/wmgeneral
wmkeys/wmgeneral
wmmon/wmgeneral
wmppp.app/wmgeneral
wmsm.app/wmgeneral
wmSMPmon/wmgeneral
wmtime/wmgeneral
wmtz/wmgeneral
wmweather+/wmgeneral

Doug

-- 
Douglas A. Torrance, Ph.D.
Visiting Assistant Professor
Department of Mathematics and Computer Science
Monmouth College