[wpkg-users] [Bug 173] Allow the use of environment variables for checking file revisions

[bugzilla-daemon]

http://bugzilla.wpkg.org/show_bug.cgi?id=173





--- Comment #3 from Rainer Meier   2009-09-26 00:37:33 ---
Created an attachment (id=154)
 --> (http://bugzilla.wpkg.org/attachment.cgi?id=154)
WPKG 1.1.2 release

Public release

Change notes

WPKG Version: 1.1.2
Author: : Rainer Meier 
Date: 2009-09-26
Status  : released

Changes/fixes visible to the user:

Summary:
- Added path/value expansion for registry checks. Fixes Bug 139.
- Added variable expansion for registry uninstall searches. 
- Fixed typos.
- Added additional status print messages on installation tasks.
- Fixed exception when getting system locale on some systems.
- Another small fix for system locale read.
- Moved documents to documents/ folder.
- Updated some documentation.
- WPKG now saves progress immediately to settings (wpkg.xml)
- Environment load/restore code changes.
- Revert partially the environment load/restore code changes.
- Fixed two more environment load/restore bugs.
- Fixed bug introduced with immediate setting save. Fixes Bug 167.
- Fixed uninstall version check in case of non-installed software.
- Fixed uninstall version comparison "versionsmallerthan".
- Added execute="changed" attribute to packages.
- Fixed notify="false" was not taken into account during removal.
- Notifications are now only sent if commands are executed.
- Version comparison improvement during installation.
- Added regular expression matching to uninstall key search.
- Changed informational level to debug level output for registry check.
- Added Windows Vista/7 msg.exe user-notification support.
- Added expansion of environment variables in rebootCmd setting.
- Fixed typo in registry equality check.
- Fixed some more code formatting and typo.
- Updated built-in user notification text.
- Added environment expansion in package revision attribute.
- Fixed duplicated version read from file if a file version check is used.
- Added environment value expansion for file version values.
- Added environment value expansion for uninstall version values.
- Added environment value expansion for execute check return values.
- Modified printed debug message if uninstall checks regex match fails.

NEW: Registry path checks can now contain variables in the form of %VAR% too.
 Variable expansion is allowed for the value attribute too. Please note
 that WPKG first tries to locate the unexpanded key and compare unexpanded
 values. For example if you use a registry equal check for the value of
 "%APPDATA%" then it first tries to look for the "%APPDATA%" string and
 only if this value does not exist it will compare the expanded value.
 This allows you to still match REG_EXPAND_SZ values which contain
 variable definitions.
 This should fix Bug 139 as reported on Bugzilla.
 Thanks to "graham" for reporting.
NEW: Variable expansion (see Bug 139) is now supported for uninstall entries as
 as well.
FIX: Fixed a couple of typos. Thanks to Malte Starostik for reporting.
NEW: Added additional output to the status printer (when /sendStatus is
 enabled) when installPackage() performs installation tasks and therefore
 takes some time to finish. This allows external tools to inform the user
 about ongoing actions.
 Thanks to Malte Starostik for the suggestion.
FIX: Retrieving the system locale caused an exception on some systems.
 Thanks to Simon Kelsall for reporting.
FIX: Fixed another small problem when locating system locales which could lead
 to an exception in case the "HKCU\Control Panel\International\Locale" key
 does not exist.
MOD: Moved documents to the documents/ sub-folder in order to clean up the root
 directory.
MOD: Small corrections and updates to some documents.
MOD: Modified bahavior of WPKG whensaving settings (wpkg.xml). Now the settings
 are saved immediately after modification instead of just when WPKG
 terminates. Mainly this helps in case of unexpected reboot (initiated
 outside WPKG) to prevent loss of some progress in case of unexpected
 interruption.
 Thanks to Johannes Brix for open discussion on the mailing list.
MOD: Changed some code to load package environment and and when restoring
 previous environment to prevent some IDE errors (but cscript somehow seems
 to accept the code).
FIX: The environment set changes done in previous release did not work as$
 expected. WSH does not provide convenient methods to modify the
 environment. Maybe I will find a work-around later...
FIX: Fixed two more bugs introduced in 1.1.2-RC6 regarding environment
 handling.
 Fixes Bug 164.
 Fixes Bug 165.
 Thanks to Stefan Pendl.
FIX: The change introduced to save the settings on each change inroduced some
 problems in case the settings (wpkg.xml) are created from scratch.
 In this case the settings were not saved at all until a change (package
 added to or package removed from) was done during WPKG operation.
   

Re: [wpkg-users] [Bug 173] Allow the use of environment variables for checking file revisions

[Pendl Stefan]

>
> Hi Stefan,
>
> Pendl Stefan wrote:
> > Hi Rainer,
> > sorry for misleading you by not adding an example
> to my request, I will do so the next time, I promise.
>
> No problem. I just did what I thought could be a good idea.
> Now you can even use
> a variable within the revision attribute of the package.
>
> I've updated wpkg.js once again to support your request
> (expansion of versions
> in file checks). In addition I did the same for uninstall
> version checks and
> fixed/changed some other small things.
>
> See here:
>
> Changes 2009-09-22, v1.1.2-RC19 by Rainer Meier  wpkg.org>
> FIX: Fixed duplicated version read from file if a file
> version check is used.
> NEW: Added environment value expansion for file version values.
> NEW: Added environment value expansion for uninstall version values.
> NEW: Added environment value expansion for execute check
> return values.
> MOD: Modified message if uninstall check string fails to be
> used as a regular
>  expression.
>
> Download here:
> A full test run has been made (tunning on Windows 7 Pro RTM) showing no 
> errors.
>
> Feedback appreciated of course :-)
>
> br,
> Rainer
>

Rainer,
I have just done some installations using a variable as the version 
string for the file version check.
There have been no problems.

Will see, if I can use the other extensions too.

---
Stefan
-
wpkg-users mailing list archives >> http://lists.wpkg.org/pipermail/wpkg-users/
___
wpkg-users mailing list
wpkg-users@lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/wpkg-users

Re: [wpkg-users] [Bug 173] Allow the use of environment variables for checking file revisions

[Rainer Meier]

Hi Stefan,

Pendl Stefan wrote:
> Hi Rainer,
> sorry for misleading you by not adding an example to my request, I 
> will do so the next time, I promise.

No problem. I just did what I thought could be a good idea. Now you can even use
a variable within the revision attribute of the package.

I've updated wpkg.js once again to support your request (expansion of versions
in file checks). In addition I did the same for uninstall version checks and
fixed/changed some other small things.

See here:

Changes 2009-09-22, v1.1.2-RC19 by Rainer Meier 
FIX: Fixed duplicated version read from file if a file version check is used.
NEW: Added environment value expansion for file version values.
NEW: Added environment value expansion for uninstall version values.
NEW: Added environment value expansion for execute check return values.
MOD: Modified message if uninstall check string fails to be used as a regular
 expression.

Download here:


A full test run has been made (tunning on Windows 7 Pro RTM) showing no errors.

Feedback appreciated of course :-)

br,
Rainer
-
wpkg-users mailing list archives >> http://lists.wpkg.org/pipermail/wpkg-users/
___
wpkg-users mailing list
wpkg-users@lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/wpkg-users

[wpkg-users] [Bug 173] Allow the use of environment variables for checking file revisions

[bugzilla-daemon]

http://bugzilla.wpkg.org/show_bug.cgi?id=173


Rainer Meier  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED




--- Comment #2 from Rainer Meier   2009-09-22 22:34:03 ---
Closing.

I did another update allowing some more variables to be used:

Changes 2009-09-22, v1.1.2-RC19 by Rainer Meier 
FIX: Fixed duplicated version read from file if a file version check is used.
NEW: Added environment value expansion for file version values.
NEW: Added environment value expansion for uninstall version values.
NEW: Added environment value expansion for execute check return values.
MOD: Modified message if uninstall check string fails to be used as a regular
 expression.

Download here:


A full test run has been made (tunning on Windows 7 Pro RTM) showing no errors.

br,
Rainer

-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
-
wpkg-users mailing list archives >> http://lists.wpkg.org/pipermail/wpkg-users/
___
wpkg-users mailing list
wpkg-users@lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/wpkg-users

Re: [wpkg-users] [Bug 173] Allow the use of environment variables for checking file revisions

[Pendl Stefan]

> Hi Stefan,
>
> Pendl Stefan wrote:
> > I have created a test case and there seems to be a problem
> with the variable expansion.
> >
> > Attached find the package and the log.
>
> I had a quick loock at the VirtuaWin package. You're using
> the variable
> JH_VIRWIN_VER within checks and not within the revision (as I
> understood you
> want to use it there).
> However to support package variables in checks I will have to
> do some more heavy
> changes. I hope it's possible without breaking too much in
> the current WPKG
> architecture.
>
> I will have a look this evening.
>
> br,
> Rainer
>

Hi Rainer,
sorry for misleading you by not adding an example to my request, I will 
do so the next time, I promise.

---
Stefan
-
wpkg-users mailing list archives >> http://lists.wpkg.org/pipermail/wpkg-users/
___
wpkg-users mailing list
wpkg-users@lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/wpkg-users

Re: [wpkg-users] [Bug 173] Allow the use of environment variables for checking file revisions

[Rainer Meier]

Hi Stefan,

Pendl Stefan wrote:
> I have created a test case and there seems to be a problem with the variable 
> expansion.
> 
> Attached find the package and the log.

I had a quick loock at the VirtuaWin package. You're using the variable
JH_VIRWIN_VER within checks and not within the revision (as I understood you
want to use it there).
However to support package variables in checks I will have to do some more heavy
changes. I hope it's possible without breaking too much in the current WPKG
architecture.

I will have a look this evening.

br,
Rainer
-
wpkg-users mailing list archives >> http://lists.wpkg.org/pipermail/wpkg-users/
___
wpkg-users mailing list
wpkg-users@lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/wpkg-users

Re: [wpkg-users] [Bug 173] Allow the use of environment variables for checking file revisions

[Pendl Stefan]

> Hi Stefan,
>
> Pendl Stefan wrote:
> > Hi Rainer,
> > as an example, see Notepad++, which includes the
> version number in the installer file name.
> > This leads to changing the version number in up to four
> places, depending on your package definition.
> >
> > I do not only check for the uninstall entry, but for the
> correct main executable version too.
> >
> > I do support x86 and AMD64 platforms, so I need to change
> this in four places, twice for the file check and once each
> for the install and upgrade command.
>
> Yes, I fully agree that your request is valid and improves
> WPKG, no doubt on
> this. That's why I've implemented it. Your example is
> absolutely correct too.
> However I still believe that not many users will use that
> feature in general so
> I intended to keep the "performance penalty" as low as
> possible and prevent
> unnecessary expansion if it's not needed.
>
> So thanks for the request. It would be nice to get some
> feedback about RC18 (I
> did not do a concrete test yet using a real-life package.
>
>
> br,
> Rainer
>

I will have some feedback tomorrow.

---
Stefan
-
wpkg-users mailing list archives >> http://lists.wpkg.org/pipermail/wpkg-users/
___
wpkg-users mailing list
wpkg-users@lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/wpkg-users

Re: [wpkg-users] [Bug 173] Allow the use of environment variables for checking file revisions

[Rainer Meier]

Hi Stefan,

Pendl Stefan wrote:
> Hi Rainer,
> as an example, see Notepad++, which includes the version number in 
> the installer file name.
> This leads to changing the version number in up to four places, depending on 
> your package definition.
> 
> I do not only check for the uninstall entry, but for the correct main 
> executable version too.
> 
> I do support x86 and AMD64 platforms, so I need to change this in four 
> places, twice for the file check and once each for the install and upgrade 
> command.

Yes, I fully agree that your request is valid and improves WPKG, no doubt on
this. That's why I've implemented it. Your example is absolutely correct too.
However I still believe that not many users will use that feature in general so
I intended to keep the "performance penalty" as low as possible and prevent
unnecessary expansion if it's not needed.

So thanks for the request. It would be nice to get some feedback about RC18 (I
did not do a concrete test yet using a real-life package.


br,
Rainer
-
wpkg-users mailing list archives >> http://lists.wpkg.org/pipermail/wpkg-users/
___
wpkg-users mailing list
wpkg-users@lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/wpkg-users

Re: [wpkg-users] [Bug 173] Allow the use of environment variables for checking file revisions

[Pendl Stefan]

> --- Comment #1 from Rainer Meier 
> 2009-09-21 19:34:55 ---
> Hi Stefan
>
> Sounds like a reasonable request. At the beginning I thought
> "yes, of course,
> let's quickly do it". Unfortunately it became a bit more
> complex. Especially
> this requires on every revision number query to set the full package
> environment and restore it after evaluating it.
> To prevent this for packages where it is not needed (I think
> using environment
> variables in revision strings will not become very popular)
> I've added a quick
> check and variables will be expanded only if at least two "%"
> characters are
> found.
>

Hi Rainer,
as an example, see Notepad++, which includes the version number in the 
installer file name.
This leads to changing the version number in up to four places, depending on 
your package definition.

I do not only check for the uninstall entry, but for the correct main 
executable version too.

I do support x86 and AMD64 platforms, so I need to change this in four places, 
twice for the file check and once each for the install and upgrade command.

So I can now use the following package definition:

>>


























<<

Thanks for the additional check, if expansion is needed,
Stefan
-
wpkg-users mailing list archives >> http://lists.wpkg.org/pipermail/wpkg-users/
___
wpkg-users mailing list
wpkg-users@lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/wpkg-users

[wpkg-users] [Bug 173] Allow the use of environment variables for checking file revisions

[bugzilla-daemon]

http://bugzilla.wpkg.org/show_bug.cgi?id=173


Rainer Meier  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||r.me...@wpkg.org
 Resolution||FIXED




--- Comment #1 from Rainer Meier   2009-09-21 19:34:55 ---
Hi Stefan

Sounds like a reasonable request. At the beginning I thought "yes, of course,
let's quickly do it". Unfortunately it became a bit more complex. Especially
this requires on every revision number query to set the full package
environment and restore it after evaluating it.
To prevent this for packages where it is not needed (I think using environment
variables in revision strings will not become very popular) I've added a quick
check and variables will be expanded only if at least two "%" characters are
found.

Here is the change log:

Changes 2009-09-21, v1.1.2-RC18 by Rainer Meier 
MOD: Added check for package revision environment expansion. Expansion is only
 done if the revision string contains two "%" characters which indicates
 an environment definition in the form of %VAR%.
 This should prevent unneeded environment setups and therefore it prevents
 wasting resources.

Changes 2009-09-21, v1.1.2-RC17 by Rainer Meier 
NEW: Expands environment variables in package revision. For example
 revision="%PRG_VERSION%" is valid now. Make sure the environment variable
 is defined before you use it.
 Fixes Bug 173. Thanks to Stefan Pendl.


Any feedback appreciated.




br,
Rainer

-- 
Configure bugmail: http://bugzilla.wpkg.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
-
wpkg-users mailing list archives >> http://lists.wpkg.org/pipermail/wpkg-users/
___
wpkg-users mailing list
wpkg-users@lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/wpkg-users