[wsjt-devel] PSE Fixed patch for CMakeFiles/qmap_impl.dir/q65c.f90.o
Hi, Tried also to build WSJTX from git repository and faced same error I faced by using the tgz archive. In my distro OpenSUSE Tumbleweed applying the standard WSJT-X single patch "wsjtx.patch" do not works and I need to apply it to all the files involved in the error. I supposed that at least in the git this issue were resolved. In my opinion (maybe I'm wrong) it looks that the major code attention being reserved to Windows more than on Linux O.S. with this software. In any case the behavior between OpenSUSE, Fedora, Ubuntu is certainly different on some aspects and for this specific issue of apply the patch it looks to really be different. [ 94%] Automatic MOC for target qmap_impl [ 94%] Built target qmap_impl_autogen [ 94%] Building Fortran object qmap/libqmap/CMakeFiles/qmap_impl.dir/q65c.f90.o /home/marco/WSJT-X_build/git/src/qmap/libqmap/q65c.f90:23:39: 23 | ndepth,ndiskdat,neme,newdat,nfa,nfb,nfcal,nfshift, & | 1 Error: Symbol ‘nfa’ at (1) is USE associated from module ‘q65’ and cannot occur in COMMON gmake[2]: *** [qmap/libqmap/CMakeFiles/qmap_impl.dir/build.make:336: qmap/libqmap/CMakeFiles/qmap_impl.dir/q65c.f90.o] Error 1 gmake[1]: *** [CMakeFiles/Makefile2:2109: qmap/libqmap/CMakeFiles/qmap_impl.dir/all] Error 2 gmake: *** [Makefile:156: all] Error 2 --- *73 de Marco, PY1ZRJ (former IK5BCU)* **___ wsjt-devel mailing list wsjt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wsjt-devel
Re: [wsjt-devel] PSE Fixed patch for CMakeFiles/qmap_impl.dir/q65c.f90.o
I get the same error on Mac OSX Mojave Have manually edit qmap/libqmap/q65c.f90 and remove: nfa nfb max_drift references to get it to compile Using gfortran-mp-11 which is the macports version of gcc11 same error on gcc12 gfortran > On Jun 12, 2023, at 12:59 PM, Marco Calistri via wsjt-devel > wrote: > > Hi, > > Tried also to build WSJTX from git repository and faced same error I faced by > using the tgz archive. > > In my distro OpenSUSE Tumbleweed applying the standard WSJT-X single patch > "wsjtx.patch" do not works and I need to apply it to all the files involved > in the error. > > I supposed that at least in the git this issue were resolved. > > In my opinion (maybe I'm wrong) it looks that the major code attention being > reserved to Windows more than on Linux O.S. with this software. > > In any case the behavior between OpenSUSE, Fedora, Ubuntu is certainly > different on some aspects and for this specific issue of apply the patch it > looks to really be different. > > [ 94%] Automatic MOC for target qmap_impl > [ 94%] Built target qmap_impl_autogen > [ 94%] Building Fortran object > qmap/libqmap/CMakeFiles/qmap_impl.dir/q65c.f90.o > /home/marco/WSJT-X_build/git/src/qmap/libqmap/q65c.f90:23:39: > > 23 |ndepth,ndiskdat,neme,newdat,nfa,nfb,nfcal,nfshift, >& > | 1 > Error: Symbol ‘nfa’ at (1) is USE associated from module ‘q65’ and cannot > occur in COMMON > gmake[2]: *** [qmap/libqmap/CMakeFiles/qmap_impl.dir/build.make:336: > qmap/libqmap/CMakeFiles/qmap_impl.dir/q65c.f90.o] Error 1 > gmake[1]: *** [CMakeFiles/Makefile2:2109: > qmap/libqmap/CMakeFiles/qmap_impl.dir/all] Error 2 > gmake: *** [Makefile:156: all] Error 2 > --- > 73 de Marco, PY1ZRJ (former IK5BCU) > > ___ > wsjt-devel mailing list > wsjt-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wsjt-devel signature.asc Description: Message signed with OpenPGP ___ wsjt-devel mailing list wsjt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wsjt-devel
Re: [wsjt-devel] PSE Fixed patch for CMakeFiles/qmap_impl.dir/q65c.f90.o
SuSE happens to be one of my areas of interest. Building on both SuSE Linux Enterprise and Leap. Let me spin up a Tumbleweed in the VM and see what's going on. Are you using SuSE MicroOS in your configuration? Just to be sure, are you following the procedure as outlined in the Install file? I have a simplified version of the build instructions on my web site. This will be the procedure that I use when I test the build on Tumbleweed. http://kb6ibb-15.ham-radio-op.net/Ham-Radio/HamRadioBuild/HowToBuild-WSJT-X.txt PS - Windows is not getting more attention than Linux. It's just that Tumbleweed being a forward rolling release is so far ahead of the Enterprise standard, that errors and glitches are expected. Because that is what a rolling release is. A test bed and it's well documented as such. OpenSuSE Leap 15.5 is rock solid built on the Enterprise source and production ready. On 6/12/23 14:59, Marco Calistri via wsjt-devel wrote: Hi, Tried also to build WSJTX from git repository and faced same error I faced by using the tgz archive. In my distro OpenSUSE Tumbleweed applying the standard WSJT-X single patch "wsjtx.patch" do not works and I need to apply it to all the files involved in the error. I supposed that at least in the git this issue were resolved. In my opinion (maybe I'm wrong) it looks that the major code attention being reserved to Windows more than on Linux O.S. with this software. In any case the behavior between OpenSUSE, Fedora, Ubuntu is certainly different on some aspects and for this specific issue of apply the patch it looks to really be different. [ 94%] Automatic MOC for target qmap_impl [ 94%] Built target qmap_impl_autogen [ 94%] Building Fortran object qmap/libqmap/CMakeFiles/qmap_impl.dir/q65c.f90.o /home/marco/WSJT-X_build/git/src/qmap/libqmap/q65c.f90:23:39: 23 | ndepth,ndiskdat,neme,newdat,nfa,nfb,nfcal,nfshift, & | 1 Error: Symbol ‘nfa’ at (1) is USE associated from module ‘q65’ and cannot occur in COMMON gmake[2]: *** [qmap/libqmap/CMakeFiles/qmap_impl.dir/build.make:336: qmap/libqmap/CMakeFiles/qmap_impl.dir/q65c.f90.o] Error 1 gmake[1]: *** [CMakeFiles/Makefile2:2109: qmap/libqmap/CMakeFiles/qmap_impl.dir/all] Error 2 gmake: *** [Makefile:156: all] Error 2 --- *73 de Marco, PY1ZRJ (former IK5BCU)* ** ___ wsjt-devel mailing list wsjt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wsjt-devel -- Jeff Stillinger - KB6IBB KB6IBB Laboratories, Wylie Tx http://kb6ibb-15.ham-radio-op.net/ ___ wsjt-devel mailing list wsjt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wsjt-devel
Re: [wsjt-devel] PSE Fixed patch for CMakeFiles/qmap_impl.dir/q65c.f90.o
I understood Manfred,
And it can be reproduced as well on Linux I suppose, but I think is
better to have the solution already into WSJTX code, because it could be
used by every users, also by who has not practice with the code.
Regards,
---
*73 de Marco, PY1ZRJ (former IK5BCU)*
**Il 12/06/23 18:18, Manfred Antar {KN6KBS} via wsjt-devel ha scritto:
I get the same error on Mac OSX Mojave
Have manually edit qmap/libqmap/q65c.f90 and remove:
nfa
nfb
max_drift
references to get it to compile
Using gfortran-mp-11 which is the macports version of gcc11 same error on gcc12
gfortran
On Jun 12, 2023, at 12:59 PM, Marco Calistri via
wsjt-devel wrote:
Hi,
Tried also to build WSJTX from git repository and faced same error I faced by
using the tgz archive.
In my distro OpenSUSE Tumbleweed applying the standard WSJT-X single patch
"wsjtx.patch" do not works and I need to apply it to all the files involved in
the error.
I supposed that at least in the git this issue were resolved.
In my opinion (maybe I'm wrong) it looks that the major code attention being
reserved to Windows more than on Linux O.S. with this software.
In any case the behavior between OpenSUSE, Fedora, Ubuntu is certainly
different on some aspects and for this specific issue of apply the patch it
looks to really be different.
[ 94%] Automatic MOC for target qmap_impl
[ 94%] Built target qmap_impl_autogen
[ 94%] Building Fortran object qmap/libqmap/CMakeFiles/qmap_impl.dir/q65c.f90.o
/home/marco/WSJT-X_build/git/src/qmap/libqmap/q65c.f90:23:39:
23 |ndepth,ndiskdat,neme,newdat,nfa,nfb,nfcal,nfshift,
&
| 1
Error: Symbol ‘nfa’ at (1) is USE associated from module ‘q65’ and cannot occur
in COMMON
gmake[2]: *** [qmap/libqmap/CMakeFiles/qmap_impl.dir/build.make:336:
qmap/libqmap/CMakeFiles/qmap_impl.dir/q65c.f90.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:2109:
qmap/libqmap/CMakeFiles/qmap_impl.dir/all] Error 2
gmake: *** [Makefile:156: all] Error 2
---
73 de Marco, PY1ZRJ (former IK5BCU)
___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
Re: [wsjt-devel] PSE Fixed patch for CMakeFiles/qmap_impl.dir/q65c.f90.o
Test Result and Solution to follow... Downloaded SuSE Tumbleweed from SuSE Web Site Standard (out of box options) Gnome Install kb6ibb@KB6IBB-TW-Test:~> cat /etc/os-release NAME="openSUSE Tumbleweed" # VERSION="20230610" ID="opensuse-tumbleweed" ID_LIKE="opensuse suse" VERSION_ID="20230610" PRETTY_NAME="openSUSE Tumbleweed" ANSI_COLOR="0;32" CPE_NAME="cpe:/o:opensuse:tumbleweed:20230610" BUG_REPORT_URL="https://bugzilla.opensuse.org"; SUPPORT_URL="https://bugs.opensuse.org"; HOME_URL="https://www.opensuse.org"; DOCUMENTATION_URL="https://en.opensuse.org/Portal:Tumbleweed"; LOGO="distributor-logo-Tumbleweed" Fastest way to configure a WSJT-X build environment on SuSE Linux is to install DL8FCL's source rpm. Download from the SuSE Factory. https://software.opensuse.org/download/package?package=wsjtx&project=home%3Adl8fcl%3Aafu kb6ibb@KB6IBB-TW-Test:~> zypper si ./wsjtx-2.6.1-2.18.src.rpm Once the build environment is set, instruct zypper to upgrade the world. kb6ibb@KB6IBB-TW-Test:~> sudo zypper dup Loading repository data... Reading installed packages... Warning: You are about to do a distribution upgrade with all enabled repositories. Make sure these repositories are compatible before you continue. See 'man zypper' for more information about this command. Computing distribution upgrade... Nothing to do. Awesome, we are running the latest and greatest Tumbleweed. Download the WSJT-X Source from Sourceforge. We will be building WSJT-X 2.7.0-RC1 https://sourceforge.net/projects/wsjt/files/wsjtx-2.7.0-rc1/wsjtx-2.7.0-rc1.tgz/download Follow build instructions from KB6IBB. For this test we will build WITH documentation. http://kb6ibb-15.ham-radio-op.net/Ham-Radio/HamRadioBuild/HowToBuild-WSJT-X.txt Step one: kb6ibb@KB6IBB-TW-Test:~/Downloads/wsjtx-2.7.0-rc1/wsjtx-2.7.0/build> cmake -DWSJT_SKIP_MANPAGES=OFF -DWSJT_GENERATE_DOCS=ON .. -- The C compiler identification is GNU 13.1.1 -- The CXX compiler identification is GNU 13.1.1 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Found Git: /usr/bin/git (found version "2.41.0") -- Configuring done (0.4s) -- Generating done (0.0s) -- Build files have been written to: /home/kb6ibb/Downloads/wsjtx-2.7.0-rc1/wsjtx-2.7.0/build Step two: kb6ibb@KB6IBB-TW-Test:~/Downloads/wsjtx-2.7.0-rc1/wsjtx-2.7.0/build> cmake --build . And the build falls over here... [ 96%] Building Fortran object qmap/libqmap/CMakeFiles/qmap_impl.dir/q65c.f90.o /home/kb6ibb/Downloads/wsjtx-2.7.0-rc1/wsjtx-2.7.0/build/wsjtx-prefix/src/wsjtx/qmap/libqmap/q65c.f90:23:39: 23 | ndepth,ndiskdat,neme,newdat,nfa,nfb,nfcal,nfshift, & | 1 Error: Symbol ‘nfa’ at (1) is USE associated from module ‘q65’ and cannot occur in COMMON gmake[5]: *** [qmap/libqmap/CMakeFiles/qmap_impl.dir/build.make:336: qmap/libqmap/CMakeFiles/qmap_impl.dir/q65c.f90.o] Error 1 gmake[4]: *** [CMakeFiles/Makefile2:2129: qmap/libqmap/CMakeFiles/qmap_impl.dir/all] Error 2 gmake[3]: *** [Makefile:156: all] Error 2 gmake[2]: *** [CMakeFiles/wsjtx-build.dir/build.make:73: wsjtx-prefix/src/wsjtx-stamp/wsjtx-build] Error 2 gmake[1]: *** [CMakeFiles/Makefile2:279: CMakeFiles/wsjtx-build.dir/all] Error 2 gmake: *** [Makefile:91: all] Error 2 --- *** Let's take a quick look at OpenSuSE Leap 15.5, where the build runs perfectly... kb6ibb@kb6ibb-15:~/src/wsjtx-2.7.0-rc1/wsjtx-2.7.0/build> cat /etc/os-release NAME="openSUSE Leap" VERSION="15.5" ID="opensuse-leap" ID_LIKE="suse opensuse" VERSION_ID="15.5" PRETTY_NAME="openSUSE Leap 15.5" ANSI_COLOR="0;32" CPE_NAME="cpe:/o:opensuse:leap:15.5" BUG_REPORT_URL="https://bugs.opensuse.org"; HOME_URL="https://www.opensuse.org/"; DOCUMENTATION_URL="https://en.opensuse.org/Portal:Leap"; LOGO="distributor-logo-Leap" Step one: kb6ibb@kb6ibb-15:~/src/wsjtx-2.7.0-rc1/wsjtx-2.7.0/build> cmake -DWSJT_SKIP_MANPAGES=OFF -DWSJT_GENERATE_DOCS=ON .. -- The C compiler identification is GNU 7.5.0 -- The CXX compiler identification is GNU 7.5.0 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Fou
Re: [wsjt-devel] PSE Fixed patch for CMakeFiles/qmap_impl.dir/q65c.f90.o
Marco, As far as I'm aware your problem involves only an attempt to build program QMAP. Almost certainly you have no current use for QMAP, and no real interest in building it for Linux. I suggest the simple expedient of moving the statement "endif ()", line 1435 of the top-level CMakeFiles.txt down by two lines so that it comes after the statement "add_subdirectory (qmap)". Then you will not run into the fussy compiler warnings that are currently bothering you. -- 73, Joe, K1JT ___ wsjt-devel mailing list wsjt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wsjt-devel
Re: [wsjt-devel] PSE Fixed patch for CMakeFiles/qmap_impl.dir/q65c.f90.o
Il 13/06/23 12:19, Joe Taylor via wsjt-devel ha scritto: Marco, As far as I'm aware your problem involves only an attempt to build program QMAP. Almost certainly you have no current use for QMAP, and no real interest in building it for Linux. I suggest the simple expedient of moving the statement "endif ()", line 1435 of the top-level CMakeFiles.txt down by two lines so that it comes after the statement "add_subdirectory (qmap)". Then you will not run into the fussy compiler warnings that are currently bothering you. -- 73, Joe, K1JT ___ wsjt-devel mailing list wsjt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wsjt-devel Hello Joe, you are right, I don't use QMAP at all! Many thanks for this easy workaround, I will follow your directions in case I need to recompile the WSJTX source! Best regards, --- *73 de Marco, PY1ZRJ (former IK5BCU)* **___ wsjt-devel mailing list wsjt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wsjt-devel
Re: [wsjt-devel] PSE Fixed patch for CMakeFiles/qmap_impl.dir/q65c.f90.o
I just verified that wsjtx will build without errors with OSX macports gcc10 (gfortran-mp-10) The error occurs with gcc11 and gcc12 fortran compilers > On Jun 13, 2023, at 11:22 AM, Marco Calistri via wsjt-devel > wrote: > > Il 13/06/23 12:19, Joe Taylor via wsjt-devel ha scritto: >> Marco, >> >> As far as I'm aware your problem involves only an attempt to build program >> QMAP. Almost certainly you have no current use for QMAP, and no real >> interest in building it for Linux. >> >> I suggest the simple expedient of moving the statement "endif ()", line 1435 >> of the top-level CMakeFiles.txt down by two lines so that it comes after the >> statement "add_subdirectory (qmap)". Then you will not run into the >> fussy compiler warnings that are currently bothering you. >> >> -- 73, Joe, K1JT >> >> >> ___ >> wsjt-devel mailing list >> wsjt-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/wsjt-devel > > > Hello Joe, you are right, I don't use QMAP at all! > > Many thanks for this easy workaround, I will follow your directions in case I > need to recompile the WSJTX source! > > Best regards, > --- > 73 de Marco, PY1ZRJ (former IK5BCU) > <630404BYw2B5Wom7.jpeg> > ___ > wsjt-devel mailing list > wsjt-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wsjt-devel signature.asc Description: Message signed with OpenPGP ___ wsjt-devel mailing list wsjt-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wsjt-devel
Re: [wsjt-devel] PSE Fixed patch for CMakeFiles/qmap_impl.dir/q65c.f90.o
On Tue, 13 Jun 2023 11:19:59 -0400
Joe Taylor via wsjt-devel wrote:
> Marco,
>
> As far as I'm aware your problem involves only an attempt to build
> program QMAP. Almost certainly you have no current use for QMAP, and
> no real interest in building it for Linux.
>
> I suggest the simple expedient of moving the statement "endif ()",
> line 1435 of the top-level CMakeFiles.txt down by two lines so that
> it comes after the statement "add_subdirectory (qmap)". Then you
> will not run into the fussy compiler warnings that are currently
> bothering you.
K7FU produced a patch for this when 2.7.0rc1 was released.
I am pasting it here:
-
diff -Naur wsjtx.orig/qmap/astro.cpp wsjtx/qmap/astro.cpp
--- wsjtx.orig/qmap/astro.cpp 2023-05-12 13:55:48
+++ wsjtx/qmap/astro.cpp2023-05-12 13:57:23
@@ -72,7 +72,7 @@
datcom_.ndop00=ndop00; //Send self Doppler to decoder, via
datcom
// qDebug() << "aa" << isec << datcom_.fcenter << nfreq << ndop00;
- sprintf(cc,
+ snprintf(cc, sizeof(cc),
"Az:%6.1f\n"
"El:%6.1f\n"
"MyDop: %6d\n"
@@ -140,7 +140,7 @@
if(f.open(QIODevice::WriteOnly | QIODevice::Append)) {
QTextStream out(&f);
out << t.toString("-MMM-dd hh:mm:ss");
-sprintf(cc,"%7.1f %7.1f %d %7.1f %7.1f %10.1f %7.2f\n",
+snprintf(cc,sizeof(cc),"%7.1f %7.1f %d %7.1f %7.1f %10.1f %7.2f\n",
azsun,elsun,iCycle,azOffset,elOffset,xavg,10.0*log10(xavg));
out << cc;
f.close();
@@ -168,7 +168,7 @@
if(ntxFreq != ntxFreq0) ndiff=1;
ntxFreq0=ntxFreq;
QTextStream out(&f);
- sprintf(cc,"%2.2d:%2.2d:%2.2d,%5.1f,%5.1f,Moon\n"
+ snprintf(cc,sizeof(cc),"%2.2d:%2.2d:%2.2d,%5.1f,%5.1f,Moon\n"
"%2.2d:%2.2d:%2.2d,%5.1f,%5.1f,Sun\n"
"%2.2d:%2.2d:%2.2d,%5.1f,%5.1f,Source\n"
"%4d,%6d,%6d,Doppler\n"
diff -Naur wsjtx.orig/qmap/libqmap/q65c.f90 wsjtx/qmap/libqmap/q65c.f90
--- wsjtx.orig/qmap/libqmap/q65c.f902023-05-12 13:55:48
+++ wsjtx/qmap/libqmap/q65c.f90 2023-05-12 13:56:41
@@ -20,9 +20,9 @@
!### REMEMBER that /npar/ is not updated until nparams=nparams0 is executed.
###
common/npar/fcenter,nutc,fselected,mousedf,mousefqso,nagain,&
- ndepth,ndiskdat,neme,newdat,nfa,nfb,nfcal,nfshift, &
+ ndepth,ndiskdat,neme,newdat,nfcal,nfshift, &
mcall3,nkeep,ntol,nxant,nrxlog,nfsample,nxpol,nmode, &
- ndop00,nsave,max_drift,nhsym,mycall,mygrid,hiscall,hisgrid,&
+ ndop00,nsave,nhsym,mycall,mygrid,hiscall,hisgrid,&
datetime,junk1,junk2
equivalence (nparams,fcenter)
data first/.true./
diff -Naur wsjtx.orig/qmap/soundin.cpp wsjtx/qmap/soundin.cpp
--- wsjtx.orig/qmap/soundin.cpp 2023-05-12 13:55:48
+++ wsjtx/qmap/soundin.cpp 2023-05-12 13:57:57
@@ -173,7 +173,7 @@
int ntr;
int nhsym0=0;
int iz=174;
- int nBusy=0;
+// int nBusy=0;
// Main loop for input of UDP packets over the network:
while (!qe) {
@@ -217,7 +217,7 @@
m_hsym=(k-2048)*11025.0/(2048.0*m_rate);
if(m_hsym != nhsym0) {
if(m_dataSinkBusy) {
-nBusy++;
+ // nBusy++;
} else {
m_dataSinkBusy=true;
emit readyForFFT(k); //Signal to compute new FFTs
-
Glad to see that you seem to have recovered Joe.
--
Brian G8SEZ
___
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
