Re: [wtp-dev] JSDT inference: type of "this"

2008-04-28 Thread Matthias Kempka


On Apr 8, 2008, at 4:56 PM, Phil Berkland wrote:


The default InferenceEngine will create an anonymous type when is  
sees a Object Literal.
Assuming that you have override handleFunctionCall() in you  
inferengine to process the "qx.Class.define", in that code
you would "drill down" to that object initializer and call  
"traverse()" in its field initializers, thus bypassing the default  
handling of visit(IObjectInitializer).
The handleFunctionCall() should return false, so the InferEngine  
does not visit the children of the function call .


I've tried this now. Unsuccessful, so far.

I made certain that visit(IObjectLiteral) in my inferencer is not  
called. While debugging, I even throw Exceptions in the overridden  
method, to be sure that the call doesn't pass there unnoticed. But  
still the original problem exists: The inner object literal has an own  
anonymous type.


I went into debugging to see where it is created:
The anonymous InferredType object that is passed to my  
QooxdooInferEngine is not created by the QooxdooInferEngine. It is  
created by another instance of InferEngine (itself, no subclass). So I  
never get the chance to do something regarding the type creation for  
ObjectLiterals.


However, it seemed awkward to me why I should reimplement the  
ASTVisitor aspect of the InferEngine anyway. Having an anonymous type  
as a placeholder during the type gathering is ok for me, and not  
uncommon from what I know about type inferencing in other languages. I  
just want to be able to tell it that it is the same type as "that one".
I didn't find anything in InferredType that suggests this  
functionality. So I set the superclass of the anonymous type to the  
known class. This works now for the functionality I intended right  
now, but is not formally correct and will come back and bite me as  
soon as I introduce visibility validation.


Do you think it would be reasonable to introduce a field in  
InferredType that allows me to say what it actually is? It would be  
close to the referenceClass, only not for array members but for "this"  
type.


Best Regards,
Matthias Kempka




--
Dipl.-Inform. Matthias Kempka
Innoopract Informationssysteme GmbH
[EMAIL PROTECTED]
Tel:  0721 - 66 47 33 - 0
Fax: 0721 - 66 47 33 29
= Legal Disclaimer =
According to Section 80 of the German Corporation Act
Innoopract Informationssysteme GmbH must indicate the following  
information:

Address: Stephanienstrasse 20, 76133 Karlsruhe Germany
General Manager: Jochen Krause, Eric von der Heyden
Registered Office: Karlsruhe, Commercial Register Karlsruhe HRB 7883






___
wtp-dev mailing list
wtp-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/wtp-dev


[wtp-dev] Commit rights for Lawrence Mandel have been expired

2008-04-28 Thread portal on behalf of emo
webtools.sourceediting Committers,
Nitin Dahyabhai has expired the commit rights for Lawrence Mandel
(lmandel).  The reason for this change is:

Lawrence has tendered his resignation.  His work within this project and
with the community will be missed.

To honor Lawrence Mandel's contributions to the project, Nitin Dahyabhai
has nominated Lawrence Mandel for Committer Emeritus status.

___
wtp-dev mailing list
wtp-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/wtp-dev


[wtp-dev] Commit rights for Craig Salter have been expired

2008-04-28 Thread portal on behalf of emo
webtools.sourceediting Committers,
Nitin Dahyabhai has expired the commit rights for Craig Salter (csalter). 
The reason for this change is:

Craig's duties have moved him away from WTP, and with no commits since
mid-Auguest, it is time to remove him as a committer.


___
wtp-dev mailing list
wtp-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/wtp-dev


Re: [wtp-dev] Ganymede migration docs for WTP ?

2008-04-28 Thread Max Rydahl Andersen
Hi,

FYI I recorded all the issues I bumped into while migrating.

That resulted in the following jira for it 
http://jira.jboss.com/jira/browse/JBIDE-2130 which 
includes both public and internal API chanages.

I added the public eclipse platform issues here:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=229151

and the 1.5 issue i found in WTP at:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=229137

-max


>> Max,
>> Which areas do you think are missing information?  As the page says, "
>> Adopters: if you run into trouble or notice things that are not covered
>> here, please let us know ([EMAIL PROTECTED] is a good place)."
>>
>> So, please, tell us.
>
> I'll let you know.
>
> But I can inform you that last time I tried adjusting for Ganymede (around M4 
> I think)
> I had a tons (thousands) of compile/build errors.
>
> Now it's down to 91 (yay! :)... probably most likely caused by internal api 
> usage which we
> unfortunatly have been required to use for one reason or another.
>
> I'm collecting notes for my migration and will let you know.
>
> /max
> ___
> wtp-dev mailing list
> wtp-dev@eclipse.org
> https://dev.eclipse.org/mailman/listinfo/wtp-dev
> 



___
wtp-dev mailing list
wtp-dev@eclipse.org
https://dev.eclipse.org/mailman/listinfo/wtp-dev