Re: [wtp-dev] Declaring Build for wtp-R3.9.3-M: S-3.9.3RC4-20180302093744

2018-03-07 Thread Jesper Steen Møller

> On 7 Mar 2018, at 20.37, Jesper Steen Møller  wrote:
> 
> 
>> On 7 Mar 2018, at 17.40, Nick Boldt  wrote:
>> [...]
>> Has anyone started work on JDK 10 support in WTP? Just curious in which 
>> projects I should expect to see changes.
>> 
> 
> I really doubt there's anything to do for WTP for JDK 10, unless there is a 
> classfile version check somewhere in there? The only language issue is the 
> 'var' reserved word. I guess we could stop people using the new servlet 
> wizard from using 'var' as a type name, but that's about it.
> 

 Sorry - that was nonsense, as per Carl's analysis...

What I should have written is that there's only a smaller AST change, addition 
of a (read-only) property: org.eclipse.jdt.core.dom.SimpleType.isVar()

From what little I know about JEM, it should not be affected by the JDK 10 
change.

-Jesper

___
wtp-dev mailing list
wtp-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev

Re: [wtp-dev] Declaring Build for wtp-R3.9.3-M: S-3.9.3RC4-20180302093744

2018-03-07 Thread Jesper Steen Møller

> On 7 Mar 2018, at 17.40, Nick Boldt  wrote:
> [...]
> Has anyone started work on JDK 10 support in WTP? Just curious in which 
> projects I should expect to see changes.
> 

I really doubt there's anything to do for WTP for JDK 10, unless there is a 
classfile version check somewhere in there? The only language issue is the 
'var' reserved word. I guess we could stop people using the new servlet wizard 
from using 'var' as a type name, but that's about it.

-Jesper
___
wtp-dev mailing list
wtp-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev


Re: [wtp-dev] Declaring Build for wtp-R3.9.3-M: S-3.9.3RC4-20180302093744 - Java 10

2018-03-07 Thread Carl Anderson
Nick,
 
 There are two areas of WTP impacted by a new version of Java:  org.eclipse.jst.common.project.facet.core (where the Java facet is defined) and (possibly) JEM.
  Any common committer can figure out what needs to be done for org.eclipse.jst.common.project.facet.core - see https://bugs.eclipse.org/bugs/show_bug.cgi?id=522750 .  However, to my knowledge, I am the only one left with any JEM experience... let's just hope that there are no breaking changes there.
 
FWIW,
 
- Carl Anderson
 
- Original message -From: Nick Boldt Sent by: wtp-dev-boun...@eclipse.orgTo: "General discussion of project-wide or architectural issues." Cc:Subject: Re: [wtp-dev] Declaring Build for wtp-R3.9.3-M: S-3.9.3RC4-20180302093744Date: Wed, Mar 7, 2018 11:41 AM 
As this will be the last build for Oxygen.3 barring blockers, I've disabled the 3.9.x job for now [1] to prevent unneeded respins.
 
[1] https://hudson.eclipse.org/webtools/view/webtools_R3_9/job/WTP-R3_9_x_Maintenance/
 
Note that there are at least 3 changes queued for Oxygen.3a:
 
* updates from jsf (because we pull from master, not R3_9)
* updates from dali (because we pull from master, not R3_9)
* fix for webtools.common - https://git.eclipse.org/r/#/c/118906/ 
 
Has anyone started work on JDK 10 support in WTP? Just curious in which projects I should expect to see changes.
 
Cheers,
 
Nick
 
On Tue, Mar 6, 2018 at 6:10 PM, WTP Releng  wrote:

Download Page:http://download.eclipse.org/webtools/downloads/drops/R3.9.3/S-3.9.3RC4-20180302093744General Smoketest results page:http://wiki.eclipse.org/WTP_Smoke_Test_Results___wtp-dev mailing listwtp-dev@eclipse.orgTo change your delivery options, retrieve your password, or unsubscribe from this list, visithttps://dev.eclipse.org/mailman/listinfo/wtp-dev 

 --

Nick Boldt
Senior Software Engineer, RHCSA
Productization Lead :: JBoss Tools & Dev Studio
IM: @nickboldt / @nboldt / http://nick.divbyzero.com
TRIED. TESTED. TRUSTED.
@ @redhatnews      Red Hat
 
 
“The Only Thing That Is Constant Is Change” - Heraclitus
___wtp-dev mailing listwtp-dev@eclipse.orgTo change your delivery options, retrieve your password, or unsubscribe from this list, visithttps://urldefense.proofpoint.com/v2/url?u=https-3A__dev.eclipse.org_mailman_listinfo_wtp-2Ddev=DwICAg=jf_iaSHvJObTbx-siA1ZOg=6JCYBixIS0G6Rj43h5xZSA=fgPfxLtn0DUW-NTlOdmXyAbae6dExbjLIu9AZlrrX6U=FS4gVaX3wSDdRjKosnML9xGxhZ6vzEpQs68lUpMIOis=
 

___
wtp-dev mailing list
wtp-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev

Re: [wtp-dev] Declaring Build for wtp-R3.9.3-M: S-3.9.3RC4-20180302093744

2018-03-07 Thread Nick Boldt
As this will be the last build for Oxygen.3 barring blockers, I've disabled
the 3.9.x job for now [1] to prevent unneeded respins.

[1]
https://hudson.eclipse.org/webtools/view/webtools_R3_9/job/WTP-R3_9_x_Maintenance/

Note that there are at least 3 changes queued for Oxygen.3a:

* updates from jsf (because we pull from master, not R3_9)
* updates from dali (because we pull from master, not R3_9)
* fix for webtools.common - https://git.eclipse.org/r/#/c/118906/

Has anyone started work on JDK 10 support in WTP? Just curious in which
projects I should expect to see changes.

Cheers,

Nick

On Tue, Mar 6, 2018 at 6:10 PM, WTP Releng  wrote:

>
>
> Download Page:
> http://download.eclipse.org/webtools/downloads/drops/R3.9.
> 3/S-3.9.3RC4-20180302093744
>
> General Smoketest results page:
> http://wiki.eclipse.org/WTP_Smoke_Test_Results
>
> ___
> wtp-dev mailing list
> wtp-dev@eclipse.org
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>



-- 

Nick Boldt

Senior Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com

TRIED. TESTED. TRUSTED. 
@ @redhatnews   Red Hat




“The Only Thing That Is Constant Is Change” - Heraclitus
___
wtp-dev mailing list
wtp-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev

[wtp-dev] Declaring Build for wtp-R3.9.3-M: S-3.9.3RC4-20180302093744

2018-03-06 Thread WTP Releng
 

Download Page: 
http://download.eclipse.org/webtools/downloads/drops/R3.9.3/S-3.9.3RC4-20180302093744

General Smoketest results page:
http://wiki.eclipse.org/WTP_Smoke_Test_Results

___
wtp-dev mailing list
wtp-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev