Re: [wtp-dev] Question on plugin versioning for a given patch

2017-11-29 Thread Nick Boldt 
For those keeping score at home, here's the BZ tracking this work item:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=527533

On Mon, Nov 20, 2017 at 8:26 PM, Nick Boldt  wrote:

> I would make sure that all the affected/changed features are upversioned
> in compliance with whatever version-bump-checker tools are used in WTP.
>
> I'm not sure what's currently used, but I'm happy to implement use of the
> stuff we have in JBoss Tools [1] for WTP so it too can benefit from some of
> the new features in Tycho.
>
> [1] https://github.com/jbosstools/jbosstools-build/
> blob/master/parent/pom.xml#L24-L27 and https://github.com/jbosstools/
> jbosstools-build/blob/master/parent/pom.xml#L449-L467 and
> https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#
> L701-L722
>
> That said... we need to get everyone using Tycho 1.0 for that to work.
> We've still got a ways to go before that's possible.
>
> On Mon, Nov 20, 2017 at 7:32 PM, Robert Stryker 
> wrote:
>
>> Hey all:
>>
>> https://git.eclipse.org/r/#/c/111933/
>>
>> I merged this patch from Nick Boldt. It primarily changes how we're
>> storing things like sourceTemplateBundle folders in features and plugins.
>> This is because tycho will automatically generate these files for us, and
>> so they don't really belong in the repository.
>>
>> Do any version changes to the plugins and features need to be made for a
>> change like this?
>>
>> I also merged https://git.eclipse.org/r/#/c/110087/   and
>> https://git.eclipse.org/r/#/c/110858/   which modify the root pom.xml
>> and the .gitignore files.
>>
>> Any help or advice here would be appreciated. Looking to avoid any issues
>> like last time.
>>
>> - Rob Stryker
>>
>> ___
>> wtp-dev mailing list
>> wtp-dev@eclipse.org
>> To change your delivery options, retrieve your password, or unsubscribe
>> from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>>
>
>
>
> --
>
> Nick Boldt
>
> Senior Software Engineer, RHCSA
>
> Productization Lead :: JBoss Tools & Dev Studio
>
> IM: @nickboldt / @nboldt / http://nick.divbyzero.com
> 
> TRIED. TESTED. TRUSTED. 
> @ @redhatnews   Red Hat
> 
>



-- 

Nick Boldt

Senior Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com

TRIED. TESTED. TRUSTED. 
@ @redhatnews   Red Hat

___
wtp-dev mailing list
wtp-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev

Re: [wtp-dev] Question on plugin versioning for a given patch

2017-11-20 Thread Nick Boldt 
I would make sure that all the affected/changed features are upversioned in
compliance with whatever version-bump-checker tools are used in WTP.

I'm not sure what's currently used, but I'm happy to implement use of the
stuff we have in JBoss Tools [1] for WTP so it too can benefit from some of
the new features in Tycho.

[1]
https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L24-L27
and
https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L449-L467
and
https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L701-L722

That said... we need to get everyone using Tycho 1.0 for that to work.
We've still got a ways to go before that's possible.

On Mon, Nov 20, 2017 at 7:32 PM, Robert Stryker  wrote:

> Hey all:
>
> https://git.eclipse.org/r/#/c/111933/
>
> I merged this patch from Nick Boldt. It primarily changes how we're
> storing things like sourceTemplateBundle folders in features and plugins.
> This is because tycho will automatically generate these files for us, and
> so they don't really belong in the repository.
>
> Do any version changes to the plugins and features need to be made for a
> change like this?
>
> I also merged https://git.eclipse.org/r/#/c/110087/   and
> https://git.eclipse.org/r/#/c/110858/   which modify the root pom.xml and
> the .gitignore files.
>
> Any help or advice here would be appreciated. Looking to avoid any issues
> like last time.
>
> - Rob Stryker
>
> ___
> wtp-dev mailing list
> wtp-dev@eclipse.org
> To change your delivery options, retrieve your password, or unsubscribe
> from this list, visit
> https://dev.eclipse.org/mailman/listinfo/wtp-dev
>



-- 

Nick Boldt

Senior Software Engineer, RHCSA

Productization Lead :: JBoss Tools & Dev Studio

IM: @nickboldt / @nboldt / http://nick.divbyzero.com

TRIED. TESTED. TRUSTED. 
@ @redhatnews   Red Hat

___
wtp-dev mailing list
wtp-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev

[wtp-dev] Question on plugin versioning for a given patch

2017-11-20 Thread Robert Stryker 
Hey all:

https://git.eclipse.org/r/#/c/111933/

I merged this patch from Nick Boldt. It primarily changes how we're storing
things like sourceTemplateBundle folders in features and plugins. This is
because tycho will automatically generate these files for us, and so they
don't really belong in the repository.

Do any version changes to the plugins and features need to be made for a
change like this?

I also merged https://git.eclipse.org/r/#/c/110087/   and
https://git.eclipse.org/r/#/c/110858/   which modify the root pom.xml and
the .gitignore files.

Any help or advice here would be appreciated. Looking to avoid any issues
like last time.

- Rob Stryker
___
wtp-dev mailing list
wtp-dev@eclipse.org
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/wtp-dev