Re: [X2Go-Dev] Code formatting
OK in that case. Let's go actions. Since I think everybody agrees. Mike also discussed other platforms like Gitlab. Which I think is a good enabler. I'm able to help you with setting up your own gitlab server for example (like I did for myself: https://gitlab.melroy.org). Somebody said there was a Jenkins server. My question would be: which kind of server can I use to setup such kind of infrastructure? Is there something arranged within X2Go? I love to help, but you need some machines to execute it. Or has somebody some vm in the cloud? If I have root access to such a machine, I can start. Also dns records etc. Kind regards, Melroy van den Berg Original Message On May 21, 2020, 17:38, Oleksandr Shneyder wrote: > Well, there are a lot of different ways to do everything in this life. > The way I'm doing, works at the moment well for me and for X2Go as well > since about 10 years. I didn't tell, that there is nothing which could > be improved. Every one knows, that we need a test facility, but no one > is doing this. So, if you want to use the project for your purposes and > you want to give something back, everyone here will appreciate your > commitment. Just think before you are starting to do something here if > you'll want to bring it to the end. We had so many people here, who were > talking a lot, but didn't do anything at the end, just wasted everyone's > time. The things you are saying are right, but believe me, you didn't > say anything that we didn't know before. So, to the point, if you'll > create a test facility for X2Go, I think everyone will be thankful to > you for that. We also appreciate your thoughts, but the actions we are > appreciating even more. > > regards > Alex > > Am 21.05.20 um 09:57 schrieb Melroy van den Berg: >> Hi Alex, >> >> Ah, you have paying customers? >> >> >> Testing is part of the development cycle. Meaning you code production >> code with your left hand. And write test cases with your right hand. >> From the customer perspective there is no such choice to implement a >> feature without tests. It's either a new feature with test cases, proper >> review, and static code analysis, etc. Or they have nothing. >> >> I don't want to be rude, but it's a mindset change. Hopefully you get my >> point. The same is done in all my projects and the company I work for. >> >> Best regards, >> Melroy van den Berg >> >> Original Message >> On May 21, 2020, 16:22, Oleksandr Shneyder < o.shney...@phoca-gmbh.de> >> wrote: >> >> >> Whatever test facilities are good and are very important. The problem >> is, to create them we need resources. No one of my customers wants to >> pay for it. Anyway, I'm concentrated on the features development. So >> whoever is willing to create such tests is very welcome. >> >> Alex >> >> Am 21.05.20 um 03:14 schrieb Stefan Baur: >> > Am 21.05.20 um 08:28 schrieb Mike Gabriel: >> >> >> >> With the video recorded session start tests, we will get a lot of >> noise >> >> from changes in desktop environments and other third party components >> >> that X2Go sits on top of. We may not even want to test this >> >> automatically. Dunno... >> > >> > That's why I said we need a reference GUI app that doesn't randomly >> > change. So either something simplistic that already exists, or >> someting >> > specially crafted for this purpose. >> > >> > Run OpenBox or another "simple" window manager, no task bar (else the >> > clock or some status popups will trigger a "this doesn't match"), run >> > the test robot, take a screenshot, compare to template. >> > >> > -Stefan >> > >> > >> > ___ >> > x2go-dev mailing list >> > x2go-dev@lists.x2go.org >> > https://lists.x2go.org/listinfo/x2go-dev >> > >> >> -- >> --- >> Oleksandr Shneyder | Email: o.shney...@phoca-gmbh.de >> phoca GmbH | Tel. : 0911 - 14870374 0 >> Schleiermacherstr. 2 | Fax. : 0911 - 14870374 9 >> D-90491 Nürnberg | Mobil: 0163 - 49 64 461 >> >> Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder >> >> Amtsgericht München | http://www.phoca-gmbh.de >> HRB 196 658 | http://www.x2go.org >> USt-IdNr.: DE281977973 >> --- >> >> ___ >> x2go-dev mailing list >> x2go-dev@lists.x2go.org >> https://lists.x2go.org/listinfo/x2go-dev >> > > -- > --- > Oleksandr Shneyder | Email: o.shney...@phoca-gmbh.de > phoca GmbH | Tel. : 0911 - 14870374 0 > Schleiermacherstr. 2 | Fax. : 0911 - 14870374 9 > D-90491 Nürnberg | Mobil: 0163 - 49 64 461 > > Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder > > Amtsgericht München | http://www.phoca-gmbh.de > HRB 196 658 | http://www.x2go.org > USt-IdNr.: DE281977973 > --- > > ___ > x2go-dev mailing list >
Re: [X2Go-Dev] Code formatting
Hi Alex, Ah, you have paying customers? Testing is part of the development cycle. Meaning you code production code with your left hand. And write test cases with your right hand. From the customer perspective there is no such choice to implement a feature without tests. It's either a new feature with test cases, proper review, and static code analysis, etc. Or they have nothing. I don't want to be rude, but it's a mindset change. Hopefully you get my point. The same is done in all my projects and the company I work for. Best regards, Melroy van den Berg Original Message On May 21, 2020, 16:22, Oleksandr Shneyder wrote: > Whatever test facilities are good and are very important. The problem > is, to create them we need resources. No one of my customers wants to > pay for it. Anyway, I'm concentrated on the features development. So > whoever is willing to create such tests is very welcome. > > Alex > > Am 21.05.20 um 03:14 schrieb Stefan Baur: >> Am 21.05.20 um 08:28 schrieb Mike Gabriel: >>> >>> With the video recorded session start tests, we will get a lot of noise >>> from changes in desktop environments and other third party components >>> that X2Go sits on top of. We may not even want to test this >>> automatically. Dunno... >> >> That's why I said we need a reference GUI app that doesn't randomly >> change. So either something simplistic that already exists, or someting >> specially crafted for this purpose. >> >> Run OpenBox or another "simple" window manager, no task bar (else the >> clock or some status popups will trigger a "this doesn't match"), run >> the test robot, take a screenshot, compare to template. >> >> -Stefan >> >> >> ___ >> x2go-dev mailing list >> x2go-dev@lists.x2go.org >> https://lists.x2go.org/listinfo/x2go-dev >> > > -- > --- > Oleksandr Shneyder | Email: o.shney...@phoca-gmbh.de > phoca GmbH | Tel. : 0911 - 14870374 0 > Schleiermacherstr. 2 | Fax. : 0911 - 14870374 9 > D-90491 Nürnberg | Mobil: 0163 - 49 64 461 > > Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder > > Amtsgericht München | http://www.phoca-gmbh.de > HRB 196 658 | http://www.x2go.org > USt-IdNr.: DE281977973 > --- > > ___ > x2go-dev mailing list > x2go-dev@lists.x2go.org > https://lists.x2go.org/listinfo/x2go-dev___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] Code formatting
Well, there are a lot of different ways to do everything in this life. The way I'm doing, works at the moment well for me and for X2Go as well since about 10 years. I didn't tell, that there is nothing which could be improved. Every one knows, that we need a test facility, but no one is doing this. So, if you want to use the project for your purposes and you want to give something back, everyone here will appreciate your commitment. Just think before you are starting to do something here if you'll want to bring it to the end. We had so many people here, who were talking a lot, but didn't do anything at the end, just wasted everyone's time. The things you are saying are right, but believe me, you didn't say anything that we didn't know before. So, to the point, if you'll create a test facility for X2Go, I think everyone will be thankful to you for that. We also appreciate your thoughts, but the actions we are appreciating even more. regards Alex Am 21.05.20 um 09:57 schrieb Melroy van den Berg: > Hi Alex, > > Ah, you have paying customers? > > > Testing is part of the development cycle. Meaning you code production > code with your left hand. And write test cases with your right hand. > From the customer perspective there is no such choice to implement a > feature without tests. It's either a new feature with test cases, proper > review, and static code analysis, etc. Or they have nothing. > > I don't want to be rude, but it's a mindset change. Hopefully you get my > point. The same is done in all my projects and the company I work for. > > Best regards, > Melroy van den Berg > > Original Message > On May 21, 2020, 16:22, Oleksandr Shneyder < o.shney...@phoca-gmbh.de> > wrote: > > > Whatever test facilities are good and are very important. The problem > is, to create them we need resources. No one of my customers wants to > pay for it. Anyway, I'm concentrated on the features development. So > whoever is willing to create such tests is very welcome. > > Alex > > Am 21.05.20 um 03:14 schrieb Stefan Baur: > > Am 21.05.20 um 08:28 schrieb Mike Gabriel: > >> > >> With the video recorded session start tests, we will get a lot of > noise > >> from changes in desktop environments and other third party components > >> that X2Go sits on top of. We may not even want to test this > >> automatically. Dunno... > > > > That's why I said we need a reference GUI app that doesn't randomly > > change. So either something simplistic that already exists, or > someting > > specially crafted for this purpose. > > > > Run OpenBox or another "simple" window manager, no task bar (else the > > clock or some status popups will trigger a "this doesn't match"), run > > the test robot, take a screenshot, compare to template. > > > > -Stefan > > > > > > ___ > > x2go-dev mailing list > > x2go-dev@lists.x2go.org > > https://lists.x2go.org/listinfo/x2go-dev > > > > -- > --- > Oleksandr Shneyder | Email: o.shney...@phoca-gmbh.de > phoca GmbH | Tel. : 0911 - 14870374 0 > Schleiermacherstr. 2 | Fax. : 0911 - 14870374 9 > D-90491 Nürnberg | Mobil: 0163 - 49 64 461 > > Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder > > Amtsgericht München | http://www.phoca-gmbh.de > HRB 196 658 | http://www.x2go.org > USt-IdNr.: DE281977973 > --- > > ___ > x2go-dev mailing list > x2go-dev@lists.x2go.org > https://lists.x2go.org/listinfo/x2go-dev > -- --- Oleksandr Shneyder| Email: o.shney...@phoca-gmbh.de phoca GmbH| Tel. : 0911 - 14870374 0 Schleiermacherstr. 2 | Fax. : 0911 - 14870374 9 D-90491 Nürnberg | Mobil: 0163 - 49 64 461 Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder Amtsgericht München | http://www.phoca-gmbh.de HRB 196 658 | http://www.x2go.org USt-IdNr.: DE281977973 --- signature.asc Description: OpenPGP digital signature ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] Code formatting
Whatever test facilities are good and are very important. The problem is, to create them we need resources. No one of my customers wants to pay for it. Anyway, I'm concentrated on the features development. So whoever is willing to create such tests is very welcome. Alex Am 21.05.20 um 03:14 schrieb Stefan Baur: > Am 21.05.20 um 08:28 schrieb Mike Gabriel: >> >> With the video recorded session start tests, we will get a lot of noise >> from changes in desktop environments and other third party components >> that X2Go sits on top of. We may not even want to test this >> automatically. Dunno... > > That's why I said we need a reference GUI app that doesn't randomly > change. So either something simplistic that already exists, or someting > specially crafted for this purpose. > > Run OpenBox or another "simple" window manager, no task bar (else the > clock or some status popups will trigger a "this doesn't match"), run > the test robot, take a screenshot, compare to template. > > -Stefan > > > ___ > x2go-dev mailing list > x2go-dev@lists.x2go.org > https://lists.x2go.org/listinfo/x2go-dev > -- --- Oleksandr Shneyder| Email: o.shney...@phoca-gmbh.de phoca GmbH| Tel. : 0911 - 14870374 0 Schleiermacherstr. 2 | Fax. : 0911 - 14870374 9 D-90491 Nürnberg | Mobil: 0163 - 49 64 461 Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder Amtsgericht München | http://www.phoca-gmbh.de HRB 196 658 | http://www.x2go.org USt-IdNr.: DE281977973 --- signature.asc Description: OpenPGP digital signature ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] Code formatting
On Do 21 Mai 2020 01:59:24 CEST, Melroy van den Berg wrote: But maybe X2Go should first start creating unit testcases :P? Which should be the bare minimum in my opinion. As well as some automated pipeline triggering these kind of tests and other checks. Which should be part of the development cycle. I agree on this. Unit tests should come first. They will provide a lot of coverage, already. With the video recorded session start tests, we will get a lot of noise from changes in desktop environments and other third party components that X2Go sits on top of. We may not even want to test this automatically. Dunno... Mike -- DAS-NETZWERKTEAM c\o Technik- und Ökologiezentrum Eckernförde Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de pgpFRK0xnzFqG.pgp Description: Digitale PGP-Signatur ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] Unit tests (was: Code formatting)
Hi Melroy, On Mi 20 Mai 2020 17:19:50 CEST, Melroy van den Berg wrote: Ps. Where are the testcases? We may need to start creating (integration/unit) testcases to avoid regression issues when changing code. Most of the X2Go code components have been developed without unit tests. I can only speak for Python X2Go and X2Go Broker (as they are "my" projects). When I started Python X2Go, I was a Python newby and did not know what unit tests were. Several times in the past I though, how cool it would have been to do atomic unit tests on code changes. It would have saved my a lot of trouble. For X2Go Broker, I set up unit tests and several features (not full coverage, I guess) get tested and when I added new code, I offered 1-2 unit tests with the code. However, checking full test coverage via a CI might be the next step here, too. The problem is: where to start. I would _not_ start a CI test scenario where an X2Go client starts a session on some X2Go server and everything gets video recorded and analysed. This is skipping a step. One starting point could be: libx2goclient (gtest based unit tests or similar) x2gothinclient (chroot setup of TCE) x2go-live (chroot setup of X2Go Live Image) x2goserver (start adding unit tests from scratch, in retrospective) For libx2goclient, the unit tests can run at package build time. This can happen on the Jenkins server, we already have anyway. The chroot setup tests must run in containers or VMs, I guess. For this we need a CI worker and a Git interaction that triggers those. This is awkward with the current state of the Git server (git push via SSH login on a plain file system). Thus, one other first step would be e.g. a GitLab (or whatever Git web-based platform) setup. One that supports integrations of CI workers. As you sound pretty enthusiastic about helping out with X2Go, be prepared to put time in any of the above tasks (or any other related task) without much man power coming along to assist you (because we are all lacking time, due to family life, work life, etc.). However, I can offer expertise and background knowledge on X2Go development and the underlying communication between client and server, etc. If you want a quicker reply from me, put me in Cc: of your mails to the list (but don't drop the list from Cc:!!!). Thanks + Greets, Mike -- DAS-NETZWERKTEAM c\o Technik- und Ökologiezentrum Eckernförde Mike Gabriel, Marienthaler Str. 17, 24340 Eckernförde mobile: +49 (1520) 1976 148 landline: +49 (4351) 850 8940 GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de pgpkpoMdvp6Vm.pgp Description: Digitale PGP-Signatur ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
Re: [X2Go-Dev] Code formatting
Am 21.05.20 um 08:28 schrieb Mike Gabriel: > > With the video recorded session start tests, we will get a lot of noise > from changes in desktop environments and other third party components > that X2Go sits on top of. We may not even want to test this > automatically. Dunno... That's why I said we need a reference GUI app that doesn't randomly change. So either something simplistic that already exists, or someting specially crafted for this purpose. Run OpenBox or another "simple" window manager, no task bar (else the clock or some status popups will trigger a "this doesn't match"), run the test robot, take a screenshot, compare to template. -Stefan -- BAUR-ITCS UG (haftungsbeschränkt) Geschäftsführer: Stefan Baur Eichenäckerweg 10, 89081 Ulm | Registergericht Ulm, HRB 724364 Fon/Fax 0731 40 34 66-36/-35 | USt-IdNr.: DE268653243 signature.asc Description: OpenPGP digital signature ___ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev
