[X2Go-Dev] Bug#804: Bug#804: slot argument mismatch in ONMainWindow::slotTunnelOk causes hang during connect
On 10/03/2015 16:22, Mihai Moldovan wrote: Yes. The problem at hand is that this parameter is purely optional anyway and never used. I totally missed that this in that context does not refer to slotTunnelOk(int) but QSingleShotTimer::timeout(), which has no parameter. http://code.x2go.org/releases/binary-win32/x2goclient/tmp/x2goclient-4.0.4.0-2015.03.10-ffc56f3-setup.exe Have test repeatedly and I can't make it go wrong any more. Thanks for fixing this. Regards Will -- Will Wagner will_wag...@carallon.com Development Manager Office Tel: +44 (0)20 7471 9224 Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#804: Bug#804: slot argument mismatch in ONMainWindow::slotTunnelOk causes hang during connect
On 12.03.2015 02:09 PM, Will Wagner wrote: On 10/03/2015 16:22, Mihai Moldovan wrote: Yes. The problem at hand is that this parameter is purely optional anyway and never used. I totally missed that this in that context does not refer to slotTunnelOk(int) but QSingleShotTimer::timeout(), which has no parameter. [URL] Have test repeatedly and I can't make it go wrong any more. Thanks for fixing this. Thank you for getting back! I have merged the fix-fix into our master branch. Mihai signature.asc Description: OpenPGP digital signature ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#804: Bug#804: slot argument mismatch in ONMainWindow::slotTunnelOk causes hang during connect
On 10.03.2015 11:43 AM, Will Wagner wrote: So today I can unfortunately still reproduce this issue. It seems like yesterday there must have been something going on with my network which altered the timing of events. Btw, I think this has nothing to do with the network. On Windows, Xorg (and sshd) must be started whenever X2Go Client starts up, so if you start X2Go Client and connect to a session *fast enough* after startup, you can trigger this race condition. The debug log I get now is: [...] x2go-DEBUG-../src/onmainwindow.cpp:5176 Waiting for win-servers. QObject::connect: Incompatible sender/receiver arguments QSingleShotTimer::timeout() -- ONMainWindow::slotTunnelOk(int) x2go-DEBUG-../src/sshprocess.cpp:157 Direct tunnel: waiting for connections on localhost:31004 x2go-DEBUG-../src/onmainwindow.cpp:9316 got localhost x2go-DEBUG-../src/onmainwindow.cpp:9344 Port already used: 6001 x2go-DEBUG-../src/onmainwindow.cpp:9498 X is started. x2go-DEBUG-../src/onmainwindow.cpp:9865 All winservers are started. Looking at the change you made I don't believe you are allowed to connect a signal emitting no arguments to a slot that requires an argument and hence the incompatible sender/receiver argument error. Yes. The problem at hand is that this parameter is purely optional anyway and never used. I totally missed that this in that context does not refer to slotTunnelOk(int) but QSingleShotTimer::timeout(), which has no parameter. http://code.x2go.org/releases/binary-win32/x2goclient/tmp/x2goclient-4.0.4.0-2015.03.10-ffc56f3-setup.exe Mihai signature.asc Description: OpenPGP digital signature ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#804: Bug#804: slot argument mismatch in ONMainWindow::slotTunnelOk causes hang during connect
On 09/03/2015 19:50, Mihai Moldovan wrote: On 09.03.2015 08:45 PM, Will Wagner wrote: On 07/03/2015 02:09, Mihai Moldovan wrote: Can you please test http://code.x2go.org/releases/binary-win32/x2goclient/tmp/x2goclient-4.0.4.0-2015.03.07-982268a-setup.exe? This build appears to fix the issue, I have done 20+ successful session resumes. Thanks for testing! The fix is part of my bugfix/general branch and will be merged into master once I finish fixing another bug. In any case, it will be part of x2goclient's next release. So today I can unfortunately still reproduce this issue. It seems like yesterday there must have been something going on with my network which altered the timing of events. The debug log I get now is: x2go-INFO-1 Starting x2goclient... x2go-WARNING-1 Can't load translator: :/x2goclient_en_gb x2go-WARNING-2 Can't load translator: :/qt_en_GB x2go-DEBUG-../src/onmainwindow.cpp:1208 Removing apps from tray x2go-DEBUG-../src/onmainwindow.cpp:1176 Plugging apps in tray. x2go-DEBUG-../src/onmainwindow.cpp:9821 Getting Xorg settings. x2go-INFO-3 Started x2goclient. x2go-DEBUG-../src/onmainwindow.cpp:495 $HOME=C:/Users/willw x2go-DEBUG-../src/onmainwindow.cpp:2123 Reading 4 sessions from config file. x2go-DEBUG-../src/sessionbutton.cpp:319 creating QPixmap with session icon: ':/img/icons/128x128/x2gosession.png'. x2go-DEBUG-../src/sessionbutton.cpp:319 creating QPixmap with session icon: 'C/:/Users/willw/Documents/scooter.jpg'. QPixmap::scaled: Pixmap is a null pixmap x2go-DEBUG-../src/sessionbutton.cpp:319 creating QPixmap with session icon: 'C/:/Users/willw/Documents/waldorf.jpg'. QPixmap::scaled: Pixmap is a null pixmap x2go-DEBUG-../src/sessionbutton.cpp:319 creating QPixmap with session icon: 'C/:/Users/willw/Documents/animal.jpg'. QPixmap::scaled: Pixmap is a null pixmap x2go-DEBUG-../src/onmainwindow.cpp:9547 Starting win servers... x2go-DEBUG-../src/onmainwindow.cpp:9899 C:/Users/willw/.x2go/etc/sshd_config created. x2go-DEBUG-../src/onmainwindow.cpp:9316 got localhost x2go-DEBUG-../src/onmainwindow.cpp:2601 creating QPixmap with session icon: 'C/:/Users/willw/Documents/animal.jpg'. QPixmap::scaled: Pixmap is a null pixmap x2go-DEBUG-../src/onmainwindow.cpp:9338 Port is free: 7022 x2go-DEBUG-../src/onmainwindow.cpp:9955 Creating desktop: x2go_willw x2go-DEBUG-../src/onmainwindow.cpp:1208 Removing apps from tray x2go-INFO-8 Starting connection to server: animal.office.carallon.com:22 x2go-DEBUG-../src/onmainwindow.cpp:2702 Start new ssh connection to server:animal.office.carallon.com:22 krbLogin: false x2go-DEBUG-../src/sshmasterconnection.cpp:202 starting ssh connection without kerberos authentication x2go-DEBUG-../src/sshmasterconnection.cpp:206 SshMasterConnection, instance SshMasterConnection(0x35673f8) created x2go-DEBUG-../src/sshmasterconnection.cpp:442 SshMasterConnection, instance SshMasterConnection(0x35673f8) entering thread x2go-DEBUG-../src/sshmasterconnection.cpp:478 libSsh not inited yet, initting x2go-DEBUG-../src/sshmasterconnection.cpp:522 setting SSH DIR to C:/Users/willw/ssh x2go-DEBUG-../src/sshmasterconnection.cpp:789 cserverAuth x2go-DEBUG-../src/sshmasterconnection.cpp:804 state: 1 x2go-DEBUG-../src/sshmasterconnection.cpp:640 setting SSH DIR to C:/Users/willw/ssh x2go-DEBUG-../src/sshmasterconnection.cpp:963 Password authentication x2go-DEBUG-../src/sshmasterconnection.cpp:654 user auth OK x2go-DEBUG-../src/onmainwindow.cpp:2797 SSH connection established. x2go-DEBUG-../src/onmainwindow.cpp:3064 Continue normal x2go session x2go-DEBUG-../src/sshprocess.cpp:189 executing remote command via SshProcess object (0): export HOSTNAME x2golistsessions x2go-DEBUG-../src/sshprocess.cpp:194 running masterCon-addChannelConnection(this, 'aaa08901-5dfe-4de4-9ef2-00b12e2a8e43', 'sh -c 'echo X2GODATABEGIN:aaa08901-5dfe-4de4-9ef2-00b12e2a8e43; PATH=/usr/local/bin:/usr/bin:/bin export HOSTNAME x2golistsessions; echo X2GODATAEND:aaa08901-5dfe-4de4-9ef2-00b12e2a8e43;''); x2go-DEBUG-../src/sshmasterconnection.cpp:1245 locking SSH channel connection MUTEX. x2go-DEBUG-../src/sshmasterconnection.cpp:1247 passing con to channelConnections. x2go-DEBUG-../src/sshmasterconnection.cpp:1249 unlocking SSH channel connection MUTEX. x2go-DEBUG-../src/sshmasterconnection.cpp:1437 creating new channel x2go-DEBUG-../src/sshmasterconnection.cpp:1441 new channel:0x35c6608 x2go-DEBUG-../src/sshmasterconnection.cpp:1472 executing remote: sh -c 'echo X2GODATABEGIN:aaa08901-5dfe-4de4-9ef2-00b12e2a8e43; PATH=/usr/local/bin:/usr/bin:/bin export HOSTNAME x2golistsessions; echo X2GODATAEND:aaa08901-5dfe-4de4-9ef2-00b12e2a8e43;' x2go-DEBUG-../src/sshmasterconnection.cpp:1495 new exec channel created x2go-DEBUG-../src/sshmasterconnection.cpp:1599 EOF ON CHANNEL 0x35c6608 (SshProcess: 0) x2go-DEBUG-../src/sshmasterconnection.cpp:1667 eof sent x2go-DEBUG-../src/sshmasterconnection.cpp:1671 channel closed x2go-DEBUG-../src/sshprocess.cpp:450
[X2Go-Dev] Bug#804: Bug#804: slot argument mismatch in ONMainWindow::slotTunnelOk causes hang during connect
On 07/03/2015 02:09, Mihai Moldovan wrote: Can you please test http://code.x2go.org/releases/binary-win32/x2goclient/tmp/x2goclient-4.0.4.0-2015.03.07-982268a-setup.exe? I get a access forbidden message when I try to download that URL Regards Will -- Will Wagner will_wag...@carallon.com Development Manager Office Tel: +44 (0)20 7471 9224 Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#804: Bug#804: slot argument mismatch in ONMainWindow::slotTunnelOk causes hang during connect
On 07/03/2015 02:09, Mihai Moldovan wrote: Can you please test http://code.x2go.org/releases/binary-win32/x2goclient/tmp/x2goclient-4.0.4.0-2015.03.07-982268a-setup.exe? This build appears to fix the issue, I have done 20+ successful session resumes. Thanks Will -- Will Wagner will_wag...@carallon.com Development Manager Office Tel: +44 (0)20 7471 9224 Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#804: Bug#804: slot argument mismatch in ONMainWindow::slotTunnelOk causes hang during connect
On 09.03.2015 08:45 PM, Will Wagner wrote: On 07/03/2015 02:09, Mihai Moldovan wrote: Can you please test http://code.x2go.org/releases/binary-win32/x2goclient/tmp/x2goclient-4.0.4.0-2015.03.07-982268a-setup.exe? This build appears to fix the issue, I have done 20+ successful session resumes. Thanks for testing! The fix is part of my bugfix/general branch and will be merged into master once I finish fixing another bug. In any case, it will be part of x2goclient's next release. Mihai signature.asc Description: OpenPGP digital signature ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
[X2Go-Dev] Bug#804: Bug#804: slot argument mismatch in ONMainWindow::slotTunnelOk causes hang during connect
On 06.03.2015 12:23 PM, Will Wagner wrote: When trying to connect to certain servers I get 'Object::connect: No such slot ONMainWindow::slotTunnelOk()' in the debugging output of X2Go Client for Windows 4.0.3.2. The application hangs without ever connecting. From looking at the code in ONMainWindow::slotTunnelOk() it has a check to see if winServersReady is true and if not it uses QTimer::singleShot to retry 100mS later. However the slot connection has an argument mismatch and so slotTunnelOk is never called again and this leads to the hang. Can you please test http://code.x2go.org/releases/binary-win32/x2goclient/tmp/x2goclient-4.0.4.0-2015.03.07-982268a-setup.exe? Mihai signature.asc Description: OpenPGP digital signature ___ x2go-dev mailing list x2go-dev@lists.x2go.org http://lists.x2go.org/listinfo/x2go-dev
