Re: [Xen-devel] [OSSTEST PATCH] Executive: Permit OSSTEST_TASK= (for static tasks)

[Ian Campbell]

On Tue, 2015-12-08 at 14:19 +, Ian Jackson wrote:
> If OSSTEST_TASK is not set, we construct a  from the username
> and the nodename, and look for a such a static task.  If OSSTEST_TASK
> /is/ set would require it to contain `  '.
> 
> In this patch, permit OSSTEST_TASK to be set simply to the .
> This is much more convenient and doesn't involve manually looking up
> taskids.  The risk of error seems negligible.
> 
> Signed-off-by: Ian Jackson 

Acked-by: Ian Campbell 


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] [OSSTEST PATCH] Executive: Permit OSSTEST_TASK= (for static tasks)

[Ian Jackson]

If OSSTEST_TASK is not set, we construct a  from the username
and the nodename, and look for a such a static task.  If OSSTEST_TASK
/is/ set would require it to contain `  '.

In this patch, permit OSSTEST_TASK to be set simply to the .
This is much more convenient and doesn't involve manually looking up
taskids.  The risk of error seems negligible.

Signed-off-by: Ian Jackson 
---
 Osstest/Executive.pm |8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index fcef83f..84c7d46 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -446,13 +446,15 @@ sub findtask () {
 if (!defined $spec) {
 $!=0; $?=0; my $node=   `uname -n`; defined $node   or die "$? $!";
 chomp($node); $node =~ s/\..*//;
-my $refkey= "$c{Username}\@$node";
-$what= "static $refkey";
+   $spec= "$c{Username}\@$node";
+}
+if ($spec !~ m/\s/) {
+$what= "static $spec";
 $q= $dbh_tests->prepare(<execute($refkey);
+$q->execute($spec);
 } else {
 my @l = split /\s+/, $spec;
 @l==3 or die "$spec ".scalar(@l)." ?";
-- 
1.7.10.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel