Re: [Xen-devel] [OSSTEST PATCH 0/4] Miscellaneous bald yaks

2015-09-30 Thread Ian Campbell
On Tue, 2015-09-29 at 17:21 +0100, Ian Jackson wrote:
> There are two patches here to fix annoyances which can make
> osstest-installed Debian guests hard to get into.

> And two patches to reorganise slightly the runvar handling:
> introducing a function `target_var' to replace `guest_var'.  Currently
> there is no real motivation for this except that it seems tidier.

All look good to me:
Acked-by: Ian Campbell 



___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


[Xen-devel] [OSSTEST PATCH 0/4] Miscellaneous bald yaks

2015-09-29 Thread Ian Jackson
There are two patches here to fix annoyances which can make
osstest-installed Debian guests hard to get into.

And two patches to reorganise slightly the runvar handling:
introducing a function `target_var' to replace `guest_var'.  Currently
there is no real motivation for this except that it seems tidier.

(I thought I wanted this because I thought I wanted
TestSupport::await_tcp to know whether what it was probing was a
Debian install and if so what suite.  I also have an unfinished patch
to set the target var specifying the suite, in all the places where we
do a Debian install.  But I don't now think anything needs this so I
don't intend to finish that patch.)

I have done only fairly limited testing of the latter two patches.  If
they seem like a thing we want to keep I will test them properly, at
least to discover if they seem to break anything.

Thanks,
Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel