Re: [Xen-devel] [PATCH] x86/p2m: fix mismatched unlock

2015-09-14 Thread George Dunlap 
On Mon, Sep 14, 2015 at 8:13 AM, Jan Beulich  wrote:
> Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
> only a cosmetic issue right now.
>
> Signed-off-by: Jan Beulich 

Reviewed-by: George Dunlap 

> ---
> Despite its cosmetic nature I think it would be better to also fix this
> in 4.6.

I agree.

 -George

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] [PATCH] x86/p2m: fix mismatched unlock

2015-09-14 Thread Jan Beulich 
Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
only a cosmetic issue right now.

Signed-off-by: Jan Beulich 
---
Despite its cosmetic nature I think it would be better to also fix this
in 4.6.

--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -912,7 +912,7 @@ static int set_typed_p2m_entry(struct do
 omfn = p2m->get_entry(p2m, gfn, , , 0, NULL, NULL);
 if ( p2m_is_grant(ot) || p2m_is_foreign(ot) )
 {
-p2m_unlock(p2m);
+gfn_unlock(p2m, gfn, 0);
 domain_crash(d);
 return -ENOENT;
 }



x86/p2m: fix mismatched unlock

Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
only a cosmetic issue right now.

Signed-off-by: Jan Beulich 
---
Despite its cosmetic nature I think it would be better to also fix this
in 4.6.

--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -912,7 +912,7 @@ static int set_typed_p2m_entry(struct do
 omfn = p2m->get_entry(p2m, gfn, , , 0, NULL, NULL);
 if ( p2m_is_grant(ot) || p2m_is_foreign(ot) )
 {
-p2m_unlock(p2m);
+gfn_unlock(p2m, gfn, 0);
 domain_crash(d);
 return -ENOENT;
 }
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] x86/p2m: fix mismatched unlock

2015-09-14 Thread Andrew Cooper 
On 14/09/15 08:13, Jan Beulich wrote:
> Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
> only a cosmetic issue right now.
>
> Signed-off-by: Jan Beulich 

Reviewed-by: Andrew Cooper 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] x86/p2m: fix mismatched unlock

2015-09-14 Thread Wei Liu 
On Mon, Sep 14, 2015 at 01:13:31AM -0600, Jan Beulich wrote:
> Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
> only a cosmetic issue right now.
> 
> Signed-off-by: Jan Beulich 

Reviewed-by: Wei Liu 

> ---
> Despite its cosmetic nature I think it would be better to also fix this
> in 4.6.

Release-acked-by: Wei Liu 

> 
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -912,7 +912,7 @@ static int set_typed_p2m_entry(struct do
>  omfn = p2m->get_entry(p2m, gfn, , , 0, NULL, NULL);
>  if ( p2m_is_grant(ot) || p2m_is_foreign(ot) )
>  {
> -p2m_unlock(p2m);
> +gfn_unlock(p2m, gfn, 0);
>  domain_crash(d);
>  return -ENOENT;
>  }
> 
> 
> 

> x86/p2m: fix mismatched unlock
> 
> Luckily, due to gfn_unlock() currently mapping to p2m_unlock(), this is
> only a cosmetic issue right now.
> 
> Signed-off-by: Jan Beulich 
> ---
> Despite its cosmetic nature I think it would be better to also fix this
> in 4.6.
> 
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -912,7 +912,7 @@ static int set_typed_p2m_entry(struct do
>  omfn = p2m->get_entry(p2m, gfn, , , 0, NULL, NULL);
>  if ( p2m_is_grant(ot) || p2m_is_foreign(ot) )
>  {
> -p2m_unlock(p2m);
> +gfn_unlock(p2m, gfn, 0);
>  domain_crash(d);
>  return -ENOENT;
>  }


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel