Re: [Xen-devel] [PATCH] x86/psr: remove useless check in free_socket_resources

[Jan Beulich]

>>> On 09.08.17 at 14:35,  wrote:
> The check is useless because pointer arithmetic ensures "info" is
> always non-zero.
> 
> Replace it with an ASSERT for socket_info. The only caller of
> free_socket_resources already ensures socket_info is not NULL before
> calling it.
> 
> Coverity-ID: 1416344
> 
> Signed-off-by: Wei Liu 

Acked-by: Jan Beulich 



___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH] x86/psr: remove useless check in free_socket_resources

[Wei Liu]

The check is useless because pointer arithmetic ensures "info" is
always non-zero.

Replace it with an ASSERT for socket_info. The only caller of
free_socket_resources already ensures socket_info is not NULL before
calling it.

Coverity-ID: 1416344

Signed-off-by: Wei Liu 
---
 xen/arch/x86/psr.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c
index 9ce8f17a18..84f213ccf6 100644
--- a/xen/arch/x86/psr.c
+++ b/xen/arch/x86/psr.c
@@ -195,8 +195,7 @@ static void free_socket_resources(unsigned int socket)
 unsigned int i;
 struct psr_socket_info *info = socket_info + socket;
 
-if ( !info )
-return;
+ASSERT(socket_info);
 
 /*
  * Free resources of features. The global feature object, e.g. feat_l3,
-- 
2.11.0


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel