Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

2016-07-08 Thread Konrad Rzeszutek Wilk 
On Thu, Jul 07, 2016 at 09:57:10AM -0600, Jan Beulich wrote:
> >>> On 07.07.16 at 17:37,  wrote:
> > On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
> >> On 07/07/16 10:45, Roger Pau Monne wrote:
> >> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> >> >> The functions such get passed to have been taking pointers to const
> >> >> since at least 2.6.16.
> >> >>
> >> >> Signed-off-by: Jan Beulich 
> >> > Acked-by: Roger Pau Monné 
> >> >
> >> > Although the wording in the commit message looks weird to me, but I'm 
> >> > not a 
> > 
> >> > native speaker anyway.
> >> 
> >> As a native speaker, I can't parse it either.
> >> 
> >> I think s/such/these/ is needed.
> > 
> > The functions such as these have been taking pointers to const
> > since at least 2.6.16. 
> 
> I had taken Andrew's suggestion literally and changed it to "The
> functions these get passed to have been taking pointers to const
> since at least 2.6.16" for a possible (if needed) resubmission.

No need to resubmit. I will use Andrew's suggestion.
> 
> Jan

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

2016-07-07 Thread Jan Beulich 
>>> On 07.07.16 at 17:37,  wrote:
> On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
>> On 07/07/16 10:45, Roger Pau Monne wrote:
>> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
>> >> The functions such get passed to have been taking pointers to const
>> >> since at least 2.6.16.
>> >>
>> >> Signed-off-by: Jan Beulich 
>> > Acked-by: Roger Pau Monné 
>> >
>> > Although the wording in the commit message looks weird to me, but I'm not 
>> > a 
> 
>> > native speaker anyway.
>> 
>> As a native speaker, I can't parse it either.
>> 
>> I think s/such/these/ is needed.
> 
> The functions such as these have been taking pointers to const
> since at least 2.6.16. 

I had taken Andrew's suggestion literally and changed it to "The
functions these get passed to have been taking pointers to const
since at least 2.6.16" for a possible (if needed) resubmission.

Jan

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

2016-07-07 Thread Konrad Rzeszutek Wilk 
On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote:
> On 07/07/16 10:45, Roger Pau Monne wrote:
> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> >> The functions such get passed to have been taking pointers to const
> >> since at least 2.6.16.
> >>
> >> Signed-off-by: Jan Beulich 
> > Acked-by: Roger Pau Monné 
> >
> > Although the wording in the commit message looks weird to me, but I'm not a 
> > native speaker anyway.
> 
> As a native speaker, I can't parse it either.
> 
> I think s/such/these/ is needed.

The functions such as these have been taking pointers to const
since at least 2.6.16. 

?
> 
> ~Andrew
> 
> ___
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

2016-07-07 Thread Andrew Cooper 
On 07/07/16 10:45, Roger Pau Monne wrote:
> On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
>> The functions such get passed to have been taking pointers to const
>> since at least 2.6.16.
>>
>> Signed-off-by: Jan Beulich 
> Acked-by: Roger Pau Monné 
>
> Although the wording in the commit message looks weird to me, but I'm not a 
> native speaker anyway.

As a native speaker, I can't parse it either.

I think s/such/these/ is needed.

~Andrew

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

2016-07-07 Thread Roger Pau Monne 
On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote:
> The functions such get passed to have been taking pointers to const
> since at least 2.6.16.
> 
> Signed-off-by: Jan Beulich 

Acked-by: Roger Pau Monné 

Although the wording in the commit message looks weird to me, but I'm not a 
native speaker anyway.

Roger.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

2016-07-07 Thread Jan Beulich 
The functions such get passed to have been taking pointers to const
since at least 2.6.16.

Signed-off-by: Jan Beulich 
---
 drivers/block/xen-blkback/xenbus.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 4.7-rc6-xen.orig/drivers/block/xen-blkback/xenbus.c
+++ 4.7-rc6-xen/drivers/block/xen-blkback/xenbus.c
@@ -379,7 +379,7 @@ static struct attribute *xen_vbdstat_att
NULL
 };
 
-static struct attribute_group xen_vbdstat_group = {
+static const struct attribute_group xen_vbdstat_group = {
.name = "statistics",
.attrs = xen_vbdstat_attrs,
 };




___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel