Re: [Xen-devel] [PATCH] xen-blkback: really don't leak mode property

2016-07-07 Thread Konrad Rzeszutek Wilk 
On Thu, Jul 07, 2016 at 11:17:14AM +0200, Roger Pau Monne wrote:
> On Thu, Jul 07, 2016 at 01:38:13AM -0600, Jan Beulich wrote:
> > Commit 9d092603cc ("xen-blkback: do not leak mode property") left one
> > path unfixed; correct this.
> > 
> > Signed-off-by: Jan Beulich 
> 
> Acked-by: Roger Pau Monné 

Queued.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xen-blkback: really don't leak mode property

2016-07-07 Thread Roger Pau Monne 
On Thu, Jul 07, 2016 at 01:38:13AM -0600, Jan Beulich wrote:
> Commit 9d092603cc ("xen-blkback: do not leak mode property") left one
> path unfixed; correct this.
> 
> Signed-off-by: Jan Beulich 

Acked-by: Roger Pau Monné 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH] xen-blkback: really don't leak mode property

2016-07-07 Thread Jan Beulich 
Commit 9d092603cc ("xen-blkback: do not leak mode property") left one
path unfixed; correct this.

Signed-off-by: Jan Beulich 
---
 drivers/block/xen-blkback/xenbus.c |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

--- 4.7-rc6-xen.orig/drivers/block/xen-blkback/xenbus.c
+++ 4.7-rc6-xen/drivers/block/xen-blkback/xenbus.c
@@ -715,8 +715,11 @@ static void backend_changed(struct xenbu
 
/* Front end dir is a number, which is used as the handle. */
err = kstrtoul(strrchr(dev->otherend, '/') + 1, 0, );
-   if (err)
+   if (err) {
+   kfree(be->mode);
+   be->mode = NULL;
return;
+   }
 
be->major = major;
be->minor = minor;




___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel