Re: [Xen-devel] [PATCH] xsm/flask: Fix build following "xsm: correct AVC lookups for two sysctls"

2017-08-10 Thread Andrew Cooper 
On 10/08/17 15:09, Daniel De Graaf wrote:
> On 08/10/2017 09:17 AM, Andrew Cooper wrote:
>> avc_current_has_perm() takes 4 arguments, not 3.  Spotted by a Travis
>> randconfig run which actually turned XSM on.
>>
>> Signed-off-by: Andrew Cooper 
>
> Whoops, looks like I sent the non-build-tested patch by accident.
> Thanks for catching this!
>
> Acked-by: Daniel De Graaf 

Thanks.

While you are here, any input on
https://www.mail-archive.com/xen-devel@lists.xen.org/msg112930.html ?

~Andrew

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xsm/flask: Fix build following "xsm: correct AVC lookups for two sysctls"

2017-08-10 Thread Daniel De Graaf 

On 08/10/2017 09:17 AM, Andrew Cooper wrote:

avc_current_has_perm() takes 4 arguments, not 3.  Spotted by a Travis
randconfig run which actually turned XSM on.

Signed-off-by: Andrew Cooper 


Whoops, looks like I sent the non-build-tested patch by accident.
Thanks for catching this!

Acked-by: Daniel De Graaf 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xsm/flask: Fix build following "xsm: correct AVC lookups for two sysctls"

2017-08-10 Thread Andrew Cooper 
On 10/08/17 14:17, Andrew Cooper wrote:
> avc_current_has_perm() takes 4 arguments, not 3.  Spotted by a Travis
> randconfig run which actually turned XSM on.

Sorry - I intended to add this link to the commit message.

~Andrew

https://travis-ci.org/xen-project/xen/jobs/263063220

>
> Signed-off-by: Andrew Cooper 
> ---
> CC: Daniel De Graaf 
> ---
>  xen/xsm/flask/hooks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> index 17560b1..9114627 100644
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -815,11 +815,11 @@ static int flask_sysctl(int cmd)
>  
>  case XEN_SYSCTL_get_cpu_levelling_caps:
>  return avc_current_has_perm(SECINITSID_XEN, SECCLASS_XEN2,
> -XEN2__GET_CPU_LEVELLING_CAPS);
> +XEN2__GET_CPU_LEVELLING_CAPS, NULL);
>  
>  case XEN_SYSCTL_get_cpu_featureset:
>  return avc_current_has_perm(SECINITSID_XEN, SECCLASS_XEN2,
> -XEN2__GET_CPU_FEATURESET);
> +XEN2__GET_CPU_FEATURESET, NULL);
>  
>  case XEN_SYSCTL_livepatch_op:
>  return avc_current_has_perm(SECINITSID_XEN, SECCLASS_XEN2,


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH] xsm/flask: Fix build following "xsm: correct AVC lookups for two sysctls"

2017-08-10 Thread Andrew Cooper 
avc_current_has_perm() takes 4 arguments, not 3.  Spotted by a Travis
randconfig run which actually turned XSM on.

Signed-off-by: Andrew Cooper 
---
CC: Daniel De Graaf 
---
 xen/xsm/flask/hooks.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
index 17560b1..9114627 100644
--- a/xen/xsm/flask/hooks.c
+++ b/xen/xsm/flask/hooks.c
@@ -815,11 +815,11 @@ static int flask_sysctl(int cmd)
 
 case XEN_SYSCTL_get_cpu_levelling_caps:
 return avc_current_has_perm(SECINITSID_XEN, SECCLASS_XEN2,
-XEN2__GET_CPU_LEVELLING_CAPS);
+XEN2__GET_CPU_LEVELLING_CAPS, NULL);
 
 case XEN_SYSCTL_get_cpu_featureset:
 return avc_current_has_perm(SECINITSID_XEN, SECCLASS_XEN2,
-XEN2__GET_CPU_FEATURESET);
+XEN2__GET_CPU_FEATURESET, NULL);
 
 case XEN_SYSCTL_livepatch_op:
 return avc_current_has_perm(SECINITSID_XEN, SECCLASS_XEN2,
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel