Re: [Xen-devel] [PATCH] xsplice: Missing if ( sec )

2016-05-02 Thread Wei Liu 
On Mon, May 02, 2016 at 02:09:16PM +0100, Wei Liu wrote:
> On Mon, May 02, 2016 at 09:05:34AM -0400, Konrad Rzeszutek Wilk wrote:
> > Add the missing conditional.
> > 
> > Reported-by: Jan Beulich 
> > Signed-off-by: Konrad Rzeszutek Wilk 
> > 
> 
> FWIW:
> 
> Reviewed-by: Wei Liu 
> 
> And subject to ack from HV maintainer:
> 
> Release-acked-by: Wei Liu 
> 

I would like to have Ack from Jan, Andrew or Ross if possible. But this
bug is so trivial so whether they ack it or not my release ack stands.

Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xsplice: Missing if ( sec )

2016-05-02 Thread Jan Beulich 
>>> On 02.05.16 at 15:09,  wrote:
> On Mon, May 02, 2016 at 09:05:34AM -0400, Konrad Rzeszutek Wilk wrote:
>> Add the missing conditional.
>> 
>> Reported-by: Jan Beulich 
>> Signed-off-by: Konrad Rzeszutek Wilk 
>> 
> 
> FWIW:
> 
> Reviewed-by: Wei Liu 
> 
> And subject to ack from HV maintainer:
> 
> Release-acked-by: Wei Liu 

A think the ack can basically be implied from the Reported-by above;
Konrad - feel free.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xsplice: Missing if ( sec )

2016-05-02 Thread Wei Liu 
On Mon, May 02, 2016 at 09:05:34AM -0400, Konrad Rzeszutek Wilk wrote:
> Add the missing conditional.
> 
> Reported-by: Jan Beulich 
> Signed-off-by: Konrad Rzeszutek Wilk 
> 

FWIW:

Reviewed-by: Wei Liu 

And subject to ack from HV maintainer:

Release-acked-by: Wei Liu 

> ---
> This has been in there since v3 posting! And I really need to finish
> with the OSSTest regression tests to catch this.
> 
> Cc: Andrew Cooper 
> Cc: Jan Beulich 
> Cc: Wei Liu 
> ---
>  xen/common/xsplice.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c
> index 777faa7..c9fc53a 100644
> --- a/xen/common/xsplice.c
> +++ b/xen/common/xsplice.c
> @@ -548,6 +548,7 @@ static int prepare_payload(struct payload *payload,
>  }
>  
>  sec = xsplice_elf_sec_by_name(elf, ELF_XSPLICE_DEPENDS);
> +if ( sec )
>  {
>  n = sec->load_addr;
>  
> -- 
> 2.5.0
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] [PATCH] xsplice: Missing if ( sec )

2016-05-02 Thread Konrad Rzeszutek Wilk 
Add the missing conditional.

Reported-by: Jan Beulich 
Signed-off-by: Konrad Rzeszutek Wilk 

---
This has been in there since v3 posting! And I really need to finish
with the OSSTest regression tests to catch this.

Cc: Andrew Cooper 
Cc: Jan Beulich 
Cc: Wei Liu 
---
 xen/common/xsplice.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c
index 777faa7..c9fc53a 100644
--- a/xen/common/xsplice.c
+++ b/xen/common/xsplice.c
@@ -548,6 +548,7 @@ static int prepare_payload(struct payload *payload,
 }
 
 sec = xsplice_elf_sec_by_name(elf, ELF_XSPLICE_DEPENDS);
+if ( sec )
 {
 n = sec->load_addr;
 
-- 
2.5.0


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel