Re: [Xen-devel] [PATCH 0/2] xen: arm: Ensure all PTE bits have a known value
On 14/08/2015 14:41, Chris (Christopher) Brand wrote: Hi, Hi Chris, Thank you for the patch. This is more-or-less what Julien requested. He noted that pt.contig was never set to zero. When I looked further, I found other bits that were also never given a value. Looking at the callsites, they almost all seem to assume a value of zero, so that's what I went with. Patch 1 re-orders the assignments to match the declaration, making it clearer which ones are missing. Patch 2 then adds the missing bits. Chris P.S. Apologies for any threading issues - I have not yet managed to get git send-email working properly. I'm usually using git format-patch to get a list of files (one per patch) and my cover letter (--cover-letter). Then I use git send-email *.patch which will send the patch correctly threading. Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 0/2] xen: arm: Ensure all PTE bits have a known value
P.S. Apologies for any threading issues - I have not yet managed to get git send-email working properly. I'm usually using git format-patch to get a list of files (one per patch) and my cover letter (--cover-letter). Thanks. Then I use git send-email *.patch which will send the patch correctly threading. Yeah, the difficulty is finding the right set of --smtp* options to get it through our corporate mail server. I had it working once upon a time when I was working for Linaro, but something somewhere seems to have changed :-) Chris ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
[Xen-devel] [PATCH 0/2] xen: arm: Ensure all PTE bits have a known value
Hi, This is more-or-less what Julien requested. He noted that pt.contig was never set to zero. When I looked further, I found other bits that were also never given a value. Looking at the callsites, they almost all seem to assume a value of zero, so that's what I went with. Patch 1 re-orders the assignments to match the declaration, making it clearer which ones are missing. Patch 2 then adds the missing bits. Chris P.S. Apologies for any threading issues - I have not yet managed to get git send-email working properly. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
[Xen-devel] [PATCH 0/2] xen: arm: Ensure all PTE bits have a known value
Hi, This is more-or-less what Julien requested. He noted that pt.contig was never set to zero. When I looked further, I found other bits that were also never given a value. Looking at the callsites, they almost all seem to assume a value of zero, so that's what I went with. Patch 1 re-orders the assignments to match the declaration, making it clearer which ones are missing. Patch 2 then adds the missing bits. Chris P.S. Apologies for any threading issues - I have not yet managed to get git send-email working properly. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
