Re: [Xen-devel] [PATCH 0/4] libxl: support qemu's network-based block backends
On 02/17/2016 03:24 AM, Ian Campbell wrote: > On Tue, 2016-02-16 at 14:45 -0700, Jim Fehlig wrote: >> xl/libxl already supports qemu's network-based block backends >> such as nbd and rbd. libvirt has supported configuring network >> disks for long time too. This series marries the two in the >> libxl driver and in the xl<->xml converter. Only rbd supported >> is added in this series. Support for other backends such as nbd >> and iscsi can be added as a follow-up improvement. > This all looks sensible to me, FWIW. Thanks for taking a look! > > One question, in patch 3's commit log should the example be double escaping > the \\ or not? Based on your updates to $xen/docs/misc/xl-disk- > configuration.txt (posted separately on xen-devel) I had expected they > would. Yes, you are correct. The test and conversion code in patch 3 is wrong in that regard too. I've fixed it in V2. Regards, Jim ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 0/4] libxl: support qemu's network-based block backends
On Tue, 2016-02-16 at 14:45 -0700, Jim Fehlig wrote: > xl/libxl already supports qemu's network-based block backends > such as nbd and rbd. libvirt has supported configuring network > disks for long time too. This series marries the two in the > libxl driver and in the xl<->xml converter. Only rbd supported > is added in this series. Support for other backends such as nbd > and iscsi can be added as a follow-up improvement. This all looks sensible to me, FWIW. One question, in patch 3's commit log should the example be double escaping the \\ or not? Based on your updates to $xen/docs/misc/xl-disk- configuration.txt (posted separately on xen-devel) I had expected they would. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
[Xen-devel] [PATCH 0/4] libxl: support qemu's network-based block backends
xl/libxl already supports qemu's network-based block backends such as nbd and rbd. libvirt has supported configuring network disks for long time too. This series marries the two in the libxl driver and in the xl<->xml converter. Only rbd supported is added in this series. Support for other backends such as nbd and iscsi can be added as a follow-up improvement. Patch 1 is super trivial and contains no functional changes. Patch 2 changes the xl disk configuration produced by the xml->xl converter to use the formal key=value syntax described in xl-disk-configuration.txt. Patch 3 adds support for converting rbd info between xl and xml config formats. Patch 4 adds support for rbd disks in the libxl driver. Jim Fehlig (4): xenconfig: replace text 'xm' with 'xl' in xlconfigtest xenconfig: produce key=value disk config syntax in xl formatter xenconfig: support xl<->xml conversion of rbd disk devices libxl: add support for rbd qdisk src/libxl/libxl_conf.c | 192 - src/xenconfig/xen_xl.c | 168 -- .../test-disk-positional-parms-full.cfg| 26 +++ .../test-disk-positional-parms-full.xml| 54 ++ .../test-disk-positional-parms-partial.cfg | 26 +++ .../test-disk-positional-parms-partial.xml | 54 ++ .../test-fullvirt-direct-kernel-boot.cfg | 2 +- tests/xlconfigdata/test-fullvirt-multiusb.cfg | 2 +- tests/xlconfigdata/test-new-disk.cfg | 2 +- tests/xlconfigdata/test-paravirt-cmdline.cfg | 2 +- tests/xlconfigdata/test-paravirt-maxvcpus.cfg | 2 +- tests/xlconfigdata/test-rbd-multihost-noauth.cfg | 26 +++ tests/xlconfigdata/test-rbd-multihost-noauth.xml | 51 ++ tests/xlconfigdata/test-spice-features.cfg | 2 +- tests/xlconfigdata/test-spice.cfg | 2 +- tests/xlconfigdata/test-vif-rate.cfg | 2 +- tests/xlconfigtest.c | 37 ++-- 17 files changed, 610 insertions(+), 40 deletions(-) create mode 100644 tests/xlconfigdata/test-disk-positional-parms-full.cfg create mode 100644 tests/xlconfigdata/test-disk-positional-parms-full.xml create mode 100644 tests/xlconfigdata/test-disk-positional-parms-partial.cfg create mode 100644 tests/xlconfigdata/test-disk-positional-parms-partial.xml create mode 100644 tests/xlconfigdata/test-rbd-multihost-noauth.cfg create mode 100644 tests/xlconfigdata/test-rbd-multihost-noauth.xml -- 2.6.1 ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
