[Xen-devel] [PATCH 1/1] kexec: ensure kexec_status() return bit value of 0 or 1
When checking kexec_flags bit corresponding to the requested image, ensure that 0 or 1 is returned. Signed-off-by: Eric DeVolder --- xen/common/kexec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/common/kexec.c b/xen/common/kexec.c index aa808cb..3da27bf 100644 --- a/xen/common/kexec.c +++ b/xen/common/kexec.c @@ -1182,7 +1182,8 @@ static int kexec_status(XEN_GUEST_HANDLE_PARAM(void) uarg) if ( kexec_load_get_bits(status.type, &base, &bit) ) return -EINVAL; -return test_bit(bit, &kexec_flags); +/* Ensure return bit value of 0 or 1 */ +return !!test_bit(bit, &kexec_flags); } static int do_kexec_op_internal(unsigned long op, -- 2.7.4 ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 1/1] kexec: ensure kexec_status() return bit value of 0 or 1
On Thu, Jan 19, 2017 at 11:10:53AM -0600, Eric DeVolder wrote: > When checking kexec_flags bit corresponding to the > requested image, ensure that 0 or 1 is returned. > > Signed-off-by: Eric DeVolder In general Reviewed-by: Daniel Kiper but... > --- > xen/common/kexec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/xen/common/kexec.c b/xen/common/kexec.c > index aa808cb..3da27bf 100644 > --- a/xen/common/kexec.c > +++ b/xen/common/kexec.c > @@ -1182,7 +1182,8 @@ static int kexec_status(XEN_GUEST_HANDLE_PARAM(void) > uarg) > if ( kexec_load_get_bits(status.type, &base, &bit) ) > return -EINVAL; > > -return test_bit(bit, &kexec_flags); > +/* Ensure return bit value of 0 or 1 */ This is not needed here. "!!" is used very often and it is not an unusual stuff. So, it does not need any comment. However, I can agree that at first sight it looks strange. > +return !!test_bit(bit, &kexec_flags); Daniel ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 1/1] kexec: ensure kexec_status() return bit value of 0 or 1
>>> On 19.01.17 at 18:10, wrote: > --- a/xen/common/kexec.c > +++ b/xen/common/kexec.c > @@ -1182,7 +1182,8 @@ static int kexec_status(XEN_GUEST_HANDLE_PARAM(void) > uarg) > if ( kexec_load_get_bits(status.type, &base, &bit) ) > return -EINVAL; > > -return test_bit(bit, &kexec_flags); > +/* Ensure return bit value of 0 or 1 */ > +return !!test_bit(bit, &kexec_flags); > } I don't see the point of adding a comment here, but I'll let Andrew as the maintainer judge. In any event Reviewed-by: Jan Beulich Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 1/1] kexec: ensure kexec_status() return bit value of 0 or 1
On 19/01/17 17:10, Eric DeVolder wrote: > When checking kexec_flags bit corresponding to the > requested image, ensure that 0 or 1 is returned. > > Signed-off-by: Eric DeVolder Reviewed-by: Andrew Cooper and committed. I dropped the commit while doing so ~Andrew ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
