Re: [Xen-devel] [PATCH 1/2] Kconfig: introduce allrandom.config

2016-12-05 Thread Doug Goldstein 
On 12/5/16 10:45 AM, Wei Liu wrote:
> This would be used to force selection of certain items in randconfig.
> 
> We need this to force gcov format to be autodetected in randconfig
> target, which would avoid generating known-incompatible combinations.
> 
> Signed-off-by: Wei Liu 
> ---
> Cc: Doug Goldstein 
> ---
>  xen/tools/kconfig/allrandom.config | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 xen/tools/kconfig/allrandom.config
> 
> diff --git a/xen/tools/kconfig/allrandom.config 
> b/xen/tools/kconfig/allrandom.config
> new file mode 100644
> index 000..e49e7d6
> --- /dev/null
> +++ b/xen/tools/kconfig/allrandom.config
> @@ -0,0 +1 @@
> +CONFIG_GCOV_FORMAT_AUTODETECT=y
> 

Thank you for doing this Wei. I do agree with Andrew about the explicit
comment.

Reviewed-by: Doug Goldstein 

-- 
Doug Goldstein



signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/2] Kconfig: introduce allrandom.config

2016-12-05 Thread Andrew Cooper 
On 05/12/16 16:45, Wei Liu wrote:
> This would be used to force selection of certain items in randconfig.
>
> We need this to force gcov format to be autodetected in randconfig
> target, which would avoid generating known-incompatible combinations.
>
> Signed-off-by: Wei Liu 
> ---
> Cc: Doug Goldstein 
> ---
>  xen/tools/kconfig/allrandom.config | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 xen/tools/kconfig/allrandom.config
>
> diff --git a/xen/tools/kconfig/allrandom.config 
> b/xen/tools/kconfig/allrandom.config
> new file mode 100644
> index 000..e49e7d6
> --- /dev/null
> +++ b/xen/tools/kconfig/allrandom.config
> @@ -0,0 +1 @@

I'd put a comment here saying

# Explicit option choices not subject to regular RANDCONFIG

Otherwise, Reviewed-by: Andrew Cooper 

> +CONFIG_GCOV_FORMAT_AUTODETECT=y


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH 1/2] Kconfig: introduce allrandom.config

2016-12-05 Thread Wei Liu 
This would be used to force selection of certain items in randconfig.

We need this to force gcov format to be autodetected in randconfig
target, which would avoid generating known-incompatible combinations.

Signed-off-by: Wei Liu 
---
Cc: Doug Goldstein 
---
 xen/tools/kconfig/allrandom.config | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 xen/tools/kconfig/allrandom.config

diff --git a/xen/tools/kconfig/allrandom.config 
b/xen/tools/kconfig/allrandom.config
new file mode 100644
index 000..e49e7d6
--- /dev/null
+++ b/xen/tools/kconfig/allrandom.config
@@ -0,0 +1 @@
+CONFIG_GCOV_FORMAT_AUTODETECT=y
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel