Re: [Xen-devel] [PATCH 2/2] xen: dont fiddle with event channel masking in suspend/resume

[Boris Ostrovsky]

On 07/17/2017 01:47 PM, Juergen Gross wrote:
> Instead of fiddling with masking the event channels during suspend
> and resume handling let do the irq subsystem do its job. It will do
> the mask and unmask operations as needed.
>
> Signed-off-by: Juergen Gross 

Reviewed-by: Boris Ostrovsky 

(I've been running dumpdata with this for the last couple of days so you
can add Tested-by as well if you wish)

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 2/2] xen: dont fiddle with event channel masking in suspend/resume

[Thomas Gleixner]

On Mon, 17 Jul 2017, Juergen Gross wrote:

> Instead of fiddling with masking the event channels during suspend
> and resume handling let do the irq subsystem do its job. It will do
> the mask and unmask operations as needed.
> 
> Signed-off-by: Juergen Gross 

Acked-by: Thomas Gleixner 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH 2/2] xen: dont fiddle with event channel masking in suspend/resume

[Juergen Gross]

Instead of fiddling with masking the event channels during suspend
and resume handling let do the irq subsystem do its job. It will do
the mask and unmask operations as needed.

Signed-off-by: Juergen Gross 
---
 drivers/xen/events/events_base.c | 13 +++--
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
index b241bfa529ce..bae1f5d36c26 100644
--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -343,14 +343,6 @@ static void bind_evtchn_to_cpu(unsigned int chn, unsigned 
int cpu)
info->cpu = cpu;
 }
 
-static void xen_evtchn_mask_all(void)
-{
-   unsigned int evtchn;
-
-   for (evtchn = 0; evtchn < xen_evtchn_nr_channels(); evtchn++)
-   mask_evtchn(evtchn);
-}
-
 /**
  * notify_remote_via_irq - send event to remote end of event channel via irq
  * @irq: irq of event channel to send event to
@@ -1573,7 +1565,6 @@ void xen_irq_resume(void)
struct irq_info *info;
 
/* New event-channel space is not 'live' yet. */
-   xen_evtchn_mask_all();
xen_evtchn_resume();
 
/* No IRQ <-> event-channel mappings. */
@@ -1681,6 +1672,7 @@ module_param(fifo_events, bool, 0);
 void __init xen_init_IRQ(void)
 {
int ret = -EINVAL;
+   unsigned int evtchn;
 
if (fifo_events)
ret = xen_evtchn_fifo_init();
@@ -1692,7 +1684,8 @@ void __init xen_init_IRQ(void)
BUG_ON(!evtchn_to_irq);
 
/* No event channels are 'live' right now. */
-   xen_evtchn_mask_all();
+   for (evtchn = 0; evtchn < xen_evtchn_nr_channels(); evtchn++)
+   mask_evtchn(evtchn);
 
pirq_needs_eoi = pirq_needs_eoi_flag;
 
-- 
2.12.3


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel