[Xen-devel] [PATCH 3/5] x86/hvm: don't set the BSP as initialised in hvm_vcpu_initialise
The BSP will be marked as initialised after hvm_load_cpu_ctxt has loaded the initial state, which is called from the toolstack during domain creation. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/hvm/hvm.c | 4 1 file changed, 4 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 787b7de..05c3ca1 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -2474,10 +2474,6 @@ int hvm_vcpu_initialise(struct vcpu *v) /* Init guest TSC to start from zero. */ hvm_set_guest_tsc(v, 0); - -/* Can start up without SIPI-SIPI or setvcpucontext domctl. */ -v->is_initialised = 1; -clear_bit(_VPF_down, &v->pause_flags); } return 0; -- 1.9.5 (Apple Git-50.3) ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 3/5] x86/hvm: don't set the BSP as initialised in hvm_vcpu_initialise
>>> On 13.01.16 at 13:32, wrote: > The BSP will be marked as initialised after hvm_load_cpu_ctxt has loaded the > initial state, which is called from the toolstack during domain creation. But the comment that you remove says explicitly that this isn't a requirement. Jan > Signed-off-by: Roger Pau Monné > --- > Cc: Jan Beulich > Cc: Andrew Cooper > --- > xen/arch/x86/hvm/hvm.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c > index 787b7de..05c3ca1 100644 > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -2474,10 +2474,6 @@ int hvm_vcpu_initialise(struct vcpu *v) > > /* Init guest TSC to start from zero. */ > hvm_set_guest_tsc(v, 0); > - > -/* Can start up without SIPI-SIPI or setvcpucontext domctl. */ > -v->is_initialised = 1; > -clear_bit(_VPF_down, &v->pause_flags); > } > > return 0; > -- > 1.9.5 (Apple Git-50.3) ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 3/5] x86/hvm: don't set the BSP as initialised in hvm_vcpu_initialise
El 13/01/16 a les 17.29, Jan Beulich ha escrit: On 13.01.16 at 13:32, wrote: >> The BSP will be marked as initialised after hvm_load_cpu_ctxt has loaded the >> initial state, which is called from the toolstack during domain creation. > > But the comment that you remove says explicitly that this isn't a > requirement. Previous to my HVMlite series that was true, and HVM guests were started without setting any explicit CPU state (in fact we placed that horrible jmp at 0x0, because the IP was by default set to 0x0). This is no longer true, and now HVM guests require that a proper CPU context is loaded before starting. I believe this is better, and this change helps enforce this policy. Roger. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 3/5] x86/hvm: don't set the BSP as initialised in hvm_vcpu_initialise
>>> On 13.01.16 at 18:23, wrote: > El 13/01/16 a les 17.29, Jan Beulich ha escrit: > On 13.01.16 at 13:32, wrote: >>> The BSP will be marked as initialised after hvm_load_cpu_ctxt has loaded the >>> initial state, which is called from the toolstack during domain creation. >> >> But the comment that you remove says explicitly that this isn't a >> requirement. > > Previous to my HVMlite series that was true, and HVM guests were started > without setting any explicit CPU state (in fact we placed that horrible > jmp at 0x0, because the IP was by default set to 0x0). This is no longer > true, and now HVM guests require that a proper CPU context is loaded > before starting. I believe this is better, and this change helps enforce > this policy. Well, that's fine, but the patch description then needs to reflect this. Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
