Re: [Xen-devel] [PATCH 3/8] xen/arm: Fix comment coding style in handle_node in domain_build.c

[Ian Campbell]

On Tue, 2015-09-22 at 18:47 +0100, Julien Grall wrote:
> Only coding style changes. No functional changes.
> 
> Signed-off-by: Julien Grall 

Acked + applied since it was so trivial and standalone.

> ---
>  xen/arch/arm/domain_build.c | 9 ++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index f7ea240..651d75e 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1226,8 +1226,10 @@ static int handle_node(struct domain *d, struct
> kernel_info *kinfo,
>  return 0;
>  }
>  
> -/* Replace these nodes with our own. Note that the original may be
> - * used_by DOMID_XEN so this check comes first. */
> +/*
> + * Replace these nodes with our own. Note that the original may be
> + * used_by DOMID_XEN so this check comes first.
> + */
>  if ( device_get_class(node) == DEVICE_GIC )
>  return make_gic_node(d, kinfo->fdt, node);
>  if ( dt_match_node(timer_matches, node) )
> @@ -1240,7 +1242,8 @@ static int handle_node(struct domain *d, struct
> kernel_info *kinfo,
>  return 0;
>  }
>  
> -/* Even if the IOMMU device is not used by Xen, it should not be
> +/*
> + * Even if the IOMMU device is not used by Xen, it should not be
>   * passthrough to DOM0
>   */
>  if ( device_get_class(node) == DEVICE_IOMMU )

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 3/8] xen/arm: Fix comment coding style in handle_node in domain_build.c

[Ian Campbell]

On Tue, 2015-09-22 at 18:47 +0100, Julien Grall wrote:
> Only coding style changes. No functional changes.
> 
> Signed-off-by: Julien Grall 

Acked + applied since it was obvious.

> ---
>  xen/arch/arm/domain_build.c | 9 ++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index f7ea240..651d75e 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1226,8 +1226,10 @@ static int handle_node(struct domain *d, struct
> kernel_info *kinfo,
>  return 0;
>  }
>  
> -/* Replace these nodes with our own. Note that the original may be
> - * used_by DOMID_XEN so this check comes first. */
> +/*
> + * Replace these nodes with our own. Note that the original may be
> + * used_by DOMID_XEN so this check comes first.
> + */
>  if ( device_get_class(node) == DEVICE_GIC )
>  return make_gic_node(d, kinfo->fdt, node);
>  if ( dt_match_node(timer_matches, node) )
> @@ -1240,7 +1242,8 @@ static int handle_node(struct domain *d, struct
> kernel_info *kinfo,
>  return 0;
>  }
>  
> -/* Even if the IOMMU device is not used by Xen, it should not be
> +/*
> + * Even if the IOMMU device is not used by Xen, it should not be
>   * passthrough to DOM0
>   */
>  if ( device_get_class(node) == DEVICE_IOMMU )

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] [PATCH 3/8] xen/arm: Fix comment coding style in handle_node in domain_build.c

[Julien Grall]

Only coding style changes. No functional changes.

Signed-off-by: Julien Grall 
---
 xen/arch/arm/domain_build.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index f7ea240..651d75e 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -1226,8 +1226,10 @@ static int handle_node(struct domain *d, struct 
kernel_info *kinfo,
 return 0;
 }
 
-/* Replace these nodes with our own. Note that the original may be
- * used_by DOMID_XEN so this check comes first. */
+/*
+ * Replace these nodes with our own. Note that the original may be
+ * used_by DOMID_XEN so this check comes first.
+ */
 if ( device_get_class(node) == DEVICE_GIC )
 return make_gic_node(d, kinfo->fdt, node);
 if ( dt_match_node(timer_matches, node) )
@@ -1240,7 +1242,8 @@ static int handle_node(struct domain *d, struct 
kernel_info *kinfo,
 return 0;
 }
 
-/* Even if the IOMMU device is not used by Xen, it should not be
+/*
+ * Even if the IOMMU device is not used by Xen, it should not be
  * passthrough to DOM0
  */
 if ( device_get_class(node) == DEVICE_IOMMU )
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel