Re: [Xen-devel] [PATCH 4/5] gcov: add option to determine gcov format

2016-09-06 Thread Wei Liu 
On Fri, Sep 02, 2016 at 12:47:08PM +0100, Wei Liu wrote:
> Currently only gcc 3.4 format is supported.
> 
> Signed-off-by: Wei Liu 
> ---
> Cc: Andrew Cooper 
> Cc: George Dunlap 
> Cc: Ian Jackson 
> Cc: Jan Beulich 
> Cc: Konrad Rzeszutek Wilk 
> Cc: Stefano Stabellini 
> Cc: Tim Deegan 
> Cc: Wei Liu 

What should I do with this patch and the next one?

I'm fine with dropping both and replace them with a patch to
Kconfig.debug to make clear the format is currently 3.4, if people feel
strongly about that.

Wei.

> ---
>  xen/Kconfig.debug | 13 +
>  1 file changed, 13 insertions(+)
> 
> diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
> index 06afd80..2366b06 100644
> --- a/xen/Kconfig.debug
> +++ b/xen/Kconfig.debug
> @@ -33,6 +33,19 @@ config GCOV
> ---help---
>   Enable gcov (a test coverage program in GCC) support.
>  
> +choice
> + prompt "Specify Gcov format"
> + depends on GCOV
> + ---help---
> + The gcov format is determined by gcc version.
> +
> +config GCOV_FORMAT_3_4
> +   bool "GCC 3.4 format"
> +   ---help---
> +   Select this option to use the format specified in GCC 3.4.
> +
> +endchoice
> +
>  config LOCK_PROFILE
>   bool "Lock Profiling"
>   ---help---
> -- 
> 2.1.4
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 4/5] gcov: add option to determine gcov format

2016-09-02 Thread Wei Liu 
On Fri, Sep 02, 2016 at 01:08:27PM +0100, Wei Liu wrote:
> On Fri, Sep 02, 2016 at 06:01:22AM -0600, Jan Beulich wrote:
> > >>> On 02.09.16 at 13:47,  wrote:
> > > Currently only gcc 3.4 format is supported.
> > 
> > Doesn't this patch contradict your coverage letter? Here you provide
> > means to add support for further formats, but there you said there's
> > no obvious route to that goal.
> > 
> 
> There is a way, we can ditch the old interface and just hand back the
> blob.
> 

Let me try to make myself clearer because now I reread my reply it
doesn't seem to convey my thought.

There are two issues:

1. The sysctl interface is tied to gcc 3.4 format.
2. The implementation inside Xen is tied to gcc 3.4 format.

My cover letter was referring to #1 because there is no way to fit newer
gcc format into the existing Xen sysctl coverage interface. To solve #1
I'm afraid we need to design new interfaces.

#2 is independent of #1. Regardless of what the sysctl interface looks
like, Xen needs to know which format to use (size of the structure,
offset of fields etc) in order to extract information.

This patch (sorta) deals with #2 and is one step towards dealing with
#1.

Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 4/5] gcov: add option to determine gcov format

2016-09-02 Thread Wei Liu 
On Fri, Sep 02, 2016 at 06:01:22AM -0600, Jan Beulich wrote:
> >>> On 02.09.16 at 13:47,  wrote:
> > Currently only gcc 3.4 format is supported.
> 
> Doesn't this patch contradict your coverage letter? Here you provide
> means to add support for further formats, but there you said there's
> no obvious route to that goal.
> 

There is a way, we can ditch the old interface and just hand back the
blob.

Wei.

> Jan
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 4/5] gcov: add option to determine gcov format

2016-09-02 Thread Jan Beulich 
>>> On 02.09.16 at 13:47,  wrote:
> Currently only gcc 3.4 format is supported.

Doesn't this patch contradict your coverage letter? Here you provide
means to add support for further formats, but there you said there's
no obvious route to that goal.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH 4/5] gcov: add option to determine gcov format

2016-09-02 Thread Wei Liu 
Currently only gcc 3.4 format is supported.

Signed-off-by: Wei Liu 
---
Cc: Andrew Cooper 
Cc: George Dunlap 
Cc: Ian Jackson 
Cc: Jan Beulich 
Cc: Konrad Rzeszutek Wilk 
Cc: Stefano Stabellini 
Cc: Tim Deegan 
Cc: Wei Liu 
---
 xen/Kconfig.debug | 13 +
 1 file changed, 13 insertions(+)

diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
index 06afd80..2366b06 100644
--- a/xen/Kconfig.debug
+++ b/xen/Kconfig.debug
@@ -33,6 +33,19 @@ config GCOV
---help---
  Enable gcov (a test coverage program in GCC) support.
 
+choice
+   prompt "Specify Gcov format"
+   depends on GCOV
+   ---help---
+   The gcov format is determined by gcc version.
+
+config GCOV_FORMAT_3_4
+   bool "GCC 3.4 format"
+   ---help---
+   Select this option to use the format specified in GCC 3.4.
+
+endchoice
+
 config LOCK_PROFILE
bool "Lock Profiling"
---help---
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel