Re: [Xen-devel] [PATCH 4/7] tools: Update sys/poll.h to poll.h

2016-12-20 Thread Alistair Francis 
On Mon, Dec 19, 2016 at 8:00 PM, Doug Goldstein  wrote:
> On 12/19/16 12:01 PM, Alistair Francis wrote:
>> On Sat, Dec 17, 2016 at 7:55 AM, Konrad Rzeszutek Wilk
>>  wrote:
>>> On Fri, Dec 16, 2016 at 02:56:04PM -0800, Alistair Francis wrote:
 To avoid this build error with newer build systems:
>>>
>>> And what is newer? GCC 5? 6?
>>
>> In this case it is GCC 5.
>>
>
> No. Its a libc thing. I wonder what libc you're using because glibc 2.24
> still has it at sys/pool.h for me.

Yeah, you are right. I don't know what I was thinking.

I'm using musl version 1.1.15 which prints a warning every time you
call sys/poll.h.

Looking at the latest glibc master branch glibc supports both and
doesn't have any warnings. This probably isn't the right thing to do
then. I will just have to remove Werror instead.

Thanks,

Alistair

>
> --
> Doug Goldstein
>
>
> ___
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
>

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 4/7] tools: Update sys/poll.h to poll.h

2016-12-19 Thread Doug Goldstein 
On 12/19/16 12:01 PM, Alistair Francis wrote:
> On Sat, Dec 17, 2016 at 7:55 AM, Konrad Rzeszutek Wilk
>  wrote:
>> On Fri, Dec 16, 2016 at 02:56:04PM -0800, Alistair Francis wrote:
>>> To avoid this build error with newer build systems:
>>
>> And what is newer? GCC 5? 6?
> 
> In this case it is GCC 5.
> 

No. Its a libc thing. I wonder what libc you're using because glibc 2.24
still has it at sys/pool.h for me.

-- 
Doug Goldstein



signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 4/7] tools: Update sys/poll.h to poll.h

2016-12-19 Thread Alistair Francis 
On Sat, Dec 17, 2016 at 7:55 AM, Konrad Rzeszutek Wilk
 wrote:
> On Fri, Dec 16, 2016 at 02:56:04PM -0800, Alistair Francis wrote:
>> To avoid this build error with newer build systems:
>
> And what is newer? GCC 5? 6?

In this case it is GCC 5.

Thanks,

Alistair

>
> Thanks.
>>   error: #warning redirecting incorrect #include  to
>>   [-Werror=cpp]
>>
>> Rename sys/poll.h to poll.h
>>
>> Signed-off-by: Alistair Francis 
>> ---
>>  tools/libxl/libxl_internal.h   | 2 +-
>>  tools/tests/xen-access/xen-access.c| 2 +-
>>  tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +-
>>  tools/xentrace/xentrace.c  | 2 +-
>>  4 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
>> index 5f46578..acf9ac2 100644
>> --- a/tools/libxl/libxl_internal.h
>> +++ b/tools/libxl/libxl_internal.h
>> @@ -38,7 +38,7 @@
>>  #include 
>>
>>  #include 
>> -#include 
>> +#include 
>>  #include 
>>  #include 
>>  #include 
>> diff --git a/tools/tests/xen-access/xen-access.c 
>> b/tools/tests/xen-access/xen-access.c
>> index 9d4f957..887bcd9 100644
>> --- a/tools/tests/xen-access/xen-access.c
>> +++ b/tools/tests/xen-access/xen-access.c
>> @@ -36,7 +36,7 @@
>>  #include 
>>  #include 
>>  #include 
>> -#include 
>> +#include 
>>
>>  #include 
>>  #include 
>> diff --git a/tools/xenstat/libxenstat/src/xenstat_qmp.c 
>> b/tools/xenstat/libxenstat/src/xenstat_qmp.c
>> index a87c937..3fda487 100644
>> --- a/tools/xenstat/libxenstat/src/xenstat_qmp.c
>> +++ b/tools/xenstat/libxenstat/src/xenstat_qmp.c
>> @@ -14,7 +14,7 @@
>>  #include 
>>  #include 
>>  #include 
>> -#include 
>> +#include 
>>  #include 
>>  #include 
>>  #include 
>> diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
>> index f09fe6c..364a6fd 100644
>> --- a/tools/xentrace/xentrace.c
>> +++ b/tools/xentrace/xentrace.c
>> @@ -24,7 +24,7 @@
>>  #include 
>>  #include 
>>  #include 
>> -#include 
>> +#include 
>>  #include 
>>
>>  #include 
>> --
>> 2.7.4
>>
>>
>> ___
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> https://lists.xen.org/xen-devel

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 4/7] tools: Update sys/poll.h to poll.h

2016-12-17 Thread Konrad Rzeszutek Wilk 
On Fri, Dec 16, 2016 at 02:56:04PM -0800, Alistair Francis wrote:
> To avoid this build error with newer build systems:

And what is newer? GCC 5? 6?

Thanks.
>   error: #warning redirecting incorrect #include  to
>   [-Werror=cpp]
> 
> Rename sys/poll.h to poll.h
> 
> Signed-off-by: Alistair Francis 
> ---
>  tools/libxl/libxl_internal.h   | 2 +-
>  tools/tests/xen-access/xen-access.c| 2 +-
>  tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +-
>  tools/xentrace/xentrace.c  | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 5f46578..acf9ac2 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -38,7 +38,7 @@
>  #include 
>  
>  #include 
> -#include 
> +#include 
>  #include 
>  #include 
>  #include 
> diff --git a/tools/tests/xen-access/xen-access.c 
> b/tools/tests/xen-access/xen-access.c
> index 9d4f957..887bcd9 100644
> --- a/tools/tests/xen-access/xen-access.c
> +++ b/tools/tests/xen-access/xen-access.c
> @@ -36,7 +36,7 @@
>  #include 
>  #include 
>  #include 
> -#include 
> +#include 
>  
>  #include 
>  #include 
> diff --git a/tools/xenstat/libxenstat/src/xenstat_qmp.c 
> b/tools/xenstat/libxenstat/src/xenstat_qmp.c
> index a87c937..3fda487 100644
> --- a/tools/xenstat/libxenstat/src/xenstat_qmp.c
> +++ b/tools/xenstat/libxenstat/src/xenstat_qmp.c
> @@ -14,7 +14,7 @@
>  #include 
>  #include 
>  #include 
> -#include 
> +#include 
>  #include 
>  #include 
>  #include 
> diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
> index f09fe6c..364a6fd 100644
> --- a/tools/xentrace/xentrace.c
> +++ b/tools/xentrace/xentrace.c
> @@ -24,7 +24,7 @@
>  #include 
>  #include 
>  #include 
> -#include 
> +#include 
>  #include 
>  
>  #include 
> -- 
> 2.7.4
> 
> 
> ___
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH 4/7] tools: Update sys/poll.h to poll.h

2016-12-16 Thread Alistair Francis 
To avoid this build error with newer build systems:
  error: #warning redirecting incorrect #include  to
  [-Werror=cpp]

Rename sys/poll.h to poll.h

Signed-off-by: Alistair Francis 
---
 tools/libxl/libxl_internal.h   | 2 +-
 tools/tests/xen-access/xen-access.c| 2 +-
 tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +-
 tools/xentrace/xentrace.c  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 5f46578..acf9ac2 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -38,7 +38,7 @@
 #include 
 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/tools/tests/xen-access/xen-access.c 
b/tools/tests/xen-access/xen-access.c
index 9d4f957..887bcd9 100644
--- a/tools/tests/xen-access/xen-access.c
+++ b/tools/tests/xen-access/xen-access.c
@@ -36,7 +36,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 
 #include 
 #include 
diff --git a/tools/xenstat/libxenstat/src/xenstat_qmp.c 
b/tools/xenstat/libxenstat/src/xenstat_qmp.c
index a87c937..3fda487 100644
--- a/tools/xenstat/libxenstat/src/xenstat_qmp.c
+++ b/tools/xenstat/libxenstat/src/xenstat_qmp.c
@@ -14,7 +14,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
index f09fe6c..364a6fd 100644
--- a/tools/xentrace/xentrace.c
+++ b/tools/xentrace/xentrace.c
@@ -24,7 +24,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 
 #include 
-- 
2.7.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel