Re: [Xen-devel] [PATCH OSSTEST v2 1/2] uboot: do not use readlink on xsm policy

2015-03-31 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST v2 1/2] uboot: do not use readlink on xsm 
policy"):
> The policy is not a symlink, so readlink will return nothing.
> 
> We cannot use readlink -f because that will return an absolute path
> and we need a path relative to the filesystem root (in this case
> /boot).
> 
> Keep flaskpolicy=$flaskpolicy as a shell variable rather than
> unescaping the uses (so they are interpreted by Perl) to easy any
> future changes.
> 
> Signed-off-by: Ian Campbell 

Acked-by: Ian Jackson 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


[Xen-devel] [PATCH OSSTEST v2 1/2] uboot: do not use readlink on xsm policy

2015-03-27 Thread Ian Campbell
The policy is not a symlink, so readlink will return nothing.

We cannot use readlink -f because that will return an absolute path
and we need a path relative to the filesystem root (in this case
/boot).

Keep flaskpolicy=$flaskpolicy as a shell variable rather than
unescaping the uses (so they are interpreted by Perl) to easy any
future changes.

Signed-off-by: Ian Campbell 
---
Replaces: uboot: use "readlink -f"
---
 Osstest/Debian.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index 6784024..3a0993b 100644
--- a/Osstest/Debian.pm
+++ b/Osstest/Debian.pm
@@ -162,7 +162,7 @@ sub setupboot_uboot () {
$flask_commands =