Re: [Xen-devel] [PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()
Andrew Cooper writes (Re: [Xen-devel] [PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()): On 07/07/15 16:48, Jennifer Herbert wrote: +else +fprintf(lg-f, [localtime_r failed: %d] , errno); lg-f ? I didn't spot this. I guess the patch wasn't build-tested... Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()
Jennifer Herbert writes ([PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()): Unlikely that it may seem localtime_r could fail, which would result in a null pointer dereference. In this case, it shoud log the errno, (instead of the date/time), and and continue its logging, as this is still useful. Thanks, Acked-by: Ian Jackson ian.jack...@eu.citrix.com ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
[Xen-devel] [PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()
Unlikely that it may seem localtime_r could fail, which would result in a null pointer dereference. In this case, it shoud log the errno, (instead of the date/time), and and continue its logging, as this is still useful. Signed-off-by: Jennifer Herbert jennifer.herb...@citrix.com --- tools/libxc/xtl_logger_stdio.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tools/libxc/xtl_logger_stdio.c b/tools/libxc/xtl_logger_stdio.c index d8646e0..5569c50 100644 --- a/tools/libxc/xtl_logger_stdio.c +++ b/tools/libxc/xtl_logger_stdio.c @@ -61,10 +61,13 @@ static void stdiostream_vmessage(xentoollog_logger *logger_in, struct tm lt_buf; time_t now = time(0); struct tm *lt= localtime_r(now, lt_buf); -fprintf(lg-f, %04d-%02d-%02d %02d:%02d:%02d %s , -lt-tm_year+1900, lt-tm_mon+1, lt-tm_mday, -lt-tm_hour, lt-tm_min, lt-tm_sec, -tzname[!!lt-tm_isdst]); +if (lt != NULL) +fprintf(lg-f, %04d-%02d-%02d %02d:%02d:%02d %s , +lt-tm_year+1900, lt-tm_mon+1, lt-tm_mday, +lt-tm_hour, lt-tm_min, lt-tm_sec, +tzname[!!lt-tm_isdst]); +else +fprintf(lg-f, [localtime_r failed: %d] , errno); } if (lg-flags XTL_STDIOSTREAM_SHOW_PID) fprintf(lg-f, [%lu] , (unsigned long)getpid()); -- 1.7.10.4 ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()
I guess I didn't build what I thought I built. V3 coming up On 07/07/15 16:51, Andrew Cooper wrote: On 07/07/15 16:48, Jennifer Herbert wrote: Unlikely that it may seem localtime_r could fail, which would result in a null pointer dereference. In this case, it shoud log the errno, (instead of the date/time), and and continue its logging, as this is still useful. Signed-off-by: Jennifer Herbert jennifer.herb...@citrix.com --- tools/libxc/xtl_logger_stdio.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tools/libxc/xtl_logger_stdio.c b/tools/libxc/xtl_logger_stdio.c index d8646e0..5569c50 100644 --- a/tools/libxc/xtl_logger_stdio.c +++ b/tools/libxc/xtl_logger_stdio.c @@ -61,10 +61,13 @@ static void stdiostream_vmessage(xentoollog_logger *logger_in, struct tm lt_buf; time_t now = time(0); struct tm *lt= localtime_r(now, lt_buf); -fprintf(lg-f, %04d-%02d-%02d %02d:%02d:%02d %s , -lt-tm_year+1900, lt-tm_mon+1, lt-tm_mday, -lt-tm_hour, lt-tm_min, lt-tm_sec, -tzname[!!lt-tm_isdst]); +if (lt != NULL) +fprintf(lg-f, %04d-%02d-%02d %02d:%02d:%02d %s , +lt-tm_year+1900, lt-tm_mon+1, lt-tm_mday, +lt-tm_hour, lt-tm_min, lt-tm_sec, +tzname[!!lt-tm_isdst]); +else +fprintf(lg-f, [localtime_r failed: %d] , errno); lg-f ? ~Andrew } if (lg-flags XTL_STDIOSTREAM_SHOW_PID) fprintf(lg-f, [%lu] , (unsigned long)getpid()); ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()
On 07/07/15 16:48, Jennifer Herbert wrote: Unlikely that it may seem localtime_r could fail, which would result in a null pointer dereference. In this case, it shoud log the errno, (instead of the date/time), and and continue its logging, as this is still useful. Signed-off-by: Jennifer Herbert jennifer.herb...@citrix.com --- tools/libxc/xtl_logger_stdio.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tools/libxc/xtl_logger_stdio.c b/tools/libxc/xtl_logger_stdio.c index d8646e0..5569c50 100644 --- a/tools/libxc/xtl_logger_stdio.c +++ b/tools/libxc/xtl_logger_stdio.c @@ -61,10 +61,13 @@ static void stdiostream_vmessage(xentoollog_logger *logger_in, struct tm lt_buf; time_t now = time(0); struct tm *lt= localtime_r(now, lt_buf); -fprintf(lg-f, %04d-%02d-%02d %02d:%02d:%02d %s , -lt-tm_year+1900, lt-tm_mon+1, lt-tm_mday, -lt-tm_hour, lt-tm_min, lt-tm_sec, -tzname[!!lt-tm_isdst]); +if (lt != NULL) +fprintf(lg-f, %04d-%02d-%02d %02d:%02d:%02d %s , +lt-tm_year+1900, lt-tm_mon+1, lt-tm_mday, +lt-tm_hour, lt-tm_min, lt-tm_sec, +tzname[!!lt-tm_isdst]); +else +fprintf(lg-f, [localtime_r failed: %d] , errno); lg-f ? ~Andrew } if (lg-flags XTL_STDIOSTREAM_SHOW_PID) fprintf(lg-f, [%lu] , (unsigned long)getpid()); ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()
On 07/07/15 17:05, Ian Jackson wrote: Andrew Cooper writes (Re: [Xen-devel] [PATCH V2] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()): On 07/07/15 16:48, Jennifer Herbert wrote: +else +fprintf(lg-f, [localtime_r failed: %d] , errno); lg-f ? I didn't spot this. I guess the patch wasn't build-tested... Not sure what happened there - something was built tested, but I presumably without this patch. Sorry about that. -jenny ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
