Re: [Xen-devel] [PATCH for-next v3 11/12] x86/pv/domain: clean up setup_compat_l4

[Jan Beulich]

>>> On 26.04.17 at 17:54,  wrote:
> Move updating type_info after clearing the page. Add spaces.

Suggested-by: Andrew ... ?

> Signed-off-by: Wei Liu 

Reviewed-by: Jan Beulich 



___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH for-next v3 11/12] x86/pv/domain: clean up setup_compat_l4

[Wei Liu]

Move updating type_info after clearing the page. Add spaces.

Signed-off-by: Wei Liu 
---
 xen/arch/x86/pv/domain.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/pv/domain.c b/xen/arch/x86/pv/domain.c
index 8f6c6c5dec..a01e3516ca 100644
--- a/xen/arch/x86/pv/domain.c
+++ b/xen/arch/x86/pv/domain.c
@@ -32,14 +32,14 @@ static int setup_compat_l4(struct vcpu *v)
 if ( pg == NULL )
 return -ENOMEM;
 
-/* This page needs to look like a pagetable so that it can be shadowed */
-pg->u.inuse.type_info = PGT_l4_page_table|PGT_validated|1;
-
 l4tab = __map_domain_page(pg);
 clear_page(l4tab);
 init_guest_l4_table(l4tab, v->domain, 1);
 unmap_domain_page(l4tab);
 
+/* This page needs to look like a pagetable so that it can be shadowed */
+pg->u.inuse.type_info = PGT_l4_page_table | PGT_validated | 1;
+
 v->arch.guest_table = pagetable_from_page(pg);
 v->arch.guest_table_user = v->arch.guest_table;
 
-- 
2.11.0


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel