Re: [Xen-devel] [PATCH for 4.6 v2 1/3] libxl: set ret to non-zero value in failure path

[Wei Liu]

On Fri, Sep 11, 2015 at 02:26:54PM +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH for 4.6 v2 1/3] libxl: set ret 
> to non-zero value in failure path"):
> > On Thu, 2015-09-10 at 11:55 +0100, Ian Campbell wrote:
> > > On Wed, 2015-09-09 at 18:03 +0100, Wei Liu wrote:
> > > > ... otherwise we have something like:
> > > > 
> > > > xl: libxl_create.c:968: initiate_domain_create: Assertion `ret' failed.
> > > > 
> > > > Signed-off-by: Wei Liu 
> > > 
> > > Acked-by: Ian Campbell 
> > 
> > APplied to dev and 4.6.
> 
> Queued for backport to 4.5 and earlier.
> 

This is not applicable to 4.5 and earlier so you have one less item to
worry about.

Wei.

> Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for 4.6 v2 1/3] libxl: set ret to non-zero value in failure path

[Ian Jackson]

Ian Campbell writes ("Re: [Xen-devel] [PATCH for 4.6 v2 1/3] libxl: set ret to 
non-zero value in failure path"):
> On Thu, 2015-09-10 at 11:55 +0100, Ian Campbell wrote:
> > On Wed, 2015-09-09 at 18:03 +0100, Wei Liu wrote:
> > > ... otherwise we have something like:
> > > 
> > > xl: libxl_create.c:968: initiate_domain_create: Assertion `ret' failed.
> > > 
> > > Signed-off-by: Wei Liu 
> > 
> > Acked-by: Ian Campbell 
> 
> APplied to dev and 4.6.

Queued for backport to 4.5 and earlier.

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for 4.6 v2 1/3] libxl: set ret to non-zero value in failure path

[Ian Jackson]

Wei Liu writes ("Re: [Xen-devel] [PATCH for 4.6 v2 1/3] libxl: set ret to 
non-zero value in failure path"):
> This is not applicable to 4.5 and earlier so you have one less item to
> worry about.

Thanks.  I would have discovered that when I tried to backport it but
you have saved me the effort of digging in a week or two's time :-).

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for 4.6 v2 1/3] libxl: set ret to non-zero value in failure path

[Ian Campbell]

On Wed, 2015-09-09 at 18:03 +0100, Wei Liu wrote:
> ... otherwise we have something like:
> 
> xl: libxl_create.c:968: initiate_domain_create: Assertion `ret' failed.
> 
> Signed-off-by: Wei Liu 

Acked-by: Ian Campbell 


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for 4.6 v2 1/3] libxl: set ret to non-zero value in failure path

[Ian Campbell]

On Thu, 2015-09-10 at 11:55 +0100, Ian Campbell wrote:
> On Wed, 2015-09-09 at 18:03 +0100, Wei Liu wrote:
> > ... otherwise we have something like:
> > 
> > xl: libxl_create.c:968: initiate_domain_create: Assertion `ret' failed.
> > 
> > Signed-off-by: Wei Liu 
> 
> Acked-by: Ian Campbell 

APplied to dev and 4.6.


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] [PATCH for 4.6 v2 1/3] libxl: set ret to non-zero value in failure path

[Wei Liu]

... otherwise we have something like:

xl: libxl_create.c:968: initiate_domain_create: Assertion `ret' failed.

Signed-off-by: Wei Liu 
---
 tools/libxl/libxl_create.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index 5128160..29c2641 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -865,6 +865,7 @@ static void initiate_domain_create(libxl__egc *egc,
  */
 if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_PV &&
 d_config->b_info.num_vnuma_nodes) {
+ret = ERROR_INVAL;
 LOG(ERROR, "PV vNUMA is not yet supported");
 goto error_out;
 }
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel