Re: [Xen-devel] [PATCH v12 33/33] sg-run-job: hook the memdisk test into examine

2017-10-20 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v12 33/33] sg-run-job: hook the memdisk test 
into examine"):
> Hook the memdisk parameter detection and the saving of the host
> properties into the examine jobs.
> 
> Signed-off-by: Roger Pau Monné 
> ---
> Changes since v2:
>  - Do not pass a host ident to ts-examine-hostprops-save.
>  - Use .- for ts-memdisk-try-append so that the rest of the job will
>run even if this step fails.

Acked-by: Ian Jackson 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel


[Xen-devel] [PATCH v12 33/33] sg-run-job: hook the memdisk test into examine

2017-10-20 Thread Roger Pau Monne
Hook the memdisk parameter detection and the saving of the host
properties into the examine jobs.

Signed-off-by: Roger Pau Monné 
---
Changes since v2:
 - Do not pass a host ident to ts-examine-hostprops-save.
 - Use .- for ts-memdisk-try-append so that the rest of the job will
   run even if this step fails.

Changes since v1:
 - Run the memdisk test first (so that we don't leave the host in a
   weird state).
 - Pass a host to the examine-hostprops-save.
---
 sg-run-job | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sg-run-job b/sg-run-job
index ed1ed3c8..de6e3f76 100755
--- a/sg-run-job
+++ b/sg-run-job
@@ -655,6 +655,7 @@ proc examine-host-install-xen {} {
 proc examine-host-examine {install} {
 global ok
 catching-otherwise fail {
+   run-ts -.  =ts-memdisk-try-append + host
examine-host-install-$install
run-ts .   =ts-examine-serial-pre + host
run-ts .   reboot   ts-host-reboot+ host
@@ -663,6 +664,7 @@ proc examine-host-examine {install} {
 if {$ok} {
run-ts -.  =   ts-examine-serial-post + host
run-ts .   =   ts-examine-logs-save   + host
+   run-ts .   =   ts-examine-hostprops-save
 }
 }
 
-- 
2.13.5 (Apple Git-94)


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel