Re: [Xen-devel] [PATCH v2 00/16] Scheduling related tracing improvements

2016-03-07 Thread Konrad Rzeszutek Wilk 
On Mon, Mar 07, 2016 at 03:21:46PM +0100, Dario Faggioli wrote:
> On Mon, 2016-03-07 at 11:27 +, Wei Liu wrote:
> > On Mon, Mar 07, 2016 at 04:21:22AM -0700, Jan Beulich wrote:
> > > > > > On 07.03.16 at 11:54,  wrote:
> > > > 
> > > Well, if these were urgent I'd say yes. But I don't think they are,
> > > so I'd leave it to either Konrad (who has basically asked for what
> > > you offer) if he wants to deal with it, of wait for Ian's return.
> > > 
> > It's not urgent, but I would like to avoid wasting any test cycle. No
> > matter how innocent a patch looks, there is always risk that it
> > breaks
> > something.
> > 
> > Konrad, your call.
> > 
> In any case, and as far as these patches are concerned, here it is:
> 
>  git://xenbits.xen.org/people/dariof/xen.git  
> tracing/sched-events-improvements
> 
>  
> http://xenbits.xen.org/gitweb/?p=people/dariof/xen.git;a=shortlog;h=refs/heads/tracing/sched-events-improvements

Let me put them in staging.
> 
> Thanks and Regards,
> Dario
> -- 
> <> (Raistlin Majere)
> -
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R Ltd., Cambridge (UK)
> 



___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 00/16] Scheduling related tracing improvements

2016-03-07 Thread Dario Faggioli 
On Mon, 2016-03-07 at 11:27 +, Wei Liu wrote:
> On Mon, Mar 07, 2016 at 04:21:22AM -0700, Jan Beulich wrote:
> > > > > On 07.03.16 at 11:54,  wrote:
> > > 
> > Well, if these were urgent I'd say yes. But I don't think they are,
> > so I'd leave it to either Konrad (who has basically asked for what
> > you offer) if he wants to deal with it, of wait for Ian's return.
> > 
> It's not urgent, but I would like to avoid wasting any test cycle. No
> matter how innocent a patch looks, there is always risk that it
> breaks
> something.
> 
> Konrad, your call.
> 
In any case, and as far as these patches are concerned, here it is:

 git://xenbits.xen.org/people/dariof/xen.git  tracing/sched-events-improvements

 
http://xenbits.xen.org/gitweb/?p=people/dariof/xen.git;a=shortlog;h=refs/heads/tracing/sched-events-improvements

Thanks and Regards,
Dario
-- 
<> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R Ltd., Cambridge (UK)



signature.asc
Description: This is a digitally signed message part
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 00/16] Scheduling related tracing improvements

2016-03-07 Thread Wei Liu 
On Mon, Mar 07, 2016 at 04:21:22AM -0700, Jan Beulich wrote:
> >>> On 07.03.16 at 11:54,  wrote:
> > On Mon, Mar 07, 2016 at 03:50:20AM -0700, Jan Beulich wrote:
> >> >>> On 04.03.16 at 19:25,  wrote:
> >> > Hello committers, George,
> >> > 
> >> > This is basically a ping for this series, as I think most of it can
> >> > actually go in, unless I've missed something.
> >> > 
> >> > So, let me try to recap:
> >> > 
> >> > On Tue, 2016-02-16 at 19:11 +0100, Dario Faggioli wrote:
> >> >> 
> >> >> Dario Faggioli (16):
> >> >>   xen: sched: __runq_tickle takes a useless cpu parameter
> >> >>   xen: sched: move up the trace record for vcpu_wake and
> >> >> vcpu_sleep
> >> >>   xen: sched: improve domain creation tracing
> >> >>   xen: credit2: pack trace data better for xentrace_format
> >> >>   xen: RTDS: pack trace data better for xentrace_format
> >> >>   xen: sched: tracing: enable TSC tracing for all events
> >> >>
> >> > Until here, it's in already.
> >> 
> >> And that's the part I could reasonably take care of. I generally avoid
> >> committing larger chunks of tools/ stuff, with the expectation that
> >> Ian would take deal with those.
> >> 
> > 
> > Ian is away this week. To avoid having no tools stuff committed this
> > whole week, I can prepare a branch for you to pull if you think that's
> > OK.
> 
> Well, if these were urgent I'd say yes. But I don't think they are,
> so I'd leave it to either Konrad (who has basically asked for what
> you offer) if he wants to deal with it, of wait for Ian's return.
> 

It's not urgent, but I would like to avoid wasting any test cycle. No
matter how innocent a patch looks, there is always risk that it breaks
something.

Konrad, your call.

Wei.

> Jan
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 00/16] Scheduling related tracing improvements

2016-03-07 Thread Jan Beulich 
>>> On 07.03.16 at 11:54,  wrote:
> On Mon, Mar 07, 2016 at 03:50:20AM -0700, Jan Beulich wrote:
>> >>> On 04.03.16 at 19:25,  wrote:
>> > Hello committers, George,
>> > 
>> > This is basically a ping for this series, as I think most of it can
>> > actually go in, unless I've missed something.
>> > 
>> > So, let me try to recap:
>> > 
>> > On Tue, 2016-02-16 at 19:11 +0100, Dario Faggioli wrote:
>> >> 
>> >> Dario Faggioli (16):
>> >>   xen: sched: __runq_tickle takes a useless cpu parameter
>> >>   xen: sched: move up the trace record for vcpu_wake and
>> >> vcpu_sleep
>> >>   xen: sched: improve domain creation tracing
>> >>   xen: credit2: pack trace data better for xentrace_format
>> >>   xen: RTDS: pack trace data better for xentrace_format
>> >>   xen: sched: tracing: enable TSC tracing for all events
>> >>
>> > Until here, it's in already.
>> 
>> And that's the part I could reasonably take care of. I generally avoid
>> committing larger chunks of tools/ stuff, with the expectation that
>> Ian would take deal with those.
>> 
> 
> Ian is away this week. To avoid having no tools stuff committed this
> whole week, I can prepare a branch for you to pull if you think that's
> OK.

Well, if these were urgent I'd say yes. But I don't think they are,
so I'd leave it to either Konrad (who has basically asked for what
you offer) if he wants to deal with it, of wait for Ian's return.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 00/16] Scheduling related tracing improvements

2016-03-07 Thread Wei Liu 
On Mon, Mar 07, 2016 at 03:50:20AM -0700, Jan Beulich wrote:
> >>> On 04.03.16 at 19:25,  wrote:
> > Hello committers, George,
> > 
> > This is basically a ping for this series, as I think most of it can
> > actually go in, unless I've missed something.
> > 
> > So, let me try to recap:
> > 
> > On Tue, 2016-02-16 at 19:11 +0100, Dario Faggioli wrote:
> >> 
> >> Dario Faggioli (16):
> >>   xen: sched: __runq_tickle takes a useless cpu parameter
> >>   xen: sched: move up the trace record for vcpu_wake and
> >> vcpu_sleep
> >>   xen: sched: improve domain creation tracing
> >>   xen: credit2: pack trace data better for xentrace_format
> >>   xen: RTDS: pack trace data better for xentrace_format
> >>   xen: sched: tracing: enable TSC tracing for all events
> >>
> > Until here, it's in already.
> 
> And that's the part I could reasonably take care of. I generally avoid
> committing larger chunks of tools/ stuff, with the expectation that
> Ian would take deal with those.
> 

Ian is away this week. To avoid having no tools stuff committed this
whole week, I can prepare a branch for you to pull if you think that's
OK.

Wei.

> Jan
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 00/16] Scheduling related tracing improvements

2016-03-07 Thread Jan Beulich 
>>> On 04.03.16 at 19:25,  wrote:
> Hello committers, George,
> 
> This is basically a ping for this series, as I think most of it can
> actually go in, unless I've missed something.
> 
> So, let me try to recap:
> 
> On Tue, 2016-02-16 at 19:11 +0100, Dario Faggioli wrote:
>> 
>> Dario Faggioli (16):
>>   xen: sched: __runq_tickle takes a useless cpu parameter
>>   xen: sched: move up the trace record for vcpu_wake and
>> vcpu_sleep
>>   xen: sched: improve domain creation tracing
>>   xen: credit2: pack trace data better for xentrace_format
>>   xen: RTDS: pack trace data better for xentrace_format
>>   xen: sched: tracing: enable TSC tracing for all events
>>
> Until here, it's in already.

And that's the part I could reasonably take care of. I generally avoid
committing larger chunks of tools/ stuff, with the expectation that
Ian would take deal with those.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 00/16] Scheduling related tracing improvements

2016-03-04 Thread Konrad Rzeszutek Wilk 
On Fri, Mar 04, 2016 at 07:25:30PM +0100, Dario Faggioli wrote:
> Hello committers, George,
> 
> This is basically a ping for this series, as I think most of it can
> actually go in, unless I've missed something.
> 
> So, let me try to recap:
> 
> On Tue, 2016-02-16 at 19:11 +0100, Dario Faggioli wrote:
> > 
> > Dario Faggioli (16):
> >   xen: sched: __runq_tickle takes a useless cpu parameter
> >   xen: sched: move up the trace record for vcpu_wake and
> > vcpu_sleep
> >   xen: sched: improve domain creation tracing
> >   xen: credit2: pack trace data better for xentrace_format
> >   xen: RTDS: pack trace data better for xentrace_format
> >   xen: sched: tracing: enable TSC tracing for all events
> >
> Until here, it's in already.
> 
> >   xentrace: formats: update format of scheduling events
> >   xentrace: formats: add events from Credit scheduler
> >   xentrace: formats: add events from Credit2 scheduler
> >   xentrace: formats: add events from RTDS scheduler
> >   xentrace: formats: add domain create and destroy events.
> >
> About these, they've got Konrad's Reviewed-by, and George said:
> 
> "I haven't reviewed the formats file changes, but all of them look
> reasonable; so for patches 7-11:
> Acked-by: George Dunlap "
> 
> >   xenalyze: handle scheduling events
> >
> Reviewed-by: Konrad Rzeszutek Wilk 
> Acked-by: George Dunlap 
> 
> >   xenalyze: handle Credit1 scheduler events
> >
> Reviewed-by: Konrad Rzeszutek Wilk 
> Acked-by: George Dunlap 
> 
> >   xenalyze: handle Credit2 scheduler events
> >
> Reviewed-by: Konrad Rzeszutek Wilk 
> Acked-by: George Dunlap 
> 
> >   xenalyze: handle RTDS scheduler events
> >
> This should be skipped. In fact, we agreed with George that the plan
> would be:
> 
> "I think most of these patches can be checked in now.  What about
> checking in the other patches, then sending a follow-up series with the
> struct changed in the scheduler, and then this patch with the resulting
> changes?"
> 
> So, just ignore this patch.
> 
> >   xenalyze: handle DOM0 operaions events
> > 
> This one is actually missing Georges's Ack.
> 
> I'd be fine with this being skipped as well, and I will resubmit as
> separate patch, or as part of the followup series mentioned above.
> 
> Or George can Ack it, and it just can go in now.
> 
> But this is not a big deal.
> 
> What I would like, if possible, is for patches until 14 to be checked
> in, so I can submit the follow up (together with other patches that I
> have stacked on top of that).

Could you put them in a git tree please?

> 
> Thanks and regards,
> Dario
> -- 
> <> (Raistlin Majere)
> -
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R Ltd., Cambridge (UK)
> 



___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 00/16] Scheduling related tracing improvements

2016-03-04 Thread Dario Faggioli 
Hello committers, George,

This is basically a ping for this series, as I think most of it can
actually go in, unless I've missed something.

So, let me try to recap:

On Tue, 2016-02-16 at 19:11 +0100, Dario Faggioli wrote:
> 
> Dario Faggioli (16):
>   xen: sched: __runq_tickle takes a useless cpu parameter
>   xen: sched: move up the trace record for vcpu_wake and
> vcpu_sleep
>   xen: sched: improve domain creation tracing
>   xen: credit2: pack trace data better for xentrace_format
>   xen: RTDS: pack trace data better for xentrace_format
>   xen: sched: tracing: enable TSC tracing for all events
>
Until here, it's in already.

>   xentrace: formats: update format of scheduling events
>   xentrace: formats: add events from Credit scheduler
>   xentrace: formats: add events from Credit2 scheduler
>   xentrace: formats: add events from RTDS scheduler
>   xentrace: formats: add domain create and destroy events.
>
About these, they've got Konrad's Reviewed-by, and George said:

"I haven't reviewed the formats file changes, but all of them look
reasonable; so for patches 7-11:
Acked-by: George Dunlap "

>   xenalyze: handle scheduling events
>
Reviewed-by: Konrad Rzeszutek Wilk 
Acked-by: George Dunlap 

>   xenalyze: handle Credit1 scheduler events
>
Reviewed-by: Konrad Rzeszutek Wilk 
Acked-by: George Dunlap 

>   xenalyze: handle Credit2 scheduler events
>
Reviewed-by: Konrad Rzeszutek Wilk 
Acked-by: George Dunlap 

>   xenalyze: handle RTDS scheduler events
>
This should be skipped. In fact, we agreed with George that the plan
would be:

"I think most of these patches can be checked in now.  What about
checking in the other patches, then sending a follow-up series with the
struct changed in the scheduler, and then this patch with the resulting
changes?"

So, just ignore this patch.

>   xenalyze: handle DOM0 operaions events
> 
This one is actually missing Georges's Ack.

I'd be fine with this being skipped as well, and I will resubmit as
separate patch, or as part of the followup series mentioned above.

Or George can Ack it, and it just can go in now.

But this is not a big deal.

What I would like, if possible, is for patches until 14 to be checked
in, so I can submit the follow up (together with other patches that I
have stacked on top of that).

Thanks and regards,
Dario
-- 
<> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R Ltd., Cambridge (UK)



signature.asc
Description: This is a digitally signed message part
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] [PATCH v2 00/16] Scheduling related tracing improvements

2016-02-16 Thread Dario Faggioli 
Hi,

Take 2 of this series. v1 is here:

 http://lists.xenproject.org/archives/html/xen-devel/2016-02/msg01016.html

Konrad's feedback taken into acount, which basically meant modifying a little
bit patch 3 ("xen: sched: improve domain creation tracing"), and adding two
simple patches to xentrace formats file, and to xenalyze (patch 11 and 16).

Thanks and Regards,
Dario
---
Dario Faggioli (16):
  xen: sched: __runq_tickle takes a useless cpu parameter
  xen: sched: move up the trace record for vcpu_wake and vcpu_sleep
  xen: sched: improve domain creation tracing
  xen: credit2: pack trace data better for xentrace_format
  xen: RTDS: pack trace data better for xentrace_format
  xen: sched: tracing: enable TSC tracing for all events
  xentrace: formats: update format of scheduling events
  xentrace: formats: add events from Credit scheduler
  xentrace: formats: add events from Credit2 scheduler
  xentrace: formats: add events from RTDS scheduler
  xentrace: formats: add domain create and destroy events.
  xenalyze: handle scheduling events
  xenalyze: handle Credit1 scheduler events
  xenalyze: handle Credit2 scheduler events
  xenalyze: handle RTDS scheduler events
  xenalyze: handle DOM0 operaions events

 tools/xentrace/formats |   47 -
 tools/xentrace/xenalyze.c  |  399 +---
 xen/common/domain.c|5 -
 xen/common/sched_credit.c  |   12 +
 xen/common/sched_credit2.c |   22 +-
 xen/common/sched_rt.c  |   29 +--
 xen/common/schedule.c  |   20 +-
 xen/include/public/trace.h |6 +
 8 files changed, 450 insertions(+), 90 deletions(-)
--
<> (Raistlin Majere)
-
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R Ltd., Cambridge (UK)

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel