Re: [Xen-devel] [PATCH v2 7/7] xen/arm: platform: Drop the quirks callback

2015-10-01 Thread Ian Campbell
On Tue, 2015-09-29 at 17:55 +0100, Julien Grall wrote:
> On 29/09/15 17:21, Julien Grall wrote:
> > All the quirks has been replaced by proper detection. Lets drop the
> > callback and hope that no one will need new quirks.
> > 
> > At the same time, remove the definition platform_dom0_evtchn_ppi with
> > is
> > not used any more.
> > 
> > Signed-off-by: Julien Grall 
> > Acked-by: Ian Campbell 
> 
> I made a typo while writing the acked-by. It should campbell and not
> campebll.

I'm terribly offended! Not really...

> I will resend a new version if necessary.

No need.


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


Re: [Xen-devel] [PATCH v2 7/7] xen/arm: platform: Drop the quirks callback

2015-09-29 Thread Julien Grall
On 29/09/15 17:21, Julien Grall wrote:
> All the quirks has been replaced by proper detection. Lets drop the
> callback and hope that no one will need new quirks.
> 
> At the same time, remove the definition platform_dom0_evtchn_ppi with is
> not used any more.
> 
> Signed-off-by: Julien Grall 
> Acked-by: Ian Campbell 

I made a typo while writing the acked-by. It should campbell and not
campebll.

I will resend a new version if necessary.

Regards,

-- 
Julien Grall

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel


[Xen-devel] [PATCH v2 7/7] xen/arm: platform: Drop the quirks callback

2015-09-29 Thread Julien Grall
All the quirks has been replaced by proper detection. Lets drop the
callback and hope that no one will need new quirks.

At the same time, remove the definition platform_dom0_evtchn_ppi with is
not used any more.

Signed-off-by: Julien Grall 
Acked-by: Ian Campbell 

---
Changes in v2:
- Add Ian's acked-by
---
 xen/arch/arm/platform.c| 10 --
 xen/include/asm-arm/platform.h |  8 
 2 files changed, 18 deletions(-)

diff --git a/xen/arch/arm/platform.c b/xen/arch/arm/platform.c
index 0af6d57..b0bfaa9 100644
--- a/xen/arch/arm/platform.c
+++ b/xen/arch/arm/platform.c
@@ -127,16 +127,6 @@ void platform_poweroff(void)
 platform->poweroff();
 }
 
-bool_t platform_has_quirk(uint32_t quirk)
-{
-uint32_t quirks = 0;
-
-if ( platform && platform->quirks )
-quirks = platform->quirks();
-
-return !!(quirks & quirk);
-}
-
 bool_t platform_device_is_blacklisted(const struct dt_device_node *node)
 {
 const struct dt_device_match *blacklist = NULL;
diff --git a/xen/include/asm-arm/platform.h b/xen/include/asm-arm/platform.h
index 5e462ac..f97315d 100644
--- a/xen/include/asm-arm/platform.h
+++ b/xen/include/asm-arm/platform.h
@@ -27,12 +27,6 @@ struct platform_desc {
 /* Platform power-off */
 void (*poweroff)(void);
 /*
- * Platform quirks
- * Defined has a function because a platform can support multiple
- * board with different quirk on each
- */
-uint32_t (*quirks)(void);
-/*
  * Platform blacklist devices
  * List of devices which must not pass-through to a guest
  */
@@ -48,9 +42,7 @@ int platform_cpu_up(int cpu);
 #endif
 void platform_reset(void);
 void platform_poweroff(void);
-bool_t platform_has_quirk(uint32_t quirk);
 bool_t platform_device_is_blacklisted(const struct dt_device_node *node);
-unsigned int platform_dom0_evtchn_ppi(void);
 
 #define PLATFORM_START(_name, _namestr) \
 static const struct platform_desc  __plat_desc_##_name __used   \
-- 
2.1.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel