Re: [Xen-devel] [PATCH v3 00/17] Xen ARM DomU ACPI support
On 2016年07月05日 18:32, Julien Grall wrote: > On 05/07/16 04:12, Shannon Zhao wrote: >> From: Shannon Zhao>> >> Note: while there are still two points (user configuration name and >> where to load the ACPI blob) which we don't reach an agreement and need >> other maintainer's opinions, but I'd like to send the updated series out >> since we could move forward and once we reach an agreement I can make >> changes. > > It would have been nice to summarize the problems in the concerned > patches to avoid having looking through all the patches in the > previous version understanding what are the disagreements. Note that > as the contributor of this series, I would expect you to drive the > discussion (e.g gentle ping...). > Actually I notice Stefano and Wei are not active recently, so I thought they are on holidays(or doing other things). So currently ping is useless. Once they come back and if they don't reply I'll ping them. > You also did not address my concern related to require iasl even on > platform when ACPI will not be used (such as arm32). Oh, sorry, will address at next version. Thanks, -- Shannon ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v3 00/17] Xen ARM DomU ACPI support
Hi Shannon, On 05/07/16 04:12, Shannon Zhao wrote: From: Shannon ZhaoNote: while there are still two points (user configuration name and where to load the ACPI blob) which we don't reach an agreement and need other maintainer's opinions, but I'd like to send the updated series out since we could move forward and once we reach an agreement I can make changes. It would have been nice to summarize the problems in the concerned patches to avoid having looking through all the patches in the previous version understanding what are the disagreements. Note that as the contributor of this series, I would expect you to drive the discussion (e.g gentle ping...). You also did not address my concern related to require iasl even on platform when ACPI will not be used (such as arm32). This series can be fetched from: https://git.linaro.org/people/shannon.zhao/xen.git domu_acpi_v3 It would have been nice to specify the dependencies and mention that Boris's series has not yet been sent to the ML. Changes since v2: * return error for 32bit domain with acpi enabled * include actypes.h to reuse the definitions * rename libxl_arm_acpi.h to libxl_arm.h * use ACPI_MADT_ENABLED * rebased on top of Boris's ACPI branch to reuse mk_dsdt.c Changes since v1: * move ACPI tables generation codes to a new file * use static asl file to generate DSDT table and include processor device objects * assign a non-RAM map for ACPI blob * use existing ACPI table definitions under xen/include/acpi/ * add a configuration for user to enable/disable ACPI generation * calculate the ACPI table checksum Shannon Zhao (17): libxl/arm: Factor out codes for generating DTB libxc: Add placeholders for ACPI tables blob and size libxl/arm: Add a configuration option for ARM DomU ACPI libxl/arm: prepare for constructing ACPI tables libxl/arm: Generate static ACPI DSDT table libxl/arm: Estimate the size of ACPI tables libxl/arm: Construct ACPI RSDP table libxl/arm: Construct ACPI XSDT table libxl/arm: Construct ACPI GTDT table libxl/arm: Factor MPIDR computing codes out as a helper libxl/arm: Construct ACPI MADT table libxl/arm: Construct ACPI FADT table libxl/arm: Construct ACPI DSDT table libxl/arm: Factor finalise_one_memory_node as a gerneric function libxl/arm: Add ACPI module libxc/xc_dom_core: Copy ACPI tables to guest space libxl/arm: Initialize domain param HVM_PARAM_CALLBACK_IRQ docs/misc/arm/device-tree/acpi.txt | 24 +++ tools/libacpi/Makefile | 15 +- tools/libacpi/mk_dsdt.c| 51 -- tools/libxc/include/xc_dom.h | 2 + tools/libxc/xc_dom_core.c | 51 ++ tools/libxl/Makefile | 7 + tools/libxl/libxl.h| 5 + tools/libxl/libxl_arm.c| 86 +++-- tools/libxl/libxl_arm.h| 44 + tools/libxl/libxl_arm_acpi.c | 354 + tools/libxl/libxl_types.idl| 1 + tools/libxl/xl_cmdimpl.c | 4 + xen/include/public/arch-arm.h | 7 + 13 files changed, 620 insertions(+), 31 deletions(-) create mode 100644 docs/misc/arm/device-tree/acpi.txt create mode 100644 tools/libxl/libxl_arm.h create mode 100644 tools/libxl/libxl_arm_acpi.c -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
[Xen-devel] [PATCH v3 00/17] Xen ARM DomU ACPI support
From: Shannon ZhaoNote: while there are still two points (user configuration name and where to load the ACPI blob) which we don't reach an agreement and need other maintainer's opinions, but I'd like to send the updated series out since we could move forward and once we reach an agreement I can make changes. The design of this feature is described as below. Firstly, the toolstack (libxl) generates the ACPI tables according the number of vcpus and gic controller. Then, it copies these ACPI tables to DomU non-RAM memory map space and passes them to UEFI firmware through the "ARM multiboot" protocol. At last, UEFI gets the ACPI tables through the "ARM multiboot" protocol and installs these tables like the usual way and passes both ACPI and DT information to the Xen DomU. Currently libxl only generates RSDP, XSDT, GTDT, MADT, FADT, DSDT tables since it's enough now. This has been tested using guest kernel with the Dom0 ACPI support patches which could be fetched from: https://git.kernel.org/cgit/linux/kernel/git/mfleming/efi.git/log/?h=efi/arm-xen The UEFI binary could be fetched from or built from edk2 master branch: http://people.linaro.org/~shannon.zhao/DomU_ACPI/XEN_EFI.fd This series can be fetched from: https://git.linaro.org/people/shannon.zhao/xen.git domu_acpi_v3 Changes since v2: * return error for 32bit domain with acpi enabled * include actypes.h to reuse the definitions * rename libxl_arm_acpi.h to libxl_arm.h * use ACPI_MADT_ENABLED * rebased on top of Boris's ACPI branch to reuse mk_dsdt.c Changes since v1: * move ACPI tables generation codes to a new file * use static asl file to generate DSDT table and include processor device objects * assign a non-RAM map for ACPI blob * use existing ACPI table definitions under xen/include/acpi/ * add a configuration for user to enable/disable ACPI generation * calculate the ACPI table checksum Shannon Zhao (17): libxl/arm: Factor out codes for generating DTB libxc: Add placeholders for ACPI tables blob and size libxl/arm: Add a configuration option for ARM DomU ACPI libxl/arm: prepare for constructing ACPI tables libxl/arm: Generate static ACPI DSDT table libxl/arm: Estimate the size of ACPI tables libxl/arm: Construct ACPI RSDP table libxl/arm: Construct ACPI XSDT table libxl/arm: Construct ACPI GTDT table libxl/arm: Factor MPIDR computing codes out as a helper libxl/arm: Construct ACPI MADT table libxl/arm: Construct ACPI FADT table libxl/arm: Construct ACPI DSDT table libxl/arm: Factor finalise_one_memory_node as a gerneric function libxl/arm: Add ACPI module libxc/xc_dom_core: Copy ACPI tables to guest space libxl/arm: Initialize domain param HVM_PARAM_CALLBACK_IRQ docs/misc/arm/device-tree/acpi.txt | 24 +++ tools/libacpi/Makefile | 15 +- tools/libacpi/mk_dsdt.c| 51 -- tools/libxc/include/xc_dom.h | 2 + tools/libxc/xc_dom_core.c | 51 ++ tools/libxl/Makefile | 7 + tools/libxl/libxl.h| 5 + tools/libxl/libxl_arm.c| 86 +++-- tools/libxl/libxl_arm.h| 44 + tools/libxl/libxl_arm_acpi.c | 354 + tools/libxl/libxl_types.idl| 1 + tools/libxl/xl_cmdimpl.c | 4 + xen/include/public/arch-arm.h | 7 + 13 files changed, 620 insertions(+), 31 deletions(-) create mode 100644 docs/misc/arm/device-tree/acpi.txt create mode 100644 tools/libxl/libxl_arm.h create mode 100644 tools/libxl/libxl_arm_acpi.c -- 2.0.4 ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel