Re: [Xen-devel] [PATCH v3 6/9] x86/vmce, tools/libxl: expose LMCE capability in guest MSR_IA32_MCG_CAP

2017-03-30 Thread Wei Liu 
On Thu, Mar 30, 2017 at 08:57:05AM -0600, Jan Beulich wrote:
> >>> On 30.03.17 at 08:20,  wrote:
> > If LMCE is supported by host and ' mca_caps = [ "lmce" ] ' is present
> > in xl config, the LMCE capability will be exposed in guest MSR_IA32_MCG_CAP.
> > By default, LMCE is not exposed to guest so as to keep the backwards 
> > migration
> > compatibility.
> > 
> > Signed-off-by: Haozhong Zhang 
> 
> Hypervisor side
> Reviewed-by: Jan Beulich 
> 
> For the tools side, doesn't the new HVM param need saving /
> restoring? If so an addition to the array in
> tools/libxc/xc_sr_save_x86_hvm.c:write_hvm_params() is going
> to be needed.
> 

Actually quite a few of HVM params are missing.  It works because libxl
actually sets them, I think.

Haozhong, the best way to check is to `xl migrate guest localhost`.

Wei.

> Jan
> 

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v3 6/9] x86/vmce, tools/libxl: expose LMCE capability in guest MSR_IA32_MCG_CAP

2017-03-30 Thread Jan Beulich 
>>> On 30.03.17 at 08:20,  wrote:
> If LMCE is supported by host and ' mca_caps = [ "lmce" ] ' is present
> in xl config, the LMCE capability will be exposed in guest MSR_IA32_MCG_CAP.
> By default, LMCE is not exposed to guest so as to keep the backwards migration
> compatibility.
> 
> Signed-off-by: Haozhong Zhang 

Hypervisor side
Reviewed-by: Jan Beulich 

For the tools side, doesn't the new HVM param need saving /
restoring? If so an addition to the array in
tools/libxc/xc_sr_save_x86_hvm.c:write_hvm_params() is going
to be needed.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v3 6/9] x86/vmce, tools/libxl: expose LMCE capability in guest MSR_IA32_MCG_CAP

2017-03-30 Thread Haozhong Zhang 
If LMCE is supported by host and ' mca_caps = [ "lmce" ] ' is present
in xl config, the LMCE capability will be exposed in guest MSR_IA32_MCG_CAP.
By default, LMCE is not exposed to guest so as to keep the backwards migration
compatibility.

Signed-off-by: Haozhong Zhang 
---
Cc: Ian Jackson 
Cc: Wei Liu 
Cc: Jan Beulich 
Cc: Andrew Cooper 

Changes in v3:
 * Rename HVMMCA_CAP_* to XEN_HVM_MCA_CAP_*.
 * Use mk_xen_ullong() to define XEN_HVM_MCA_CAP_LMCE and start from
   bit 0.
 * Make lmce_support non-static in this patch rather than in patch 2.
 * Parse 'mca_caps' in xl.
 * Add LIBXL_HAVE_MCA_CAPS.
---
 docs/man/xl.cfg.pod.5.in| 24 
 tools/libxl/libxl.h |  7 +++
 tools/libxl/libxl_dom.c | 15 +++
 tools/libxl/libxl_types.idl |  1 +
 tools/xl/xl_parse.c | 31 ++--
 xen/arch/x86/cpu/mcheck/mce.h   |  1 +
 xen/arch/x86/cpu/mcheck/mce_intel.c |  2 +-
 xen/arch/x86/cpu/mcheck/vmce.c  | 19 ++-
 xen/arch/x86/hvm/hvm.c  |  5 +
 xen/include/asm-x86/mce.h   |  1 +
 xen/include/public/hvm/params.h |  7 ++-
 11 files changed, 108 insertions(+), 5 deletions(-)

diff --git a/docs/man/xl.cfg.pod.5.in b/docs/man/xl.cfg.pod.5.in
index 991960b..3469970 100644
--- a/docs/man/xl.cfg.pod.5.in
+++ b/docs/man/xl.cfg.pod.5.in
@@ -2023,6 +2023,30 @@ natively or via hardware backwards compatibility support.
 
 =back
 
+=head3 x86
+
+=over 4
+
+=item