Re: [Xen-devel] [PATCH v5 00/29] Xen/ARM guest support
-Original Message- From: xen-devel-boun...@lists.xen.org [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Ard Biesheuvel Sent: Wednesday, February 25, 2015 2:03 AM To: edk2-de...@lists.sourceforge.net; olivier.mar...@arm.com; ler...@redhat.com; roy.fr...@linaro.org; leif.lindh...@linaro.org; stefano.stabell...@eu.citrix.com; ian.campb...@citrix.com; anthony.per...@citrix.com; xen-devel@lists.xen.org; julien.gr...@linaro.org; Justen, Jordan L; Kinney, Michael D Cc: wei.l...@citrix.com; Ard Biesheuvel Subject: [Xen-devel] [PATCH v5 00/29] Xen/ARM guest support This series implements support for executing Tianocore inside a Xen guest domain on 64-bit ARM systems (AArch64) The first part addresses ARM platform specifics, primarily to allow a Tianocore binary image to be runtime relocatable, and execute from DRAM. The second part refactors the XenBus support, and adds some missing device drivers that are needed to execute on ARM: a Xen PV console and a real time clock driver. Finally, patch #29 ties it all together and implements the .dsc and .fdf platform descriptions that can be used to build the binary image. NOTES: - the Xen RTC driver is a dummy implementation, as it is a Runtime driver which is callable through Runtime Services from the OS, and this is currently not supportable under Xen, due to the need to share the shared info page between the OS and the firmware - UEFI maps the entire physical memory space as cached, and relies on Xen to use the correct stage2 mappings for regions that are backed by devices, such as the GIC or device passthrough. The reason is that the I/O console ring and grant table are backed by RAM that Xen maps as cached, which means that UEFI *must* map those as cached as well. Instead of discovering those regions early on (i.e., before enabling the MMU) it is much easier to rely on the architecturally mandated behavior that stage2 device mappings supersede stage1 cached mappings for the same region. - this code is now tested on Ovmf/x86, and no regressions have been reported (thanks Wei Liu) Changes since v4: - rename InterlockedCompareExchange16 () patch as suggested by Jordan, and added his ack - fix a bug spotted by Anthony in the TestAndClearBit () implementation - added more acks and R-b's Changes since v3: - rebased onto Olivier's pending GICv3 patches - moved InterlockedCompareExchange16 () to BaseSynchronizationLib - reimplemented XenBusDxe's TestAndClearBit () using InterlockedCompareExchange16 () so that XenBusDxe itself is now completely architecture agnostic - various minor style and comment changes based on review feedback from Laszlo and Olivier - added acks and R-b's Changes since v2: - rebased onto latest upstream containing Laszlo's ARM generic timer changes, with Olivier's pending GICv3 patches applied on top; - moved the relocatable PrePi to a completely separate module, and dropped patches changing the original ARM PrePi code: all required changes have been incorporated directly into the split off version - dropped the ARM BDS entirely, only Intel BDS supported as of now - added a constructor to XenConsoleSerialPortLib, otherwise there is no output from the release build; - implemented all review comments regarding style and correctness, including cleaning up the DSC in the final patch - added acks and R-b's Changes since v1: - move to PatchableInModule PCDs for the runtime self-relocating PrePi: this is semantically more correct, and will make the build system help us spot if there are remaining instances of FixedPcdGetXX() which need attention - split some prepi and xen patches to make it easier on the reviewers - split off the PCI support from XenBusDxe instead of the frankenstein DXE from v1 - implemented review comments regarding moving of files, splitting of libraries and some EDK2 optimizations suggested by Laszlo (casting, use of specific types etc) - added some acks and R-b's Ard Biesheuvel (29): ArmPkg: allow HYP timer interrupt to be omitted ArmPkg: allow patchable PCDs for memory, FD and FV addresses ArmPlatformPkg: allow patchable PCD for FD base address ArmVirtualizationPkg: add GICv3 detection to VirtFdtDxe ArmVirtualizationPkg: allow patchable PCD for device tree base address ArmVirtualizationPkg: move early UART discovery to PlatformPeim ArmVirtualizationPkg: use a HOB to store device tree blob ArmVirtualizationPkg: add padding to FDT allocation ArmVirtualizationPkg: add a relocatable version of PrePi ArmVirtualizationPkg: implement custom MemoryInitPeiLib ArmVirtualizationPkg: allow patchable PCD for FV and DT base addresses ArmVirtualizationPkg: Xen/PV relocatable platformlib instance MdePkg/BaseSynchronizationLib: Added proper support for ARM architecture MdePkg/BaseSynchronizationLib: Add InterlockedCompareExchange16
Re: [Xen-devel] [PATCH v5 00/29] Xen/ARM guest support
-Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Tuesday, March 03, 2015 3:10 PM To: Wu, Feng Cc: edk2-de...@lists.sourceforge.net; olivier.mar...@arm.com; ler...@redhat.com; roy.fr...@linaro.org; leif.lindh...@linaro.org; stefano.stabell...@eu.citrix.com; ian.campb...@citrix.com; anthony.per...@citrix.com; xen-devel@lists.xen.org; julien.gr...@linaro.org; Justen, Jordan L; Kinney, Michael D; Dong, Eddie; wei.l...@citrix.com Subject: Re: [Xen-devel] [PATCH v5 00/29] Xen/ARM guest support On 3 March 2015 at 03:00, Wu, Feng feng...@intel.com wrote: -Original Message- From: xen-devel-boun...@lists.xen.org [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Ard Biesheuvel Sent: Wednesday, February 25, 2015 2:03 AM To: edk2-de...@lists.sourceforge.net; olivier.mar...@arm.com; ler...@redhat.com; roy.fr...@linaro.org; leif.lindh...@linaro.org; stefano.stabell...@eu.citrix.com; ian.campb...@citrix.com; anthony.per...@citrix.com; xen-devel@lists.xen.org; julien.gr...@linaro.org; Justen, Jordan L; Kinney, Michael D Cc: wei.l...@citrix.com; Ard Biesheuvel Subject: [Xen-devel] [PATCH v5 00/29] Xen/ARM guest support This series implements support for executing Tianocore inside a Xen guest domain on 64-bit ARM systems (AArch64) The first part addresses ARM platform specifics, primarily to allow a Tianocore binary image to be runtime relocatable, and execute from DRAM. The second part refactors the XenBus support, and adds some missing device drivers that are needed to execute on ARM: a Xen PV console and a real time clock driver. Finally, patch #29 ties it all together and implements the .dsc and .fdf platform descriptions that can be used to build the binary image. NOTES: - the Xen RTC driver is a dummy implementation, as it is a Runtime driver which is callable through Runtime Services from the OS, and this is currently not supportable under Xen, due to the need to share the shared info page between the OS and the firmware - UEFI maps the entire physical memory space as cached, and relies on Xen to use the correct stage2 mappings for regions that are backed by devices, such as the GIC or device passthrough. The reason is that the I/O console ring and grant table are backed by RAM that Xen maps as cached, which means that UEFI *must* map those as cached as well. Instead of discovering those regions early on (i.e., before enabling the MMU) it is much easier to rely on the architecturally mandated behavior that stage2 device mappings supersede stage1 cached mappings for the same region. - this code is now tested on Ovmf/x86, and no regressions have been reported (thanks Wei Liu) Changes since v4: - rename InterlockedCompareExchange16 () patch as suggested by Jordan, and added his ack - fix a bug spotted by Anthony in the TestAndClearBit () implementation - added more acks and R-b's Changes since v3: - rebased onto Olivier's pending GICv3 patches - moved InterlockedCompareExchange16 () to BaseSynchronizationLib - reimplemented XenBusDxe's TestAndClearBit () using InterlockedCompareExchange16 () so that XenBusDxe itself is now completely architecture agnostic - various minor style and comment changes based on review feedback from Laszlo and Olivier - added acks and R-b's Changes since v2: - rebased onto latest upstream containing Laszlo's ARM generic timer changes, with Olivier's pending GICv3 patches applied on top; - moved the relocatable PrePi to a completely separate module, and dropped patches changing the original ARM PrePi code: all required changes have been incorporated directly into the split off version - dropped the ARM BDS entirely, only Intel BDS supported as of now - added a constructor to XenConsoleSerialPortLib, otherwise there is no output from the release build; - implemented all review comments regarding style and correctness, including cleaning up the DSC in the final patch - added acks and R-b's Changes since v1: - move to PatchableInModule PCDs for the runtime self-relocating PrePi: this is semantically more correct, and will make the build system help us spot if there are remaining instances of FixedPcdGetXX() which need attention - split some prepi and xen patches to make it easier on the reviewers - split off the PCI support from XenBusDxe instead of the frankenstein DXE from v1 - implemented review comments regarding moving of files, splitting of libraries and some EDK2 optimizations suggested by Laszlo (casting, use of specific types etc) - added some acks and R-b's Ard Biesheuvel (29): ArmPkg: allow HYP timer interrupt to be omitted ArmPkg: allow patchable PCDs for memory, FD and FV addresses ArmPlatformPkg: allow patchable PCD for FD base address
Re: [Xen-devel] [PATCH v5 00/29] Xen/ARM guest support
On 3 March 2015 at 03:00, Wu, Feng feng...@intel.com wrote: -Original Message- From: xen-devel-boun...@lists.xen.org [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Ard Biesheuvel Sent: Wednesday, February 25, 2015 2:03 AM To: edk2-de...@lists.sourceforge.net; olivier.mar...@arm.com; ler...@redhat.com; roy.fr...@linaro.org; leif.lindh...@linaro.org; stefano.stabell...@eu.citrix.com; ian.campb...@citrix.com; anthony.per...@citrix.com; xen-devel@lists.xen.org; julien.gr...@linaro.org; Justen, Jordan L; Kinney, Michael D Cc: wei.l...@citrix.com; Ard Biesheuvel Subject: [Xen-devel] [PATCH v5 00/29] Xen/ARM guest support This series implements support for executing Tianocore inside a Xen guest domain on 64-bit ARM systems (AArch64) The first part addresses ARM platform specifics, primarily to allow a Tianocore binary image to be runtime relocatable, and execute from DRAM. The second part refactors the XenBus support, and adds some missing device drivers that are needed to execute on ARM: a Xen PV console and a real time clock driver. Finally, patch #29 ties it all together and implements the .dsc and .fdf platform descriptions that can be used to build the binary image. NOTES: - the Xen RTC driver is a dummy implementation, as it is a Runtime driver which is callable through Runtime Services from the OS, and this is currently not supportable under Xen, due to the need to share the shared info page between the OS and the firmware - UEFI maps the entire physical memory space as cached, and relies on Xen to use the correct stage2 mappings for regions that are backed by devices, such as the GIC or device passthrough. The reason is that the I/O console ring and grant table are backed by RAM that Xen maps as cached, which means that UEFI *must* map those as cached as well. Instead of discovering those regions early on (i.e., before enabling the MMU) it is much easier to rely on the architecturally mandated behavior that stage2 device mappings supersede stage1 cached mappings for the same region. - this code is now tested on Ovmf/x86, and no regressions have been reported (thanks Wei Liu) Changes since v4: - rename InterlockedCompareExchange16 () patch as suggested by Jordan, and added his ack - fix a bug spotted by Anthony in the TestAndClearBit () implementation - added more acks and R-b's Changes since v3: - rebased onto Olivier's pending GICv3 patches - moved InterlockedCompareExchange16 () to BaseSynchronizationLib - reimplemented XenBusDxe's TestAndClearBit () using InterlockedCompareExchange16 () so that XenBusDxe itself is now completely architecture agnostic - various minor style and comment changes based on review feedback from Laszlo and Olivier - added acks and R-b's Changes since v2: - rebased onto latest upstream containing Laszlo's ARM generic timer changes, with Olivier's pending GICv3 patches applied on top; - moved the relocatable PrePi to a completely separate module, and dropped patches changing the original ARM PrePi code: all required changes have been incorporated directly into the split off version - dropped the ARM BDS entirely, only Intel BDS supported as of now - added a constructor to XenConsoleSerialPortLib, otherwise there is no output from the release build; - implemented all review comments regarding style and correctness, including cleaning up the DSC in the final patch - added acks and R-b's Changes since v1: - move to PatchableInModule PCDs for the runtime self-relocating PrePi: this is semantically more correct, and will make the build system help us spot if there are remaining instances of FixedPcdGetXX() which need attention - split some prepi and xen patches to make it easier on the reviewers - split off the PCI support from XenBusDxe instead of the frankenstein DXE from v1 - implemented review comments regarding moving of files, splitting of libraries and some EDK2 optimizations suggested by Laszlo (casting, use of specific types etc) - added some acks and R-b's Ard Biesheuvel (29): ArmPkg: allow HYP timer interrupt to be omitted ArmPkg: allow patchable PCDs for memory, FD and FV addresses ArmPlatformPkg: allow patchable PCD for FD base address ArmVirtualizationPkg: add GICv3 detection to VirtFdtDxe ArmVirtualizationPkg: allow patchable PCD for device tree base address ArmVirtualizationPkg: move early UART discovery to PlatformPeim ArmVirtualizationPkg: use a HOB to store device tree blob ArmVirtualizationPkg: add padding to FDT allocation ArmVirtualizationPkg: add a relocatable version of PrePi ArmVirtualizationPkg: implement custom MemoryInitPeiLib ArmVirtualizationPkg: allow patchable PCD for FV and DT base addresses ArmVirtualizationPkg: Xen/PV relocatable platformlib instance MdePkg/BaseSynchronizationLib: Added proper support for ARM architecture MdePkg
Re: [Xen-devel] [PATCH v5 00/29] Xen/ARM guest support
On 24 February 2015 at 19:14, Laszlo Ersek ler...@redhat.com wrote: On 02/24/15 20:01, Ard Biesheuvel wrote: On 24 February 2015 at 18:41, Laszlo Ersek ler...@redhat.com wrote: On 02/24/15 19:37, Ard Biesheuvel wrote: On 24 February 2015 at 18:34, Laszlo Ersek ler...@redhat.com wrote: On 02/24/15 19:02, Ard Biesheuvel wrote: Changes since v4: - rename InterlockedCompareExchange16 () patch as suggested by Jordan, and added his ack - fix a bug spotted by Anthony in the TestAndClearBit () implementation - added more acks and R-b's - Are there any patches missing review tags? There is just one patch, #23, which had a bug so I was hoping Anthony would add his R-b to the now fixed version. The InterlockedCompareExchange16() has Jordan's ack, but no reply yet from Michael Kinney. - Who should push this once everything is reviewed? Good question. Are you volunteering? :-) Yes. Kick me when you have a public branch with the final review tags added. Grr. Patch #13 is authored jointly by Olivier and myself, and touches only ARM specific code under MdePkg/ I guess that needs someone else's ack as well? Anyways, the branch is here https://git.linaro.org/people/ard.biesheuvel/uefi-next.git/shortlog/refs/heads/linaro-topic-xen with acks/r-b's on all patches except #13 If Olivier is okay with patch #13, then I don't think that should be a worry. However we should await Michael's feedback for patch #14. Please write him an email directly, with a distinct subject. He should be, he wrote the initial version. The reason he did not ack or r-b it is because he is already in a S-o-b tag Re #14: I sent Michael an email yesterday, to which he responded he was going to review it the same day, which he apparently didn't :-( Anyway, I will wait another day or so for him to respond ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v5 00/29] Xen/ARM guest support
On 24 February 2015 at 18:34, Laszlo Ersek ler...@redhat.com wrote: On 02/24/15 19:02, Ard Biesheuvel wrote: Changes since v4: - rename InterlockedCompareExchange16 () patch as suggested by Jordan, and added his ack - fix a bug spotted by Anthony in the TestAndClearBit () implementation - added more acks and R-b's - Are there any patches missing review tags? There is just one patch, #23, which had a bug so I was hoping Anthony would add his R-b to the now fixed version. The InterlockedCompareExchange16() has Jordan's ack, but no reply yet from Michael Kinney. - Who should push this once everything is reviewed? Good question. Are you volunteering? :-) ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v5 00/29] Xen/ARM guest support
On 02/24/15 19:37, Ard Biesheuvel wrote: On 24 February 2015 at 18:34, Laszlo Ersek ler...@redhat.com wrote: On 02/24/15 19:02, Ard Biesheuvel wrote: Changes since v4: - rename InterlockedCompareExchange16 () patch as suggested by Jordan, and added his ack - fix a bug spotted by Anthony in the TestAndClearBit () implementation - added more acks and R-b's - Are there any patches missing review tags? There is just one patch, #23, which had a bug so I was hoping Anthony would add his R-b to the now fixed version. The InterlockedCompareExchange16() has Jordan's ack, but no reply yet from Michael Kinney. - Who should push this once everything is reviewed? Good question. Are you volunteering? :-) Yes. Kick me when you have a public branch with the final review tags added. Thanks Laszlo ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v5 00/29] Xen/ARM guest support
On 24 February 2015 at 18:41, Laszlo Ersek ler...@redhat.com wrote: On 02/24/15 19:37, Ard Biesheuvel wrote: On 24 February 2015 at 18:34, Laszlo Ersek ler...@redhat.com wrote: On 02/24/15 19:02, Ard Biesheuvel wrote: Changes since v4: - rename InterlockedCompareExchange16 () patch as suggested by Jordan, and added his ack - fix a bug spotted by Anthony in the TestAndClearBit () implementation - added more acks and R-b's - Are there any patches missing review tags? There is just one patch, #23, which had a bug so I was hoping Anthony would add his R-b to the now fixed version. The InterlockedCompareExchange16() has Jordan's ack, but no reply yet from Michael Kinney. - Who should push this once everything is reviewed? Good question. Are you volunteering? :-) Yes. Kick me when you have a public branch with the final review tags added. Grr. Patch #13 is authored jointly by Olivier and myself, and touches only ARM specific code under MdePkg/ I guess that needs someone else's ack as well? Anyways, the branch is here https://git.linaro.org/people/ard.biesheuvel/uefi-next.git/shortlog/refs/heads/linaro-topic-xen with acks/r-b's on all patches except #13 Thanks, Ard. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
[Xen-devel] [PATCH v5 00/29] Xen/ARM guest support
This series implements support for executing Tianocore inside a Xen guest domain on 64-bit ARM systems (AArch64) The first part addresses ARM platform specifics, primarily to allow a Tianocore binary image to be runtime relocatable, and execute from DRAM. The second part refactors the XenBus support, and adds some missing device drivers that are needed to execute on ARM: a Xen PV console and a real time clock driver. Finally, patch #29 ties it all together and implements the .dsc and .fdf platform descriptions that can be used to build the binary image. NOTES: - the Xen RTC driver is a dummy implementation, as it is a Runtime driver which is callable through Runtime Services from the OS, and this is currently not supportable under Xen, due to the need to share the shared info page between the OS and the firmware - UEFI maps the entire physical memory space as cached, and relies on Xen to use the correct stage2 mappings for regions that are backed by devices, such as the GIC or device passthrough. The reason is that the I/O console ring and grant table are backed by RAM that Xen maps as cached, which means that UEFI *must* map those as cached as well. Instead of discovering those regions early on (i.e., before enabling the MMU) it is much easier to rely on the architecturally mandated behavior that stage2 device mappings supersede stage1 cached mappings for the same region. - this code is now tested on Ovmf/x86, and no regressions have been reported (thanks Wei Liu) Changes since v4: - rename InterlockedCompareExchange16 () patch as suggested by Jordan, and added his ack - fix a bug spotted by Anthony in the TestAndClearBit () implementation - added more acks and R-b's Changes since v3: - rebased onto Olivier's pending GICv3 patches - moved InterlockedCompareExchange16 () to BaseSynchronizationLib - reimplemented XenBusDxe's TestAndClearBit () using InterlockedCompareExchange16 () so that XenBusDxe itself is now completely architecture agnostic - various minor style and comment changes based on review feedback from Laszlo and Olivier - added acks and R-b's Changes since v2: - rebased onto latest upstream containing Laszlo's ARM generic timer changes, with Olivier's pending GICv3 patches applied on top; - moved the relocatable PrePi to a completely separate module, and dropped patches changing the original ARM PrePi code: all required changes have been incorporated directly into the split off version - dropped the ARM BDS entirely, only Intel BDS supported as of now - added a constructor to XenConsoleSerialPortLib, otherwise there is no output from the release build; - implemented all review comments regarding style and correctness, including cleaning up the DSC in the final patch - added acks and R-b's Changes since v1: - move to PatchableInModule PCDs for the runtime self-relocating PrePi: this is semantically more correct, and will make the build system help us spot if there are remaining instances of FixedPcdGetXX() which need attention - split some prepi and xen patches to make it easier on the reviewers - split off the PCI support from XenBusDxe instead of the frankenstein DXE from v1 - implemented review comments regarding moving of files, splitting of libraries and some EDK2 optimizations suggested by Laszlo (casting, use of specific types etc) - added some acks and R-b's Ard Biesheuvel (29): ArmPkg: allow HYP timer interrupt to be omitted ArmPkg: allow patchable PCDs for memory, FD and FV addresses ArmPlatformPkg: allow patchable PCD for FD base address ArmVirtualizationPkg: add GICv3 detection to VirtFdtDxe ArmVirtualizationPkg: allow patchable PCD for device tree base address ArmVirtualizationPkg: move early UART discovery to PlatformPeim ArmVirtualizationPkg: use a HOB to store device tree blob ArmVirtualizationPkg: add padding to FDT allocation ArmVirtualizationPkg: add a relocatable version of PrePi ArmVirtualizationPkg: implement custom MemoryInitPeiLib ArmVirtualizationPkg: allow patchable PCD for FV and DT base addresses ArmVirtualizationPkg: Xen/PV relocatable platformlib instance MdePkg/BaseSynchronizationLib: Added proper support for ARM architecture MdePkg/BaseSynchronizationLib: Add InterlockedCompareExchange16 Ovmf/Xen: move Xen interface version to xen.h Ovmf/Xen: fix pointer to int cast in XenBusDxe Ovmf/Xen: refactor XenBusDxe hypercall implementation Ovmf/Xen: move XenBusDxe hypercall code to separate library Ovmf/Xen: introduce XENIO_PROTOCOL Ovmf/Xen: add separate driver for Xen PCI device Ovmf/Xen: move XenBusDxe to abstract XENIO_PROTOCOL Ovmf/Xen: implement XenHypercallLib for ARM Ovmf/Xen: port XenBusDxe to other architectures Ovmf/Xen: add Xen PV console SerialPortLib driver ArmVirtualizationPkg: implement dummy RealTimeClockLib for Xen Ovfm/Xen: add a Vendor Hardware device path GUID for the XenBus root ArmVirtualizationPkg: add XenIoMmioLib
Re: [Xen-devel] [PATCH v5 00/29] Xen/ARM guest support
On 02/24/15 19:02, Ard Biesheuvel wrote: Changes since v4: - rename InterlockedCompareExchange16 () patch as suggested by Jordan, and added his ack - fix a bug spotted by Anthony in the TestAndClearBit () implementation - added more acks and R-b's - Are there any patches missing review tags? - Who should push this once everything is reviewed? Thanks Laszlo ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v5 00/29] Xen/ARM guest support
On 02/24/15 20:01, Ard Biesheuvel wrote: On 24 February 2015 at 18:41, Laszlo Ersek ler...@redhat.com wrote: On 02/24/15 19:37, Ard Biesheuvel wrote: On 24 February 2015 at 18:34, Laszlo Ersek ler...@redhat.com wrote: On 02/24/15 19:02, Ard Biesheuvel wrote: Changes since v4: - rename InterlockedCompareExchange16 () patch as suggested by Jordan, and added his ack - fix a bug spotted by Anthony in the TestAndClearBit () implementation - added more acks and R-b's - Are there any patches missing review tags? There is just one patch, #23, which had a bug so I was hoping Anthony would add his R-b to the now fixed version. The InterlockedCompareExchange16() has Jordan's ack, but no reply yet from Michael Kinney. - Who should push this once everything is reviewed? Good question. Are you volunteering? :-) Yes. Kick me when you have a public branch with the final review tags added. Grr. Patch #13 is authored jointly by Olivier and myself, and touches only ARM specific code under MdePkg/ I guess that needs someone else's ack as well? Anyways, the branch is here https://git.linaro.org/people/ard.biesheuvel/uefi-next.git/shortlog/refs/heads/linaro-topic-xen with acks/r-b's on all patches except #13 If Olivier is okay with patch #13, then I don't think that should be a worry. However we should await Michael's feedback for patch #14. Please write him an email directly, with a distinct subject. Thanks Laszlo ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel