Re: [Xen-devel] [PATCHv1 1/2] xen-netback: return correct ethtool stats

2015-03-04 Thread Sergei Shtylyov 

Hello.

On 3/3/2015 7:26 PM, David Vrabel wrote:


Use correct pointer arithmetic to get the pointer to each stat.



Signed-off-by: David Vrabel david.vra...@citrix.com
---
  drivers/net/xen-netback/interface.c |3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)



diff --git a/drivers/net/xen-netback/interface.c 
b/drivers/net/xen-netback/interface.c
index f38227a..3aa8648 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -340,12 +340,11 @@ static void xenvif_get_ethtool_stats(struct net_device 
*dev,
unsigned int num_queues = vif-num_queues;
int i;
unsigned int queue_index;
-   struct xenvif_stats *vif_stats;

for (i = 0; i  ARRAY_SIZE(xenvif_stats); i++) {
unsigned long accum = 0;
for (queue_index = 0; queue_index  num_queues; ++queue_index) {
-   vif_stats = vif-queues[queue_index].stats;
+   void *vif_stats = vif-queues[queue_index].stats;


   Need empty line after declaration; checkpatch.pl should have complained here.


accum += *(unsigned long *)(vif_stats + 
xenvif_stats[i].offset);
}
data[i] = accum;


WBR, Sergei


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] [PATCHv1 1/2] xen-netback: return correct ethtool stats

2015-03-03 Thread David Vrabel 
Use correct pointer arithmetic to get the pointer to each stat.

Signed-off-by: David Vrabel david.vra...@citrix.com
---
 drivers/net/xen-netback/interface.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/xen-netback/interface.c 
b/drivers/net/xen-netback/interface.c
index f38227a..3aa8648 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -340,12 +340,11 @@ static void xenvif_get_ethtool_stats(struct net_device 
*dev,
unsigned int num_queues = vif-num_queues;
int i;
unsigned int queue_index;
-   struct xenvif_stats *vif_stats;
 
for (i = 0; i  ARRAY_SIZE(xenvif_stats); i++) {
unsigned long accum = 0;
for (queue_index = 0; queue_index  num_queues; ++queue_index) {
-   vif_stats = vif-queues[queue_index].stats;
+   void *vif_stats = vif-queues[queue_index].stats;
accum += *(unsigned long *)(vif_stats + 
xenvif_stats[i].offset);
}
data[i] = accum;
-- 
1.7.10.4


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel