Re: [Xen-devel] [PULL 0/5] xen-220615
On 23 June 2015 at 11:30, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Tue, 23 Jun 2015, Peter Maydell wrote: I'm afraid I can't apply this -- this revert commit is missing a signed-off-by line. Can you respin, please? I thought that being a straight revert, didn't need a SOB line. xen-220615-2 is the tag with SOB line on the last commit: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-220615-2 xen/pass-through: fold host PCI command register writes only has Jan's signoff, not yours too... (apologies for not noticing that first time around.) I have a bit in my pull-request-creation script that automatically checks that every commit has my signoff, to avoid this kind of mistake: https://git.linaro.org/people/peter.maydell/misc-scripts.git/blob/HEAD:/make-pullreq#l98 thanks -- PMM ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PULL 0/5] xen-220615
On 23 June 2015 at 17:19, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Tue, 23 Jun 2015, Peter Maydell wrote: I have a bit in my pull-request-creation script that automatically checks that every commit has my signoff, to avoid this kind of mistake: https://git.linaro.org/people/peter.maydell/misc-scripts.git/blob/HEAD:/make-pullreq#l98 Sorry. I noticed that this is the second time that I make this mistake. Part of the problem is that in other communities (Linux, Xen Project), maintainers are not required to add their SOB if they don't modify the patch. Interesting. I thought QEMU's process on this was basically the same as Linux's, which says things like The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path. http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#n394 which I take to mean that submaintainers add s-o-b lines. Here is my third try: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-220615-3 Applied this version, thanks. -- PMM ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PULL 0/5] xen-220615
On Tue, 23 Jun 2015, Peter Maydell wrote: On 22 June 2015 at 14:08, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: The following changes since commit 00967f4e0bab246679d0ddc32fd31a7179345baf: Merge remote-tracking branch 'remotes/agraf/tags/signed-s390-for-upstream' into staging (2015-06-05 12:04:42 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-220615 for you to fetch changes up to 960ce9e49c4aaf591f13ced0e74a93499f46016b: Revert xen-hvm: increase maxmem before calling xc_domain_populate_physmap (2015-06-22 13:00:42 +) Xen tree 22/06/2015 Jan Beulich (4): xen/pass-through: fold host PCI command register writes xen/pass-through: ROM BAR handling adjustments xen/pass-through: log errno values rather than function return ones xen/pass-through: constify some static data Stefano Stabellini (1): Revert xen-hvm: increase maxmem before calling xc_domain_populate_physmap I'm afraid I can't apply this -- this revert commit is missing a signed-off-by line. Can you respin, please? I thought that being a straight revert, didn't need a SOB line. xen-220615-2 is the tag with SOB line on the last commit: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-220615-2 ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
[Xen-devel] [PULL 0/5] xen-220615
The following changes since commit 00967f4e0bab246679d0ddc32fd31a7179345baf: Merge remote-tracking branch 'remotes/agraf/tags/signed-s390-for-upstream' into staging (2015-06-05 12:04:42 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-220615 for you to fetch changes up to 960ce9e49c4aaf591f13ced0e74a93499f46016b: Revert xen-hvm: increase maxmem before calling xc_domain_populate_physmap (2015-06-22 13:00:42 +) Xen tree 22/06/2015 Jan Beulich (4): xen/pass-through: fold host PCI command register writes xen/pass-through: ROM BAR handling adjustments xen/pass-through: log errno values rather than function return ones xen/pass-through: constify some static data Stefano Stabellini (1): Revert xen-hvm: increase maxmem before calling xc_domain_populate_physmap hw/xen/xen_pt.c | 51 +++ hw/xen/xen_pt.h |8 +++ hw/xen/xen_pt_config_init.c |7 +++--- hw/xen/xen_pt_msi.c | 24 ++-- xen-hvm.c | 24 5 files changed, 46 insertions(+), 68 deletions(-) ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel