Re: [Xen-devel] Patch to honor --enable-githttp

[Lai, Paul C]

Just re-submitted via `git send-email` ... hopefully the formatting is to your 
liking.  Please let me know otherwise.

-Paul

-Original Message-
From: Wei Liu [mailto:wei.l...@citrix.com] 
Sent: Wednesday, May 4, 2016 9:18 AM
To: Lai, Paul C <paul.c@intel.com>
Cc: Wei Liu <wei.l...@citrix.com>; xen-de...@lists.xenproject.org
Subject: Re: [Xen-devel] Patch to honor --enable-githttp

On Wed, May 04, 2016 at 04:05:21PM +, Lai, Paul C wrote:
> Wei:
> I'm not sure what "refreshing this patch" this patch means.
> 

That means to add your SoB (and go through other stuff mentioned in our 
contribution guideline wiki page) and resend it to xen-devel.

> I just 'git pull origin master' from origin ( 
> http://xenbits.xen.org/git-http/xen.git ) and rebased my work branch with 
> this patch on it cleanly.   No conflicts to resolve.
> 

There are two reasons that your patch is not yet ready: 1. there is no 
Signed-off-by tag; 2. it is not sent out correctly so it can't be applied 
cleanly. So you do need to fix outstanding issues before we can accept it.

These topics are both covered in the wiki page (Signing off patch and sending 
patch). If you're interested in how Xen community do development I suggest you 
go through that page.

Or do you want me to just take over the patch? I can do that, too. In that case 
you still need to give me your SoB.

If you have more questions, feel free to ask.

Wei.


> Looking to help out,
> -Paul
> 
> -Original Message-
> From: Wei Liu [mailto:wei.l...@citrix.com]
> Sent: Wednesday, May 4, 2016 2:42 AM
> To: Lai, Paul C <paul.c@intel.com>
> Cc: xen-de...@lists.xenproject.org; Wei Liu <wei.l...@citrix.com>
> Subject: Re: [Xen-devel] Patch to honor --enable-githttp
> 
> Hi Paul
> 
> We are about to release a new version of Xen soon. I think this patch is nice 
> to have for the new release. Would you be up for refreshing this patch?
> 
> This is also a good chance to get yourself started with Xen development.
> Feel free to ask me any question.
> 
> Thanks
> Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] Patch to honor --enable-githttp

[Wei Liu]

On Wed, May 04, 2016 at 04:05:21PM +, Lai, Paul C wrote:
> Wei:
> I'm not sure what "refreshing this patch" this patch means.
> 

That means to add your SoB (and go through other stuff mentioned in our
contribution guideline wiki page) and resend it to xen-devel.

> I just 'git pull origin master' from origin ( 
> http://xenbits.xen.org/git-http/xen.git ) and rebased my work branch with 
> this patch on it cleanly.   No conflicts to resolve.
> 

There are two reasons that your patch is not yet ready: 1. there is no
Signed-off-by tag; 2. it is not sent out correctly so it can't be
applied cleanly. So you do need to fix outstanding issues before we can
accept it.

These topics are both covered in the wiki page (Signing off patch and
sending patch). If you're interested in how Xen community do development
I suggest you go through that page.

Or do you want me to just take over the patch? I can do that, too. In
that case you still need to give me your SoB.

If you have more questions, feel free to ask.

Wei.


> Looking to help out,
> -Paul
> 
> -Original Message-
> From: Wei Liu [mailto:wei.l...@citrix.com] 
> Sent: Wednesday, May 4, 2016 2:42 AM
> To: Lai, Paul C <paul.c@intel.com>
> Cc: xen-de...@lists.xenproject.org; Wei Liu <wei.l...@citrix.com>
> Subject: Re: [Xen-devel] Patch to honor --enable-githttp
> 
> Hi Paul
> 
> We are about to release a new version of Xen soon. I think this patch is nice 
> to have for the new release. Would you be up for refreshing this patch?
> 
> This is also a good chance to get yourself started with Xen development.
> Feel free to ask me any question.
> 
> Thanks
> Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] Patch to honor --enable-githttp

[Lai, Paul C]

Wei:
I'm not sure what "refreshing this patch" this patch means.

I just 'git pull origin master' from origin ( 
http://xenbits.xen.org/git-http/xen.git ) and rebased my work branch with this 
patch on it cleanly.   No conflicts to resolve.

Looking to help out,
-Paul

-Original Message-
From: Wei Liu [mailto:wei.l...@citrix.com] 
Sent: Wednesday, May 4, 2016 2:42 AM
To: Lai, Paul C <paul.c@intel.com>
Cc: xen-de...@lists.xenproject.org; Wei Liu <wei.l...@citrix.com>
Subject: Re: [Xen-devel] Patch to honor --enable-githttp

Hi Paul

We are about to release a new version of Xen soon. I think this patch is nice 
to have for the new release. Would you be up for refreshing this patch?

This is also a good chance to get yourself started with Xen development.
Feel free to ask me any question.

Thanks
Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] Patch to honor --enable-githttp

[Wei Liu]

Hi Paul

We are about to release a new version of Xen soon. I think this patch is
nice to have for the new release. Would you be up for refreshing this
patch?

This is also a good chance to get yourself started with Xen development.
Feel free to ask me any question.

Thanks
Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] Patch to honor --enable-githttp

[Paul Lai]

commit 747f48e6dd7bcc2fbe14d37c62018c5c9e0e44c8
Author: Paul Lai 
Date:   Mon Apr 11 10:43:57 2016 -0700

Honor '--enable-githttp' in toplevel Makefile generation

During the make world, git mini-os.git didn't honor the 'configure
--enable-githttp' option.  The 'enable-githttp' was only honored in
the tools subdirectory.

Signed-off-by: Paul Lai 

diff --git a/config/Toplevel.mk.in b/config/Toplevel.mk.in
index 4db7eaf..1d99189 100644
--- a/config/Toplevel.mk.in
+++ b/config/Toplevel.mk.in
@@ -1 +1,2 @@
 SUBSYSTEMS   := @SUBSYSTEMS@
+GIT_HTTP := @githttp@
diff --git a/configure b/configure
index 3c269fa..78e8025 100755
--- a/configure
+++ b/configure
@@ -594,6 +594,7 @@ stubdom
 tools
 xen
 subdirs
+githttp
 XEN_DUMP_DIR
 XEN_PAGING_DIR
 XEN_LOCK_DIR
@@ -660,6 +661,7 @@ enable_option_checking
 with_initddir
 with_sysconfig_leaf_dir
 with_xen_dumpdir
+enable_githttp
 enable_xen
 enable_tools
 enable_stubdom
@@ -1284,6 +1286,8 @@ Optional Features:
   --disable-option-checking  ignore unrecognized --enable/--with options
   --disable-FEATURE   do not include FEATURE (same as --enable-FEATURE=no)
   --enable-FEATURE[=ARG]  include FEATURE [ARG=yes]
+  --enable-githttpDownload GIT repositories via HTTP (default is
+  DISABLED)
   --disable-xen   Disable build and install of xen
   --disable-tools Disable build and install of tools
   --enable-stubdomEnable build and install of stubdom
@@ -1985,6 +1989,29 @@ XEN_DUMP_DIR=$xen_dumpdir_path
 
 
 
+# Check whether --enable-githttp was given.
+if test "${enable_githttp+set}" = set; then :
+  enableval=$enable_githttp;
+fi
+
+
+if test "x$enable_githttp" = "xno"; then :
+
+ax_cv_githttp="n"
+
+elif test "x$enable_githttp" = "xyes"; then :
+
+ax_cv_githttp="y"
+
+elif test -z $ax_cv_githttp; then :
+
+ax_cv_githttp="n"
+
+fi
+githttp=$ax_cv_githttp
+
+
+
 case "$host_cpu" in
 i[3456]86|x86_64)
 arch_enable_stubdom=y
diff --git a/configure.ac b/configure.ac
index 1843b52..7388b28 100644
--- a/configure.ac
+++ b/configure.ac
@@ -17,6 +17,7 @@ m4_include([m4/subsystem.m4])
 m4_include([m4/paths.m4])
 
 AX_XEN_EXPAND_CONFIG()
+AX_ARG_DEFAULT_DISABLE([githttp], [Download GIT repositories via HTTP])
 
 dnl mini-os is only ported to certain platforms
 case "$host_cpu" in

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

[Xen-devel] Patch to honor --enable-githttp

[Lai, Paul C]

The following patch fixes the toplevel Xen makefile gereration to honor 
-enable-githttp if the option is used during configuration.


commit 040510913564ec7e9f46ce833f8bdf1a40950ff7
Author: Paul Lai 
Date:   Mon Apr 11 10:43:57 2016 -0700

Honor '--enable-githttp' in toplevel Makefile generation

During the make world, git mini-os.git didn't honor the 'configure
--enable-githttp' option.  The 'enable-githttp' was only honored in
the tools subdirectory.

diff --git a/config/Toplevel.mk.in b/config/Toplevel.mk.in
index 4db7eaf..1d99189 100644
--- a/config/Toplevel.mk.in
+++ b/config/Toplevel.mk.in
@@ -1 +1,2 @@
SUBSYSTEMS   := @SUBSYSTEMS@
+GIT_HTTP := @githttp@
diff --git a/configure b/configure
index 3c269fa..78e8025 100755
--- a/configure
+++ b/configure
@@ -594,6 +594,7 @@ stubdom
tools
xen
subdirs
+githttp
XEN_DUMP_DIR
XEN_PAGING_DIR
XEN_LOCK_DIR
@@ -660,6 +661,7 @@ enable_option_checking
with_initddir
with_sysconfig_leaf_dir
with_xen_dumpdir
+enable_githttp
enable_xen
enable_tools
enable_stubdom
@@ -1284,6 +1286,8 @@ Optional Features:
   --disable-option-checking  ignore unrecognized --enable/--with options
   --disable-FEATURE   do not include FEATURE (same as --enable-FEATURE=no)
   --enable-FEATURE[=ARG]  include FEATURE [ARG=yes]
+  --enable-githttpDownload GIT repositories via HTTP (default is
+  DISABLED)
   --disable-xen   Disable build and install of xen
   --disable-tools Disable build and install of tools
   --enable-stubdomEnable build and install of stubdom
@@ -1985,6 +1989,29 @@ XEN_DUMP_DIR=$xen_dumpdir_path


+# Check whether --enable-githttp was given.
+if test "${enable_githttp+set}" = set; then :
+  enableval=$enable_githttp;
+fi
+
+
+if test "x$enable_githttp" = "xno"; then :
+
+ax_cv_githttp="n"
+
+elif test "x$enable_githttp" = "xyes"; then :
+
+ax_cv_githttp="y"
+
+elif test -z $ax_cv_githttp; then :
+
+ax_cv_githttp="n"
+
+fi
+githttp=$ax_cv_githttp
+
+
+
case "$host_cpu" in
 i[3456]86|x86_64)
 arch_enable_stubdom=y
diff --git a/configure.ac b/configure.ac
index 1843b52..7388b28 100644
--- a/configure.ac
+++ b/configure.ac
@@ -17,6 +17,7 @@ m4_include([m4/subsystem.m4])
m4_include([m4/paths.m4])
 AX_XEN_EXPAND_CONFIG()
+AX_ARG_DEFAULT_DISABLE([githttp], [Download GIT repositories via HTTP])
 dnl mini-os is only ported to certain platforms
case "$host_cpu" in




enable_githttp.patch
Description: enable_githttp.patch
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel