Re: [Xen-devel] [OSSTEST PATCH 4/4] Insert nested test job name and runvars into
On Thu, 2015-01-29 at 10:52 +, Ian Campbell wrote:
> On Thu, 2015-01-29 at 10:42 +, Wei Liu wrote:
> > On Thu, Jan 29, 2015 at 09:57:43AM +, Hu, Robert wrote:
> > [...]
> > > > > diff --git a/mfi-common b/mfi-common
> > > > > index 5c4f5d5..b65f0b5 100644
> > > > > --- a/mfi-common
> > > > > +++ b/mfi-common
> > > > > @@ -166,6 +166,14 @@ create_build_jobs () {
> > > > > revision_qemu=$REVISION_QEMU
> > > > \
> > > > > revision_qemuu=$REVISION_QEMU_UPSTREAM
> > > > > fi
> > > > > +./cs-job-create $flight build-$arch-hvm build-kern
> > > > \
> > > > > +arch=$arch kconfighow=xen-enable-xen-config
> > > > \
> > > > > +$RUNVARS $BUILD_RUNVARS $BUILD_LINUX_RUNVARS
> > > > $arch_runvars \
> > > > > +$suite_runvars
> > > > \
> > > > > +host_hostflags=$build_hostflags
> > > > \
> > > > > +revision_linux=v3.16
> > > > \
> > > > > +
> > > > tree_linux=git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> > > > \
> > > >
> > > > Please don't hard code tree and revision.
> > > >
> > > > You can specify tree and revision in you test configuration.
> > > Can you help more on details regarding to 'test configuration'? Thanks.
> >
> > If you look at other tree_linux= in mfi-common, you can see they are
> > assigned to $TREE_LINUX, which is in fact just a shell variable. There
> > are also other variables that you might be interested in, say
> > revision_linux.
> >
> > If you're using standalone mode, you can specify those variables in
> > .standalone.config then ./standalone-reset. Those trees will then be
> > imported to standalone.db (which is a sqlite3 db) and used during the
> > test.
> >
> > If you're using production mode, I think there is another way to
> > configure that. I've never setup production mode myself so I cannot say
> > for sure.
>
> cr-daily-branch sets all this stuff up depending on the branch name and
> they get put into the runvars by make-flight (or the mfi-common helper
> library).
>
> create_build_jobs already has a load of stuff using tree_linux, I'd
> expect you could just copy it and use the same stuff as L0, unless there
> is some reason for differing? In which case we need to have a
> conversation about what each branch should be testing wrt the L1
> hypervisor and dom0.
... although, did we not decide earlier that the nested test jobs should
reuse the output of the existing build-* jobs, rather than rebuilding?
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Re: [Xen-devel] [OSSTEST PATCH 4/4] Insert nested test job name and runvars into
On Thu, 2015-01-29 at 10:42 +, Wei Liu wrote:
> On Thu, Jan 29, 2015 at 09:57:43AM +, Hu, Robert wrote:
> [...]
> > > > diff --git a/mfi-common b/mfi-common
> > > > index 5c4f5d5..b65f0b5 100644
> > > > --- a/mfi-common
> > > > +++ b/mfi-common
> > > > @@ -166,6 +166,14 @@ create_build_jobs () {
> > > > revision_qemu=$REVISION_QEMU
> > > \
> > > > revision_qemuu=$REVISION_QEMU_UPSTREAM
> > > > fi
> > > > +./cs-job-create $flight build-$arch-hvm build-kern
> > > \
> > > > +arch=$arch kconfighow=xen-enable-xen-config
> > > \
> > > > +$RUNVARS $BUILD_RUNVARS $BUILD_LINUX_RUNVARS
> > > $arch_runvars \
> > > > +$suite_runvars
> > > \
> > > > +host_hostflags=$build_hostflags
> > > \
> > > > +revision_linux=v3.16
> > > \
> > > > +
> > > tree_linux=git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> > > \
> > >
> > > Please don't hard code tree and revision.
> > >
> > > You can specify tree and revision in you test configuration.
> > Can you help more on details regarding to 'test configuration'? Thanks.
>
> If you look at other tree_linux= in mfi-common, you can see they are
> assigned to $TREE_LINUX, which is in fact just a shell variable. There
> are also other variables that you might be interested in, say
> revision_linux.
>
> If you're using standalone mode, you can specify those variables in
> .standalone.config then ./standalone-reset. Those trees will then be
> imported to standalone.db (which is a sqlite3 db) and used during the
> test.
>
> If you're using production mode, I think there is another way to
> configure that. I've never setup production mode myself so I cannot say
> for sure.
cr-daily-branch sets all this stuff up depending on the branch name and
they get put into the runvars by make-flight (or the mfi-common helper
library).
create_build_jobs already has a load of stuff using tree_linux, I'd
expect you could just copy it and use the same stuff as L0, unless there
is some reason for differing? In which case we need to have a
conversation about what each branch should be testing wrt the L1
hypervisor and dom0.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Re: [Xen-devel] [OSSTEST PATCH 4/4] Insert nested test job name and runvars into
On Thu, Jan 29, 2015 at 09:57:43AM +, Hu, Robert wrote:
[...]
> > > diff --git a/mfi-common b/mfi-common
> > > index 5c4f5d5..b65f0b5 100644
> > > --- a/mfi-common
> > > +++ b/mfi-common
> > > @@ -166,6 +166,14 @@ create_build_jobs () {
> > > revision_qemu=$REVISION_QEMU
> > \
> > > revision_qemuu=$REVISION_QEMU_UPSTREAM
> > > fi
> > > +./cs-job-create $flight build-$arch-hvm build-kern
> > \
> > > +arch=$arch kconfighow=xen-enable-xen-config
> > \
> > > +$RUNVARS $BUILD_RUNVARS $BUILD_LINUX_RUNVARS
> > $arch_runvars \
> > > +$suite_runvars
> > \
> > > +host_hostflags=$build_hostflags
> > \
> > > +revision_linux=v3.16
> > \
> > > +
> > tree_linux=git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> > \
> >
> > Please don't hard code tree and revision.
> >
> > You can specify tree and revision in you test configuration.
> Can you help more on details regarding to 'test configuration'? Thanks.
If you look at other tree_linux= in mfi-common, you can see they are
assigned to $TREE_LINUX, which is in fact just a shell variable. There
are also other variables that you might be interested in, say
revision_linux.
If you're using standalone mode, you can specify those variables in
.standalone.config then ./standalone-reset. Those trees will then be
imported to standalone.db (which is a sqlite3 db) and used during the
test.
If you're using production mode, I think there is another way to
configure that. I've never setup production mode myself so I cannot say
for sure.
Wei.
> >
> > Wei.
> >
> > > +${TREEVCS_LINUX:+treevcs_linux=}${TREEVCS_LINUX}
> > >
> > > ./cs-job-create $flight build-$arch-pvops build-kern
> > \
> > > arch=$arch kconfighow=xen-enable-xen-config
> > \
> > > --
> > > 1.7.10.4
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Re: [Xen-devel] [OSSTEST PATCH 4/4] Insert nested test job name and runvars into
> -Original Message-
> From: Wei Liu [mailto:wei.l...@citrix.com]
> Sent: Thursday, December 11, 2014 7:46 PM
> To: Pang, LongtaoX
> Cc: xen-devel@lists.xen.org; ian.jack...@eu.citrix.com;
> ian.campb...@citrix.com; wei.l...@citrix.com; Hu, Robert; Zheng, Di
> Subject: Re: [OSSTEST PATCH 4/4] Insert nested test job name and runvars into
>
> On Wed, Dec 10, 2014 at 04:07:40PM +0800, longtao.pang wrote:
> > From: "longtao.pang"
> >
> > This patch is used for inserting nested test job name and runvars into
> > standalone.db database after execute command './standalone-reset'.
> >
> > ---
> > make-flight | 19 +++
> > mfi-common |8
> > 2 files changed, 27 insertions(+)
> >
> > diff --git a/make-flight b/make-flight
> > index 9963a46..fe64237 100755
> > --- a/make-flight
> > +++ b/make-flight
> > @@ -197,6 +197,24 @@ do_hvm_win7_x64_tests () {
> > all_hostflags=$most_hostflags,hvm
> > }
> >
> > +do_hvm_debian_nested_tests () {
> > + if [ $xenarch != amd64 ]; then
> > +return
> > + fi
> > + if [ $dom0arch != amd64 ]; then
> > +return
> > + fi
> > +
> > + job_create_test test-$xenarch$kern-$dom0arch-nested test-nested xl \
> > + $xenarch $dom0arch \
> > +nested_image=debian-7.6.0-amd64-DVD-1.iso \
> > + bios=seabios \
> > + kernbuildjob=build-amd64-hvm \
> > + kernkind=hvm \
> > + device_model_version=qemu-xen \
> > +all_hostflags=$most_hostflags,hvm
> > +}
> > +
> > do_hvm_debian_test_one () {
> >testname=$1
> >bios=$2
> > @@ -364,6 +382,7 @@ test_matrix_do_one () {
> >
> >fi
> >
> > + do_hvm_debian_nested_tests
> >do_passthrough_tests
> > }
> >
> > diff --git a/mfi-common b/mfi-common
> > index 5c4f5d5..b65f0b5 100644
> > --- a/mfi-common
> > +++ b/mfi-common
> > @@ -166,6 +166,14 @@ create_build_jobs () {
> > revision_qemu=$REVISION_QEMU
> \
> > revision_qemuu=$REVISION_QEMU_UPSTREAM
> > fi
> > +./cs-job-create $flight build-$arch-hvm build-kern
> \
> > +arch=$arch kconfighow=xen-enable-xen-config
> \
> > +$RUNVARS $BUILD_RUNVARS $BUILD_LINUX_RUNVARS
> $arch_runvars \
> > +$suite_runvars
> \
> > +host_hostflags=$build_hostflags
> \
> > +revision_linux=v3.16
> \
> > +
> tree_linux=git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> \
>
> Please don't hard code tree and revision.
>
> You can specify tree and revision in you test configuration.
Can you help more on details regarding to 'test configuration'? Thanks.
>
> Wei.
>
> > +${TREEVCS_LINUX:+treevcs_linux=}${TREEVCS_LINUX}
> >
> > ./cs-job-create $flight build-$arch-pvops build-kern
> \
> > arch=$arch kconfighow=xen-enable-xen-config
> \
> > --
> > 1.7.10.4
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Re: [Xen-devel] [OSSTEST PATCH 4/4] Insert nested test job name and runvars into
> -Original Message-
> From: Wei Liu [mailto:wei.l...@citrix.com]
> Sent: Thursday, December 11, 2014 7:46 PM
> To: Pang, LongtaoX
> Cc: xen-devel@lists.xen.org; ian.jack...@eu.citrix.com;
> ian.campb...@citrix.com; wei.l...@citrix.com; Hu, Robert; Zheng, Di
> Subject: Re: [OSSTEST PATCH 4/4] Insert nested test job name and runvars into
>
> On Wed, Dec 10, 2014 at 04:07:40PM +0800, longtao.pang wrote:
> > From: "longtao.pang"
> >
> > This patch is used for inserting nested test job name and runvars into
> > standalone.db database after execute command './standalone-reset'.
> >
> > ---
> > make-flight | 19 +++
> > mfi-common |8
> > 2 files changed, 27 insertions(+)
> >
> > diff --git a/make-flight b/make-flight index 9963a46..fe64237 100755
> > --- a/make-flight
> > +++ b/make-flight
> > @@ -197,6 +197,24 @@ do_hvm_win7_x64_tests () {
> > all_hostflags=$most_hostflags,hvm }
> >
> > +do_hvm_debian_nested_tests () {
> > + if [ $xenarch != amd64 ]; then
> > +return
> > + fi
> > + if [ $dom0arch != amd64 ]; then
> > +return
> > + fi
> > +
> > + job_create_test test-$xenarch$kern-$dom0arch-nested test-nested xl \
> > + $xenarch $dom0arch \
> > +nested_image=debian-7.6.0-amd64-DVD-1.iso \
> > + bios=seabios \
> > + kernbuildjob=build-amd64-hvm \
> > + kernkind=hvm \
> > + device_model_version=qemu-xen \
> > +all_hostflags=$most_hostflags,hvm }
> > +
> > do_hvm_debian_test_one () {
> >testname=$1
> >bios=$2
> > @@ -364,6 +382,7 @@ test_matrix_do_one () {
> >
> >fi
> >
> > + do_hvm_debian_nested_tests
> >do_passthrough_tests
> > }
> >
> > diff --git a/mfi-common b/mfi-common
> > index 5c4f5d5..b65f0b5 100644
> > --- a/mfi-common
> > +++ b/mfi-common
> > @@ -166,6 +166,14 @@ create_build_jobs () {
> > revision_qemu=$REVISION_QEMU
> \
> > revision_qemuu=$REVISION_QEMU_UPSTREAM
> > fi
> > +./cs-job-create $flight build-$arch-hvm build-kern
> \
> > +arch=$arch kconfighow=xen-enable-xen-config
> \
> > +$RUNVARS $BUILD_RUNVARS $BUILD_LINUX_RUNVARS
> $arch_runvars \
> > +$suite_runvars
> \
> > +host_hostflags=$build_hostflags
> \
> > +revision_linux=v3.16
> \
> > +
> tree_linux=git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> \
>
> Please don't hard code tree and revision.
>
> You can specify tree and revision in you test configuration.
>
> Wei.
[Pang, LongtaoX] Thanks for checking, I will try to modify it.
>
> > +${TREEVCS_LINUX:+treevcs_linux=}${TREEVCS_LINUX}
> >
> > ./cs-job-create $flight build-$arch-pvops build-kern
> \
> > arch=$arch kconfighow=xen-enable-xen-config
> \
> > --
> > 1.7.10.4
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Re: [Xen-devel] [OSSTEST PATCH 4/4] Insert nested test job name and runvars into
On Wed, Dec 10, 2014 at 04:07:40PM +0800, longtao.pang wrote:
> From: "longtao.pang"
>
> This patch is used for inserting nested test job name and runvars into
> standalone.db database after execute command './standalone-reset'.
>
> ---
> make-flight | 19 +++
> mfi-common |8
> 2 files changed, 27 insertions(+)
>
> diff --git a/make-flight b/make-flight
> index 9963a46..fe64237 100755
> --- a/make-flight
> +++ b/make-flight
> @@ -197,6 +197,24 @@ do_hvm_win7_x64_tests () {
> all_hostflags=$most_hostflags,hvm
> }
>
> +do_hvm_debian_nested_tests () {
> + if [ $xenarch != amd64 ]; then
> +return
> + fi
> + if [ $dom0arch != amd64 ]; then
> +return
> + fi
> +
> + job_create_test test-$xenarch$kern-$dom0arch-nested test-nested xl \
> + $xenarch $dom0arch \
> +nested_image=debian-7.6.0-amd64-DVD-1.iso \
> + bios=seabios \
> + kernbuildjob=build-amd64-hvm \
> + kernkind=hvm \
> + device_model_version=qemu-xen \
> +all_hostflags=$most_hostflags,hvm
> +}
> +
> do_hvm_debian_test_one () {
>testname=$1
>bios=$2
> @@ -364,6 +382,7 @@ test_matrix_do_one () {
>
>fi
>
> + do_hvm_debian_nested_tests
>do_passthrough_tests
> }
>
> diff --git a/mfi-common b/mfi-common
> index 5c4f5d5..b65f0b5 100644
> --- a/mfi-common
> +++ b/mfi-common
> @@ -166,6 +166,14 @@ create_build_jobs () {
> revision_qemu=$REVISION_QEMU
> \
> revision_qemuu=$REVISION_QEMU_UPSTREAM
> fi
> +./cs-job-create $flight build-$arch-hvm build-kern
> \
> +arch=$arch kconfighow=xen-enable-xen-config
> \
> +$RUNVARS $BUILD_RUNVARS $BUILD_LINUX_RUNVARS $arch_runvars
> \
> +$suite_runvars
> \
> +host_hostflags=$build_hostflags
> \
> +revision_linux=v3.16
> \
> +
> tree_linux=git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> \
Please don't hard code tree and revision.
You can specify tree and revision in you test configuration.
Wei.
> +${TREEVCS_LINUX:+treevcs_linux=}${TREEVCS_LINUX}
>
> ./cs-job-create $flight build-$arch-pvops build-kern
> \
> arch=$arch kconfighow=xen-enable-xen-config
> \
> --
> 1.7.10.4
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
