Re: [Xen-devel] [PATCH] build: drop unused SUBARCH variable
On 05/10/15 14:37, Ian Jackson wrote:
> Julien Grall writes ("Re: [Xen-devel] [PATCH] build: drop unused SUBARCH
> variable"):
>> Jan tends to not notify when a patch has been committed. It's in the
>> tree since last week:
>>
>> commit 063792541db41167db9467feadb700de64cfcd16
>> Author: Doug Goldstein
>> Date: Mon Sep 21 16:14:19 2015 +0200
>>
>> build: drop unused SUBARCH variable
>>
>> This variable appears to be unused throughout the code base.
>>
>> Signed-off-by: Doug Goldstein
>
> I wonder if we should have a robot notify the patch From: line when a
> patch gets committed.
That might be a good idea.
Regards,
--
Julien Grall
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH] build: drop unused SUBARCH variable
Julien Grall writes ("Re: [Xen-devel] [PATCH] build: drop unused SUBARCH
variable"):
> Jan tends to not notify when a patch has been committed. It's in the
> tree since last week:
>
> commit 063792541db41167db9467feadb700de64cfcd16
> Author: Doug Goldstein
> Date: Mon Sep 21 16:14:19 2015 +0200
>
> build: drop unused SUBARCH variable
>
> This variable appears to be unused throughout the code base.
>
> Signed-off-by: Doug Goldstein
I wonder if we should have a robot notify the patch From: line when a
patch gets committed.
Ian.
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH] build: drop unused SUBARCH variable
On Thu, 2015-10-01 at 00:44 -0600, Jan Beulich wrote: > > > > On 30.09.15 at 19:58, wrote: > > On 9/18/15 1:41 PM, Doug Goldstein wrote: > > > This variable appears to be unused throughout the code base. > > > > > > Signed-off-by: Doug Goldstein > > > --- > > > Makefile | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/Makefile b/Makefile > > > index 75177f0..8a9331f 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -35,8 +35,7 @@ mini-os-dir-force-update: mini-os-dir > > > $(GIT) reset --hard $(MINIOS_UPSTREAM_REVISION); \ > > > fi > > > > > > -SUBARCH := $(subst x86_32,i386,$(XEN_TARGET_ARCH)) > > > -export XEN_TARGET_ARCH SUBARCH > > > +export XEN_TARGET_ARCH > > > export DESTDIR > > > > > > # build and install everything into the standard system directories > > > > > > > ping? > > This was applied over a week ago. Did you check the tree before > pinging? I've updated http://wiki.xen.org/wiki/Submitting_Xen_Project_Patches to mention that people should check staging. Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH] build: drop unused SUBARCH variable
>>> On 30.09.15 at 19:58, wrote: > On 9/18/15 1:41 PM, Doug Goldstein wrote: >> This variable appears to be unused throughout the code base. >> >> Signed-off-by: Doug Goldstein >> --- >> Makefile | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 75177f0..8a9331f 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -35,8 +35,7 @@ mini-os-dir-force-update: mini-os-dir >> $(GIT) reset --hard $(MINIOS_UPSTREAM_REVISION); \ >> fi >> >> -SUBARCH := $(subst x86_32,i386,$(XEN_TARGET_ARCH)) >> -export XEN_TARGET_ARCH SUBARCH >> +export XEN_TARGET_ARCH >> export DESTDIR >> >> # build and install everything into the standard system directories >> > > ping? This was applied over a week ago. Did you check the tree before pinging? Jan ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH] build: drop unused SUBARCH variable
On 30/09/15 18:58, Doug Goldstein wrote: > On 9/18/15 1:41 PM, Doug Goldstein wrote: >> This variable appears to be unused throughout the code base. >> >> Signed-off-by: Doug Goldstein >> --- >> Makefile | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 75177f0..8a9331f 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -35,8 +35,7 @@ mini-os-dir-force-update: mini-os-dir >> $(GIT) reset --hard $(MINIOS_UPSTREAM_REVISION); \ >> fi >> >> -SUBARCH := $(subst x86_32,i386,$(XEN_TARGET_ARCH)) >> -export XEN_TARGET_ARCH SUBARCH >> +export XEN_TARGET_ARCH >> export DESTDIR >> >> # build and install everything into the standard system directories >> > > ping? Jan tends to not notify when a patch has been committed. It's in the tree since last week: commit 063792541db41167db9467feadb700de64cfcd16 Author: Doug Goldstein Date: Mon Sep 21 16:14:19 2015 +0200 build: drop unused SUBARCH variable This variable appears to be unused throughout the code base. Signed-off-by: Doug Goldstein Regards, -- Julien Grall ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH] build: drop unused SUBARCH variable
On 9/18/15 1:41 PM, Doug Goldstein wrote: > This variable appears to be unused throughout the code base. > > Signed-off-by: Doug Goldstein > --- > Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 75177f0..8a9331f 100644 > --- a/Makefile > +++ b/Makefile > @@ -35,8 +35,7 @@ mini-os-dir-force-update: mini-os-dir > $(GIT) reset --hard $(MINIOS_UPSTREAM_REVISION); \ > fi > > -SUBARCH := $(subst x86_32,i386,$(XEN_TARGET_ARCH)) > -export XEN_TARGET_ARCH SUBARCH > +export XEN_TARGET_ARCH > export DESTDIR > > # build and install everything into the standard system directories > ping? -- Doug Goldstein signature.asc Description: OpenPGP digital signature ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
