Re: [Xen-devel] [PATCH] libxc: Expose the MPX cpuid flag to guest

[Ian Jackson]

Li, Liang Z writes ("RE: [Xen-devel] [PATCH] libxc: Expose the MPX cpuid flag 
to guest"):
> > Cc: wei.l...@citrix.com; ian.campb...@citrix.com;
> > stefano.stabell...@eu.citrix.com; ian.jack...@eu.citrix.com; xen-
> > de...@lists.xen.org; jbeul...@suse.com
> > Subject: Re: [Xen-devel] [PATCH] libxc: Expose the MPX cpuid flag to guest
> > 
> > On Mon, Jan 11, 2016 at 04:52:10PM +0800, Liang Li wrote:
> > > If hardware support memory protect externsion, expose this feature
> > 
> > extension
> 
> Thanks!

Sorry for the delay.  I have queued this patch and assuming that my
build test passes it will be pushed shortly.

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] libxc: Expose the MPX cpuid flag to guest

[Doug Goldstein]

On 2/23/16 2:57 AM, Li, Liang Z wrote:
>> From: Andrew Cooper [mailto:andrew.coop...@citrix.com]
>> Sent: Monday, January 11, 2016 5:59 PM
>> To: Wei Liu; Li, Liang Z
>> Cc: ian.campb...@citrix.com; stefano.stabell...@eu.citrix.com;
>> ian.jack...@eu.citrix.com; xen-devel@lists.xen.org; jbeul...@suse.com
>> Subject: Re: [Xen-devel] [PATCH] libxc: Expose the MPX cpuid flag to guest
>>
>> On 11/01/16 09:05, Wei Liu wrote:
>>> On Mon, Jan 11, 2016 at 04:52:10PM +0800, Liang Li wrote:
>>>> If hardware support memory protect externsion, expose this feature to
>>>> guest by default. Users don't have to use a 'cpuid= ' option in
>>>> config file to turn it on.
>>>>
>>>> Signed-off-by: Liang Li <liang.z...@intel.com>
>>> I will defer this to the x86 maintainers.
>>
>> Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
>>
>> Looks like the hypervisor side is all present.
>>
>> ~Andrew
> 
> Is there anyone who can help to make this patch merged? It's pending for a 
> long time.
> 
> Liang
> 

Ping on the behalf of Liang. This patch still applies cleanly.

-- 
Doug Goldstein



signature.asc
Description: OpenPGP digital signature
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] libxc: Expose the MPX cpuid flag to guest

[Li, Liang Z]

> From: Andrew Cooper [mailto:andrew.coop...@citrix.com]
> Sent: Monday, January 11, 2016 5:59 PM
> To: Wei Liu; Li, Liang Z
> Cc: ian.campb...@citrix.com; stefano.stabell...@eu.citrix.com;
> ian.jack...@eu.citrix.com; xen-devel@lists.xen.org; jbeul...@suse.com
> Subject: Re: [Xen-devel] [PATCH] libxc: Expose the MPX cpuid flag to guest
> 
> On 11/01/16 09:05, Wei Liu wrote:
> > On Mon, Jan 11, 2016 at 04:52:10PM +0800, Liang Li wrote:
> >> If hardware support memory protect externsion, expose this feature to
> >> guest by default. Users don't have to use a 'cpuid= ' option in
> >> config file to turn it on.
> >>
> >> Signed-off-by: Liang Li <liang.z...@intel.com>
> > I will defer this to the x86 maintainers.
> 
> Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
> 
> Looks like the hypervisor side is all present.
> 
> ~Andrew

Is there anyone who can help to make this patch merged? It's pending for a long 
time.

Liang

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] libxc: Expose the MPX cpuid flag to guest

[Li, Liang Z]

> Cc: wei.l...@citrix.com; ian.campb...@citrix.com;
> stefano.stabell...@eu.citrix.com; ian.jack...@eu.citrix.com; xen-
> de...@lists.xen.org; jbeul...@suse.com
> Subject: Re: [Xen-devel] [PATCH] libxc: Expose the MPX cpuid flag to guest
> 
> On Mon, Jan 11, 2016 at 04:52:10PM +0800, Liang Li wrote:
> > If hardware support memory protect externsion, expose this feature
> 
> extension

Thanks!

Liang


___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] libxc: Expose the MPX cpuid flag to guest

[Wei Liu]

On Mon, Jan 11, 2016 at 04:52:10PM +0800, Liang Li wrote:
> If hardware support memory protect externsion, expose this feature
> to guest by default. Users don't have to use a 'cpuid= ' option in
> config file to turn it on.
> 
> Signed-off-by: Liang Li 

I will defer this to the x86 maintainers.

Wei.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] libxc: Expose the MPX cpuid flag to guest

[Andrew Cooper]

On 11/01/16 09:05, Wei Liu wrote:
> On Mon, Jan 11, 2016 at 04:52:10PM +0800, Liang Li wrote:
>> If hardware support memory protect externsion, expose this feature
>> to guest by default. Users don't have to use a 'cpuid= ' option in
>> config file to turn it on.
>>
>> Signed-off-by: Liang Li 
> I will defer this to the x86 maintainers.

Reviewed-by: Andrew Cooper 

Looks like the hypervisor side is all present.

~Andrew

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] libxc: Expose the MPX cpuid flag to guest

[Konrad Rzeszutek Wilk]

On Mon, Jan 11, 2016 at 04:52:10PM +0800, Liang Li wrote:
> If hardware support memory protect externsion, expose this feature

extension
> to guest by default. Users don't have to use a 'cpuid= ' option in
> config file to turn it on.
> 
> Signed-off-by: Liang Li 
> ---
>  tools/libxc/xc_cpufeature.h | 1 +
>  tools/libxc/xc_cpuid_x86.c  | 6 ++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/tools/libxc/xc_cpufeature.h b/tools/libxc/xc_cpufeature.h
> index c3ddc80..cda9305 100644
> --- a/tools/libxc/xc_cpufeature.h
> +++ b/tools/libxc/xc_cpufeature.h
> @@ -137,6 +137,7 @@
>  #define X86_FEATURE_ERMS 9 /* Enhanced REP MOVSB/STOSB */
>  #define X86_FEATURE_INVPCID 10 /* Invalidate Process Context ID */
>  #define X86_FEATURE_RTM 11 /* Restricted Transactional Memory */
> +#define X86_FEATURE_MPX 14 /* Memory Protection Extensions */
>  #define X86_FEATURE_RDSEED  18 /* RDSEED instruction */
>  #define X86_FEATURE_ADX 19 /* ADCX, ADOX instructions */
>  #define X86_FEATURE_SMAP20 /* Supervisor Mode Access Protection */
> diff --git a/tools/libxc/xc_cpuid_x86.c b/tools/libxc/xc_cpuid_x86.c
> index 8882c01..4c88db4 100644
> --- a/tools/libxc/xc_cpuid_x86.c
> +++ b/tools/libxc/xc_cpuid_x86.c
> @@ -423,6 +423,8 @@ static void xc_cpuid_hvm_policy(xc_interface *xch,
>  bitmaskof(X86_FEATURE_ERMS) |
>  bitmaskof(X86_FEATURE_INVPCID) |
>  bitmaskof(X86_FEATURE_RTM)  |
> +((info->xfeature_mask != 0) ?
> +bitmaskof(X86_FEATURE_MPX) : 0)  |
>  bitmaskof(X86_FEATURE_RDSEED)  |
>  bitmaskof(X86_FEATURE_ADX)  |
>  bitmaskof(X86_FEATURE_SMAP) |
> @@ -538,6 +540,7 @@ static void xc_cpuid_pv_policy(xc_interface *xch,
>  
>  case 0x0007:
>  if ( input[1] == 0 )
> +{
>  regs[1] &= (bitmaskof(X86_FEATURE_BMI1) |
>  bitmaskof(X86_FEATURE_HLE)  |
>  bitmaskof(X86_FEATURE_AVX2) |
> @@ -547,6 +550,9 @@ static void xc_cpuid_pv_policy(xc_interface *xch,
>  bitmaskof(X86_FEATURE_RDSEED)  |
>  bitmaskof(X86_FEATURE_ADX)  |
>  bitmaskof(X86_FEATURE_FSGSBASE));
> +if ( info->xfeature_mask == 0 )
> +clear_bit(X86_FEATURE_MPX, regs[1]);
> +}
>  else
>  regs[1] = 0;
>  regs[0] = regs[2] = regs[3] = 0;
> -- 
> 1.9.1
> 
> 
> ___
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel