Re: [Xen-devel] [PATCH 07/13] ARM: Xen: Document UEFI support on Xen ARM virtual platforms
On Tue, 17 Nov 2015, David Vrabel wrote: > On 17/11/15 09:57, shannon.z...@linaro.org wrote: > > From: Shannon Zhao > > > > Add a "uefi" node under /hypervisor node in FDT, then Linux kernel could > > scan this to get the UEFI information. > [...] > > --- a/Documentation/devicetree/bindings/arm/xen.txt > > +++ b/Documentation/devicetree/bindings/arm/xen.txt > > @@ -15,6 +15,24 @@ the following properties: > > - interrupts: the interrupt used by Xen to inject event notifications. > >A GIC node is also required. > > > > +To support UEFI on Xen ARM virtual platforms, Xen pupulates the FDT "uefi" > > node > > +under /hypervisor with following parameters: > > It's not really clear why this is under /hypervisor and why xen needs to > define its own nodes. There was a very long discussion about this, see http://marc.info/?l=xen-devel&m=144321258920213 > The handling of the existing linux standard nodes can be made > Xen-specific by the presence of the /hypervisor/compatible == "xen" node > (or similar), right? > > > + > > +Name | Size | Description > > + > > +xen,uefi-system-table | 64-bit | Physical address of the UEFI System > > Table. > > + > > +xen,uefi-mmap-start | 64-bit | Physical address of the UEFI memory > > map. > > + > > I would probably say "Guest physical address..." just to be clear. > > > +xen,uefi-mmap-size| 32-bit | Size in bytes of the UEFI memory map > > + || pointed to in previous entry. > > + > > +xen,uefi-mmap-desc-size | 32-bit | Size in bytes of each entry in the > > UEFI > > + || memory map. > > + > > +xen,uefi-mmap-desc-ver| 32-bit | Version of the mmap descriptor format. > > + > > Need a reference to the mmap descriptor format here. > > David > ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 07/13] ARM: Xen: Document UEFI support on Xen ARM virtual platforms
On 2015/11/18 0:46, David Vrabel wrote: > On 17/11/15 09:57, shannon.z...@linaro.org wrote: >> From: Shannon Zhao >> >> Add a "uefi" node under /hypervisor node in FDT, then Linux kernel could >> scan this to get the UEFI information. > [...] >> --- a/Documentation/devicetree/bindings/arm/xen.txt >> +++ b/Documentation/devicetree/bindings/arm/xen.txt >> @@ -15,6 +15,24 @@ the following properties: >> - interrupts: the interrupt used by Xen to inject event notifications. >>A GIC node is also required. >> >> +To support UEFI on Xen ARM virtual platforms, Xen pupulates the FDT "uefi" >> node >> +under /hypervisor with following parameters: > > It's not really clear why this is under /hypervisor and why xen needs to > define its own nodes. > > The handling of the existing linux standard nodes can be made > Xen-specific by the presence of the /hypervisor/compatible == "xen" node > (or similar), right? > Right. The reason is that we want to separate this Xen specific UEFI from the normal UEFI. Don't make them mixed together. >> + >> +Name | Size | Description >> + >> +xen,uefi-system-table | 64-bit | Physical address of the UEFI System >> Table. >> + >> +xen,uefi-mmap-start | 64-bit | Physical address of the UEFI memory >> map. >> + > > I would probably say "Guest physical address..." just to be clear. > >> +xen,uefi-mmap-size| 32-bit | Size in bytes of the UEFI memory map >> + || pointed to in previous entry. >> + >> +xen,uefi-mmap-desc-size | 32-bit | Size in bytes of each entry in the UEFI >> + || memory map. >> + >> +xen,uefi-mmap-desc-ver| 32-bit | Version of the mmap descriptor format. >> + > > Need a reference to the mmap descriptor format here. > > David > > . > -- Shannon ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 07/13] ARM: Xen: Document UEFI support on Xen ARM virtual platforms
On 2015/11/18 4:44, Rob Herring wrote: > On Tue, Nov 17, 2015 at 05:57:05PM +0800, shannon.z...@linaro.org wrote: >> From: Shannon Zhao >> >> Add a "uefi" node under /hypervisor node in FDT, then Linux kernel could >> scan this to get the UEFI information. >> >> Signed-off-by: Shannon Zhao >> --- >> Documentation/devicetree/bindings/arm/xen.txt | 25 + >> 1 file changed, 25 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/xen.txt >> b/Documentation/devicetree/bindings/arm/xen.txt >> index 0f7b9c2..c375d67 100644 >> --- a/Documentation/devicetree/bindings/arm/xen.txt >> +++ b/Documentation/devicetree/bindings/arm/xen.txt >> @@ -15,6 +15,24 @@ the following properties: >> - interrupts: the interrupt used by Xen to inject event notifications. >>A GIC node is also required. >> >> +To support UEFI on Xen ARM virtual platforms, Xen pupulates the FDT "uefi" >> node >> +under /hypervisor with following parameters: >> + >> + >> +Name | Size | Description >> + >> +xen,uefi-system-table | 64-bit | Physical address of the UEFI System >> Table. >> + >> +xen,uefi-mmap-start | 64-bit | Physical address of the UEFI memory >> map. >> + >> +xen,uefi-mmap-size| 32-bit | Size in bytes of the UEFI memory map >> + || pointed to in previous entry. >> + >> +xen,uefi-mmap-desc-size | 32-bit | Size in bytes of each entry in the UEFI >> + || memory map. >> + >> +xen,uefi-mmap-desc-ver| 32-bit | Version of the mmap descriptor format. >> + > > Why aren't you using what is already populated by UEFI as defined in > Documentation/arm/uefi.txt? Seems to be about the same thing. > Yes, the parameters are similar. But since we can't find a good way to use normal UEFI for Xen Dom0 on ARM(there are some aspects which are not consistent with the UEFI spec), we have to introduce a Xen specific UEFI. Then we want to separate this from the normal UEFI completely and don't affect the normal use. So we add these parameter under Xenia specific node /hypervisor. For details of the previous discussion, look at below link: http://lists.xenproject.org/archives/html/xen-devel/2015-09/msg03295.html Thanks, -- Shannon ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 07/13] ARM: Xen: Document UEFI support on Xen ARM virtual platforms
On Tue, Nov 17, 2015 at 05:57:05PM +0800, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > Add a "uefi" node under /hypervisor node in FDT, then Linux kernel could > scan this to get the UEFI information. > > Signed-off-by: Shannon Zhao > --- > Documentation/devicetree/bindings/arm/xen.txt | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/xen.txt > b/Documentation/devicetree/bindings/arm/xen.txt > index 0f7b9c2..c375d67 100644 > --- a/Documentation/devicetree/bindings/arm/xen.txt > +++ b/Documentation/devicetree/bindings/arm/xen.txt > @@ -15,6 +15,24 @@ the following properties: > - interrupts: the interrupt used by Xen to inject event notifications. >A GIC node is also required. > > +To support UEFI on Xen ARM virtual platforms, Xen pupulates the FDT "uefi" > node > +under /hypervisor with following parameters: > + > + > +Name | Size | Description > + > +xen,uefi-system-table | 64-bit | Physical address of the UEFI System > Table. > + > +xen,uefi-mmap-start | 64-bit | Physical address of the UEFI memory map. > + > +xen,uefi-mmap-size| 32-bit | Size in bytes of the UEFI memory map > + || pointed to in previous entry. > + > +xen,uefi-mmap-desc-size | 32-bit | Size in bytes of each entry in the UEFI > + || memory map. > + > +xen,uefi-mmap-desc-ver| 32-bit | Version of the mmap descriptor format. > + Why aren't you using what is already populated by UEFI as defined in Documentation/arm/uefi.txt? Seems to be about the same thing. Rob ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 07/13] ARM: Xen: Document UEFI support on Xen ARM virtual platforms
On 17/11/15 09:57, shannon.z...@linaro.org wrote: > From: Shannon Zhao > > Add a "uefi" node under /hypervisor node in FDT, then Linux kernel could > scan this to get the UEFI information. [...] > --- a/Documentation/devicetree/bindings/arm/xen.txt > +++ b/Documentation/devicetree/bindings/arm/xen.txt > @@ -15,6 +15,24 @@ the following properties: > - interrupts: the interrupt used by Xen to inject event notifications. >A GIC node is also required. > > +To support UEFI on Xen ARM virtual platforms, Xen pupulates the FDT "uefi" > node > +under /hypervisor with following parameters: It's not really clear why this is under /hypervisor and why xen needs to define its own nodes. The handling of the existing linux standard nodes can be made Xen-specific by the presence of the /hypervisor/compatible == "xen" node (or similar), right? > + > +Name | Size | Description > + > +xen,uefi-system-table | 64-bit | Physical address of the UEFI System > Table. > + > +xen,uefi-mmap-start | 64-bit | Physical address of the UEFI memory map. > + I would probably say "Guest physical address..." just to be clear. > +xen,uefi-mmap-size| 32-bit | Size in bytes of the UEFI memory map > + || pointed to in previous entry. > + > +xen,uefi-mmap-desc-size | 32-bit | Size in bytes of each entry in the UEFI > + || memory map. > + > +xen,uefi-mmap-desc-ver| 32-bit | Version of the mmap descriptor format. > + Need a reference to the mmap descriptor format here. David ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
