Re: [Xen-devel] [PATCH 1/1] libxl: set stub domain size based on VRAM size

2015-07-10 Thread Ian Jackson 
Eric Shelton writes ([PATCH 1/1] libxl: set stub domain size based on VRAM 
size):
 Allocate additional memory to the stub domain for qemu-traditional if
 more than 4 MB is assigned to the video adapter to avoid out of memory
 condition for QEMU.

  dm_config-b_info.max_vcpus = 1;
  dm_config-b_info.max_memkb = 32 * 1024;
 +if (guest_config-b_info.video_memkb  4096)
 +dm_config-b_info.max_memkb += guest_config-b_info.video_memkb - 
 4096;

Thanks for diagnosing this.  This seems a reasonable approach to me.
I have only one small stylistic comment: please use max() as found in
libxl_internal.h.

Eg,

  dm_config-b_info.max_memkb = 28 * 1024 +
   max(guest_config-b_info.video_memkb, 4096);

Ian.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 1/1] libxl: set stub domain size based on VRAM size

2015-07-10 Thread Samuel Thibault 
Eric Shelton, le Fri 10 Jul 2015 11:36:02 -0400, a écrit :
 Allocate additional memory to the stub domain for qemu-traditional if
 more than 4 MB is assigned to the video adapter to avoid out of memory
 condition for QEMU.
 
 Signed-off-by: Eric Shelton eshel...@pobox.com

Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org

 ---
  tools/libxl/libxl_dm.c | 2 ++
  1 file changed, 2 insertions(+)
 
 diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
 index 317a8eb..9a5a937 100644
 --- a/tools/libxl/libxl_dm.c
 +++ b/tools/libxl/libxl_dm.c
 @@ -1087,6 +1087,8 @@ void libxl__spawn_stub_dm(libxl__egc *egc, 
 libxl__stub_dm_spawn_state *sdss)
  
  dm_config-b_info.max_vcpus = 1;
  dm_config-b_info.max_memkb = 32 * 1024;
 +if (guest_config-b_info.video_memkb  4096)
 +dm_config-b_info.max_memkb += guest_config-b_info.video_memkb - 
 4096;
  dm_config-b_info.target_memkb = dm_config-b_info.max_memkb;
  
  dm_config-b_info.u.pv.features = ;
 -- 
 2.1.0
 

-- 
Samuel
Client: This program has been successfully installed.
Vendeur (surpris): Et où voyez-vous une erreur ?
Client: C'est  HAS BEEN  !

___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel