Re: [Xen-devel] [PATCH 5/5 v2] xenconsole: Define and use a macro XEN_INVALID_PFN instead of -1
On 27 October 2017 at 12:34, Bhupinder Thakurwrote: > Hi Wei, > > On 26 October 2017 at 16:56, Wei Liu wrote: >> On Wed, Oct 25, 2017 at 02:57:08PM +0530, Bhupinder Thakur wrote: >>> xenconsole will use a new macro XEN_INVALID_PFN instead of -1 for >>> initializing ring-ref. >> >> Can you please paste in the error if the compilation fails with -1? >> >> The way this series is arranged make me wonder if the compilation is >> broken half way. We should avoid that. > It is not breaking the compilation. Since the type of ring_ref is > changed to xen_pfn_t (which is an unsigned value) assigning -1 > appeared to be confusing. For better clarity, XEN_INVALID_PFN is > introduced. I will update the commit message accordingly. Regards, Bhupinder ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 5/5 v2] xenconsole: Define and use a macro XEN_INVALID_PFN instead of -1
Hi Wei, On 26 October 2017 at 16:56, Wei Liuwrote: > On Wed, Oct 25, 2017 at 02:57:08PM +0530, Bhupinder Thakur wrote: >> xenconsole will use a new macro XEN_INVALID_PFN instead of -1 for >> initializing ring-ref. > > Can you please paste in the error if the compilation fails with -1? > > The way this series is arranged make me wonder if the compilation is > broken half way. We should avoid that. It is not breaking the compilation. Since the type of ring_ref is changed to xen_pfn_t (which is an unsigned value) assigning -1 appeared to be confusing. For better clarity, XEN_INVALID_PFN is introduced. Regards, Bhupinder ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH 5/5 v2] xenconsole: Define and use a macro XEN_INVALID_PFN instead of -1
On Wed, Oct 25, 2017 at 02:57:08PM +0530, Bhupinder Thakur wrote: > xenconsole will use a new macro XEN_INVALID_PFN instead of -1 for > initializing ring-ref. Can you please paste in the error if the compilation fails with -1? The way this series is arranged make me wonder if the compilation is broken half way. We should avoid that. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel