Re: [Xen-devel] [PATCH v1 7/7] tools: add userspace linker table sandbox

[H. Peter Anvin]

Vrabel ,Konrad Rzeszutek Wilk 
,Michael Brown ,Juergen Gross 
,Andrew Cooper ,Andy Shevchenko 
,Paul Gortmaker 
,"xen-de...@lists.xensource.com" 
,Andi Kleen 
,pali.ro...@gmail.com,dvh...@infradead.org,platform-driver-...@vger.kernel.org,Michal
 Marek ,Rasmus Villemoes ,Jiri 
Kosina ,=?UTF-8?B?7KGw6rK966+8?= 
,linux-kbuild ,Tony Luck 
,Andrew Morton 
,linux-i...@vger.kernel.org,"linux-arm-ker...@lists.infradead.org"
 ,linux-sh 
,sparclinux ,Catalin 
Marinas ,Will Deacon ,Ste!
 ven
Rostedt ,Jani Nikula ,Mauro 
Carvalho Chehab 
,markus.hei...@darmarit.de,jo...@kernel.org,Mark 
Salter ,Chris Zankel ,Max Filippov 
,linux-xte...@linux-xtensa.org,Paul Mackerras 
,Michael Ellerman ,James Bottomley 

Message-ID: <58f06cea-aeb3-4ed7-8211-95f402c9d...@zytor.com>

On August 22, 2016 5:07:39 PM PDT, "Luis R. Rodriguez"  
wrote:
>On Fri, Aug 19, 2016 at 03:31:47PM -0700, Kees Cook wrote:
>> On Fri, Aug 19, 2016 at 2:41 PM,   wrote:
>> > From: "Luis R. Rodriguez" 
>> >
>> > Add a userspace sandbox to allow easy experimentation and
>> > test extensions with linker tables, section ranges and the
>> > new section core definitions.
>> >
>> > The userspace sandbox tries to mimic the Linux kernel development
>> > flow as much as possible, it however relies on and uses libc.
>Support
>> > is currently only provided to x86_64.
>> >
>> > v4: this patch is new in this series -- added to the kenrel as
>> > suggested by Boris, as otherwise it'd be really hard to keep
>> > an external userspace repository in sync.
>> >
>> > Signed-off-by: Luis R. Rodriguez 
>> > ---
>> >  Documentation/sections/linker-tables.rst   |   4 +-
>> >  MAINTAINERS|   1 +
>> >  include/linux/tables.h |   5 +-
>> >  tools/Makefile |   3 +-
>> >  .../arch/x86/include/generated/asm/section-core.h  |   1 +
>> >  tools/arch/x86/include/generated/ranges.h  |   1 +
>> >  tools/arch/x86/include/generated/tables.h  |   1 +
>> >  tools/include/asm-generic/ranges.h | 103 
>> >  tools/include/asm-generic/section-core.h   | 341
>+++
>> >  tools/include/asm-generic/tables.h |  50 ++
>> 
>> Aren't a bunch of these files exact duplicates of the headers in
>include/linux?
>
>Indeed... This a userspace tools/ architecture decision that was made
>long ago,
>so its not up to me, I am just following the strategy devised and
>picked up.
>Refer to 7d7d1bf1d1dabe435ef50efb051724b8664749cb ("perf bench: Copy
>kernel
>files needed to build mem{cpy,set} x86_64 benchmarks") for an example
>of
>previous similar work. By sharing header files this enable more tools/
>to be hacked on.
>
>  Luis

I think this is a legacy from before the uapi change that should really be 
fixed.  If we need to export additional kernel structures for the tools, we 
could define a third level of we really need it.
-- 
Sent from my Android device with K-9 Mail. Please excuse brevity and formatting.

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v1 7/7] tools: add userspace linker table sandbox

[Luis R. Rodriguez]

On Fri, Aug 19, 2016 at 03:31:47PM -0700, Kees Cook wrote:
> On Fri, Aug 19, 2016 at 2:41 PM,   wrote:
> > From: "Luis R. Rodriguez" 
> >
> > Add a userspace sandbox to allow easy experimentation and
> > test extensions with linker tables, section ranges and the
> > new section core definitions.
> >
> > The userspace sandbox tries to mimic the Linux kernel development
> > flow as much as possible, it however relies on and uses libc. Support
> > is currently only provided to x86_64.
> >
> > v4: this patch is new in this series -- added to the kenrel as
> > suggested by Boris, as otherwise it'd be really hard to keep
> > an external userspace repository in sync.
> >
> > Signed-off-by: Luis R. Rodriguez 
> > ---
> >  Documentation/sections/linker-tables.rst   |   4 +-
> >  MAINTAINERS|   1 +
> >  include/linux/tables.h |   5 +-
> >  tools/Makefile |   3 +-
> >  .../arch/x86/include/generated/asm/section-core.h  |   1 +
> >  tools/arch/x86/include/generated/ranges.h  |   1 +
> >  tools/arch/x86/include/generated/tables.h  |   1 +
> >  tools/include/asm-generic/ranges.h | 103 
> >  tools/include/asm-generic/section-core.h   | 341 +++
> >  tools/include/asm-generic/tables.h |  50 ++
> 
> Aren't a bunch of these files exact duplicates of the headers in 
> include/linux?

Indeed... This a userspace tools/ architecture decision that was made long ago,
so its not up to me, I am just following the strategy devised and picked up.
Refer to 7d7d1bf1d1dabe435ef50efb051724b8664749cb ("perf bench: Copy kernel
files needed to build mem{cpy,set} x86_64 benchmarks") for an example of
previous similar work. By sharing header files this enable more tools/
to be hacked on.

  Luis

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v1 7/7] tools: add userspace linker table sandbox

[Kees Cook]

On Fri, Aug 19, 2016 at 2:41 PM,   wrote:
> From: "Luis R. Rodriguez" 
>
> Add a userspace sandbox to allow easy experimentation and
> test extensions with linker tables, section ranges and the
> new section core definitions.
>
> The userspace sandbox tries to mimic the Linux kernel development
> flow as much as possible, it however relies on and uses libc. Support
> is currently only provided to x86_64.
>
> v4: this patch is new in this series -- added to the kenrel as
> suggested by Boris, as otherwise it'd be really hard to keep
> an external userspace repository in sync.
>
> Signed-off-by: Luis R. Rodriguez 
> ---
>  Documentation/sections/linker-tables.rst   |   4 +-
>  MAINTAINERS|   1 +
>  include/linux/tables.h |   5 +-
>  tools/Makefile |   3 +-
>  .../arch/x86/include/generated/asm/section-core.h  |   1 +
>  tools/arch/x86/include/generated/ranges.h  |   1 +
>  tools/arch/x86/include/generated/tables.h  |   1 +
>  tools/include/asm-generic/ranges.h | 103 
>  tools/include/asm-generic/section-core.h   | 341 +++
>  tools/include/asm-generic/tables.h |  50 ++

Aren't a bunch of these files exact duplicates of the headers in include/linux?

-Kees

-- 
Kees Cook
Nexus Security

___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel