Re: [Xen-devel] [PATCH v2 for-4.5 0/2] xl/libxl: fix API and two memory leaks
On Mon, 2014-12-01 at 11:31 +, Wei Liu wrote: > Return value of libxl_basename was erroneously marked as "const". This > series removes that "const" and fixes two memory leaks in xl. > > I think these fixes should be included in 4.5, given that they fix real > issues and are very straight foward to reason about. Agreed. Both patches: Acked-by: Ian Campbell I've added the CCs to this intro mail... Did you by any chance look for other const char * return values? Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v2 for-4.5 0/2] xl/libxl: fix API and two memory leaks
On Mon, Dec 01, 2014 at 11:40:09AM +, Ian Campbell wrote: > On Mon, 2014-12-01 at 11:31 +, Wei Liu wrote: > > Return value of libxl_basename was erroneously marked as "const". This > > series removes that "const" and fixes two memory leaks in xl. > > > > I think these fixes should be included in 4.5, given that they fix real > > issues and are very straight foward to reason about. > > Agreed. Both patches: > Acked-by: Ian Campbell > > I've added the CCs to this intro mail... > > Did you by any chance look for other const char * return values? > I've looked at other public API headers. I didn't spot other obvious problems with regard to const char * return values. Wei. > Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v2 for-4.5 0/2] xl/libxl: fix API and two memory leaks
On Mon, 2014-12-01 at 11:50 +, Wei Liu wrote: > On Mon, Dec 01, 2014 at 11:40:09AM +, Ian Campbell wrote: > > On Mon, 2014-12-01 at 11:31 +, Wei Liu wrote: > > > Return value of libxl_basename was erroneously marked as "const". This > > > series removes that "const" and fixes two memory leaks in xl. > > > > > > I think these fixes should be included in 4.5, given that they fix real > > > issues and are very straight foward to reason about. > > > > Agreed. Both patches: > > Acked-by: Ian Campbell > > > > I've added the CCs to this intro mail... > > > > Did you by any chance look for other const char * return values? > > > > I've looked at other public API headers. I didn't spot other obvious > problems with regard to const char * return values. Super, thanks! ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v2 for-4.5 0/2] xl/libxl: fix API and two memory leaks
On Mon, Dec 01, 2014 at 11:31:11AM +, Wei Liu wrote: > Return value of libxl_basename was erroneously marked as "const". This > series removes that "const" and fixes two memory leaks in xl. > > I think these fixes should be included in 4.5, given that they fix real > issues and are very straight foward to reason about. Thank you for catching those! Release-Acked-by: Konrad Rzeszutek Wilk > > Wei. > > Wei Liu (2): > libxl: un-constify return value of libxl_basename > xl: fix two memory leaks > > tools/libxl/libxl.h | 10 ++ > tools/libxl/libxl_utils.c |5 - > tools/libxl/libxl_utils.h |6 +- > tools/libxl/xl_cmdimpl.c |8 ++-- > 4 files changed, 25 insertions(+), 4 deletions(-) > > -- > 1.7.10.4 > ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Re: [Xen-devel] [PATCH v2 for-4.5 0/2] xl/libxl: fix API and two memory leaks
On Mon, 2014-12-01 at 16:54 -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Dec 01, 2014 at 11:31:11AM +, Wei Liu wrote: > > Return value of libxl_basename was erroneously marked as "const". This > > series removes that "const" and fixes two memory leaks in xl. > > > > I think these fixes should be included in 4.5, given that they fix real > > issues and are very straight foward to reason about. > > Thank you for catching those! > > Release-Acked-by: Konrad Rzeszutek Wilk Applied both, including the modification discussed in my reply to the second. > > > > Wei. > > > > Wei Liu (2): > > libxl: un-constify return value of libxl_basename > > xl: fix two memory leaks > > > > tools/libxl/libxl.h | 10 ++ > > tools/libxl/libxl_utils.c |5 - > > tools/libxl/libxl_utils.h |6 +- > > tools/libxl/xl_cmdimpl.c |8 ++-- > > 4 files changed, 25 insertions(+), 4 deletions(-) > > > > -- > > 1.7.10.4 > > > > ___ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
